From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 23/29] atari_scsi: Convert to platform device Date: Mon, 6 Oct 2014 10:36:21 +0200 Message-ID: References: <20141002065628.256592712@telegraphics.com.au> <20141002065633.766165263@telegraphics.com.au> <54308629.6060800@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-la0-f49.google.com ([209.85.215.49]:33638 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbaJFIgY (ORCPT ); Mon, 6 Oct 2014 04:36:24 -0400 In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Finn Thain Cc: Michael Schmitz , "James E.J. Bottomley" , Sam Creasey , scsi , Linux/m68k On Mon, Oct 6, 2014 at 9:05 AM, Finn Thain wrote: >> > > > + if (IS_A_TT()) >> > > > + instance->irq = IRQ_TT_MFP_SCSI; >> > > > + else >> > > > + instance->irq = IRQ_NONE; >> > > > >> > > platform_device resource? >> > > >> > >> > If I thought it possible to parameterize the driver such that it never >> > had to test IS_A_TT(), I'd probably agree that this would be more >> > elegant. >> > >> > Otherwise I'd prefer not to have parts of the logic separated off into >> > the platform resources while the remaining logic remains in the driver >> > itself. >> > >> > While I don't think platform resources are desirable in this driver, I >> > would like to hear Michael's views. >> > >> >> The IRQ is a good candidate to be passed via platform data. > > Geert didn't say so, but after thinking about his review comments I > imagine that he wants all the Atari IRQ numbers kept in one place and all > the Mac IRQ numbers in a different place, and so on. Makes sense. In the end, it's the same SCSI chip. The "only" differences are resources, interrupts, DMA, and glue logic. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds