From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71118C41514 for ; Tue, 20 Aug 2019 18:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55CD920C01 for ; Tue, 20 Aug 2019 18:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730267AbfHTSIx (ORCPT ); Tue, 20 Aug 2019 14:08:53 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:46242 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbfHTSIx (ORCPT ); Tue, 20 Aug 2019 14:08:53 -0400 Received: by mail-ot1-f66.google.com with SMTP id z17so5892748otk.13; Tue, 20 Aug 2019 11:08:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2V1mGMCstWnpcKzMKvJ0w9fxy2kbmS/s8lE+TTa+kuE=; b=fTc0zN5WoSWkUWo2d5nChFS2hmYUgXRzKRF5+BtDcOo5Y5+JqLiQ1KL0CbXEcvgjSe YcnfSdoKkd94alxeDJXIJ7kyqSWmBzew0OlLpOYluixkUeywXLCLjXuNfr4i7ShnKshe C0gF7q6Cg1ocz0rrpCXGCAbVjjwklyq9FNrqOf+/kogol6KuK9LUMtymwVm3glHGSEcZ js1QY0oJI+aK9FlRTUFnJKr1SGMyl24iidSXqAEjpF3IHn21Ob0//a5OZ5I3ey0N1Tsa NH4ogMBtT/nEesWJ4dDZOxTzSY9nCyK9JvYZ/n8gQ2dMeQ8jluuJnDdDqQ6fwpTzL+vA VNvA== X-Gm-Message-State: APjAAAVazMOEYyZ5zdEYblVswtRROJpW05hz8M9vJTko4i4JQF5MLPF7 hrVV7bqWC6Lt8caNSyEkLSlNafJbQSMB6Rxtocg= X-Google-Smtp-Source: APXvYqzBUkEblq/MiYoqxtiYIJSp/mB+lLzwSmJnKZhFoXC5ylVOF7iTENS+UuicCsmexIJBI3y8fX2QgWxZAOSn+Cw= X-Received: by 2002:a9d:7a90:: with SMTP id l16mr24288910otn.297.1566324531299; Tue, 20 Aug 2019 11:08:51 -0700 (PDT) MIME-Version: 1.0 References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-2-jacopo+renesas@jmondi.org> <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> <20190820174110.GH10820@pendragon.ideasonboard.com> In-Reply-To: <20190820174110.GH10820@pendragon.ideasonboard.com> From: Geert Uytterhoeven Date: Tue, 20 Aug 2019 20:08:40 +0200 Message-ID: Subject: Re: [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation To: Laurent Pinchart Cc: Jacopo Mondi , Jacopo Mondi , Kieran Bingham , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Tue, Aug 20, 2019 at 7:41 PM Laurent Pinchart wrote: > On Tue, Aug 20, 2019 at 09:53:44AM +0200, Geert Uytterhoeven wrote: > > On Tue, Aug 20, 2019 at 9:47 AM Jacopo Mondi wrote: > > > On Mon, Aug 19, 2019 at 03:45:54PM +0200, Geert Uytterhoeven wrote: > > >> On Mon, Jul 8, 2019 at 9:58 AM Geert Uytterhoeven wrote: > > >>> On Sat, Jul 6, 2019 at 4:07 PM Jacopo Mondi wrote: > > >>>> Add device tree bindings documentation for the Renesas R-Car Display > > >>>> Unit Color Management Module. > > >>>> > > >>>> CMM is the image enhancement module available on each R-Car DU video > > >>>> channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > >>>> > > >>>> Signed-off-by: Jacopo Mondi > > >>>> Reviewed-by: Laurent Pinchart > > >>> > > >>> Thanks for your patch! > > >>> > > >>>> --- /dev/null > > >>>> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > >>>> @@ -0,0 +1,25 @@ > > >>>> +* Renesas R-Car Color Management Module (CMM) > > >>>> + > > >>>> +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > >>>> + > > >>>> +Required properties: > > >>>> + - compatible: shall be one of: > > >>>> + - "renesas,rcar-gen3-cmm" > > >>>> + - "renesas,rcar-gen2-cmm" > > >>> > > >>> Why do you think you do not need SoC-specific compatible values? > > >>> What if you discover a different across the R-Car Gen3 line tomorrow? > > >>> Does the IP block have a version register? > > >> > > >> Do you have an answer to these questions? > > > > > > It does not seem to me that CMM has any version register, nor there > > > are differences between the different Gen3 SoCs.. > > > > > > However, even if we now define a single compatible property for > > > gen3/gen2 and we later find out one of the SoC needs a soc-specific > > > property we can safely add it and keep the generic gen3/gen2 one as > > > fallback.. Does it work for you? > > > > Unfortunately that won't work, as the existing DTBs won't have the > > soc-specific compatible value. > > You could still resort to soc_device_match(), but it is better to avoid that. > > We've had the same discussion over and over for quite a long time :-) I > wonder, now that we have implemented SoC-specific compatible values for > many IP cores, how many of them have actually benefited from it ? I'm > not considering IP cores where we knew from the start that each SoC was > different (such as pinctrl or clocks for instance), but IP cores where > we though all SoCs would be handled in the same way. I also wouldn't > count ES-specific differences, as those are handled by > soc_device_match() anyway. Thank you for making me dive into this ;-) For R-Car Gen3 only: DRIF? The driver still matches against "renesas,rcar-gen3-drif", but we found a difference on M3-N (didn't check if that was documented initially or not). PCIe? IIRC, there is still a special PHY register on one of the V3x SoCs that the driver doesn't handle yet, and wasn't documented initially. RPC-IF? Lots of small differences (you can claim they were documented, but they were unexpected), and non-documented different magic values in the (not yet upstreamed) driver. SOUND? R-Car E3 special handling was bolted on later. Thermal? M3-W turned out to have a different Tj than the other SoCs using the same thermal module (yeah, thermal is a bad example, as some Gen3 SoCs use the Gen2 thermal module, so we needed to differentiate anyway). USBHS? Initially we thought Gen3 was identical to Gen2. Later it turned out that (1) wasn't true, and (2) E3/D3 used a different PLL than the other Gen3 SoCs. VIN? IIRC, we initialize thought a family-specific compatible value would work for Gen3, like it did for Gen2, but had to reconsider. I may have missed some... Convinced? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 01/19] dt-bindings: display: renesas, cmm: Add R-Car CMM documentation Date: Tue, 20 Aug 2019 20:08:40 +0200 Message-ID: References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-2-jacopo+renesas@jmondi.org> <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> <20190820174110.GH10820@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 523166E1BE for ; Tue, 20 Aug 2019 18:08:52 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id w4so5888882ote.11 for ; Tue, 20 Aug 2019 11:08:52 -0700 (PDT) In-Reply-To: <20190820174110.GH10820@pendragon.ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: muroya@ksk.co.jp, Jacopo Mondi , VenkataRajesh.Kalakodima@in.bosch.com, David Airlie , Koji Matsuoka , DRI Development , Linux Kernel Mailing List , Linux-Renesas , Kieran Bingham , Jacopo Mondi , Harsha.ManjulaMallikarjun@in.bosch.com List-Id: dri-devel@lists.freedesktop.org SGkgTGF1cmVudCwKCk9uIFR1ZSwgQXVnIDIwLCAyMDE5IGF0IDc6NDEgUE0gTGF1cmVudCBQaW5j aGFydAo8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPiB3cm90ZToKPiBPbiBUdWUs IEF1ZyAyMCwgMjAxOSBhdCAwOTo1Mzo0NEFNICswMjAwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3Jv dGU6Cj4gPiBPbiBUdWUsIEF1ZyAyMCwgMjAxOSBhdCA5OjQ3IEFNIEphY29wbyBNb25kaSA8amFj b3BvQGptb25kaS5vcmc+IHdyb3RlOgo+ID4gPiBPbiBNb24sIEF1ZyAxOSwgMjAxOSBhdCAwMzo0 NTo1NFBNICswMjAwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gPiA+PiBPbiBNb24sIEp1 bCA4LCAyMDE5IGF0IDk6NTggQU0gR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydEBsaW51eC1tNjhr Lm9yZz4gd3JvdGU6Cj4gPiA+Pj4gT24gU2F0LCBKdWwgNiwgMjAxOSBhdCA0OjA3IFBNIEphY29w byBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4gd3JvdGU6Cj4gPiA+Pj4+IEFkZCBk ZXZpY2UgdHJlZSBiaW5kaW5ncyBkb2N1bWVudGF0aW9uIGZvciB0aGUgUmVuZXNhcyBSLUNhciBE aXNwbGF5Cj4gPiA+Pj4+IFVuaXQgQ29sb3IgTWFuYWdlbWVudCBNb2R1bGUuCj4gPiA+Pj4+Cj4g PiA+Pj4+IENNTSBpcyB0aGUgaW1hZ2UgZW5oYW5jZW1lbnQgbW9kdWxlIGF2YWlsYWJsZSBvbiBl YWNoIFItQ2FyIERVIHZpZGVvCj4gPiA+Pj4+IGNoYW5uZWwgb24gUi1DYXIgR2VuMiBhbmQgR2Vu MyBTb0NzIChWM0ggYW5kIFYzTSBleGNsdWRlZCkuCj4gPiA+Pj4+Cj4gPiA+Pj4+IFNpZ25lZC1v ZmYtYnk6IEphY29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4KPiA+ID4+Pj4g UmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJv YXJkLmNvbT4KPiA+ID4+Pgo+ID4gPj4+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCEKPiA+ID4+Pgo+ ID4gPj4+PiAtLS0gL2Rldi9udWxsCj4gPiA+Pj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JlbmVzYXMsY21tLnR4dAo+ID4gPj4+PiBAQCAtMCwwICsx LDI1IEBACj4gPiA+Pj4+ICsqIFJlbmVzYXMgUi1DYXIgQ29sb3IgTWFuYWdlbWVudCBNb2R1bGUg KENNTSkKPiA+ID4+Pj4gKwo+ID4gPj4+PiArUmVuZXNhcyBSLUNhciBpbWFnZSBlbmhhbmNlbWVu dCBtb2R1bGUgY29ubmVjdGVkIHRvIFItQ2FyIERVIHZpZGVvIGNoYW5uZWxzLgo+ID4gPj4+PiAr Cj4gPiA+Pj4+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gPj4+PiArIC0gY29tcGF0aWJsZTog c2hhbGwgYmUgb25lIG9mOgo+ID4gPj4+PiArICAgLSAicmVuZXNhcyxyY2FyLWdlbjMtY21tIgo+ ID4gPj4+PiArICAgLSAicmVuZXNhcyxyY2FyLWdlbjItY21tIgo+ID4gPj4+Cj4gPiA+Pj4gV2h5 IGRvIHlvdSB0aGluayB5b3UgZG8gbm90IG5lZWQgU29DLXNwZWNpZmljIGNvbXBhdGlibGUgdmFs dWVzPwo+ID4gPj4+IFdoYXQgaWYgeW91IGRpc2NvdmVyIGEgZGlmZmVyZW50IGFjcm9zcyB0aGUg Ui1DYXIgR2VuMyBsaW5lIHRvbW9ycm93Pwo+ID4gPj4+IERvZXMgdGhlIElQIGJsb2NrIGhhdmUg YSB2ZXJzaW9uIHJlZ2lzdGVyPwo+ID4gPj4KPiA+ID4+IERvIHlvdSBoYXZlIGFuIGFuc3dlciB0 byB0aGVzZSBxdWVzdGlvbnM/Cj4gPiA+Cj4gPiA+IEl0IGRvZXMgbm90IHNlZW0gdG8gbWUgdGhh dCBDTU0gaGFzIGFueSB2ZXJzaW9uIHJlZ2lzdGVyLCBub3IgdGhlcmUKPiA+ID4gYXJlIGRpZmZl cmVuY2VzIGJldHdlZW4gdGhlIGRpZmZlcmVudCBHZW4zIFNvQ3MuLgo+ID4gPgo+ID4gPiBIb3dl dmVyLCBldmVuIGlmIHdlIG5vdyBkZWZpbmUgYSBzaW5nbGUgY29tcGF0aWJsZSBwcm9wZXJ0eSBm b3IKPiA+ID4gZ2VuMy9nZW4yIGFuZCB3ZSBsYXRlciBmaW5kIG91dCBvbmUgb2YgdGhlIFNvQyBu ZWVkcyBhIHNvYy1zcGVjaWZpYwo+ID4gPiBwcm9wZXJ0eSB3ZSBjYW4gc2FmZWx5IGFkZCBpdCBh bmQga2VlcCB0aGUgZ2VuZXJpYyBnZW4zL2dlbjIgb25lIGFzCj4gPiA+IGZhbGxiYWNrLi4gRG9l cyBpdCB3b3JrIGZvciB5b3U/Cj4gPgo+ID4gVW5mb3J0dW5hdGVseSB0aGF0IHdvbid0IHdvcmss IGFzIHRoZSBleGlzdGluZyBEVEJzIHdvbid0IGhhdmUgdGhlCj4gPiBzb2Mtc3BlY2lmaWMgY29t cGF0aWJsZSB2YWx1ZS4KPiA+IFlvdSBjb3VsZCBzdGlsbCByZXNvcnQgdG8gc29jX2RldmljZV9t YXRjaCgpLCBidXQgaXQgaXMgYmV0dGVyIHRvIGF2b2lkIHRoYXQuCj4KPiBXZSd2ZSBoYWQgdGhl IHNhbWUgZGlzY3Vzc2lvbiBvdmVyIGFuZCBvdmVyIGZvciBxdWl0ZSBhIGxvbmcgdGltZSA6LSkg SQo+IHdvbmRlciwgbm93IHRoYXQgd2UgaGF2ZSBpbXBsZW1lbnRlZCBTb0Mtc3BlY2lmaWMgY29t cGF0aWJsZSB2YWx1ZXMgZm9yCj4gbWFueSBJUCBjb3JlcywgaG93IG1hbnkgb2YgdGhlbSBoYXZl IGFjdHVhbGx5IGJlbmVmaXRlZCBmcm9tIGl0ID8gSSdtCj4gbm90IGNvbnNpZGVyaW5nIElQIGNv cmVzIHdoZXJlIHdlIGtuZXcgZnJvbSB0aGUgc3RhcnQgdGhhdCBlYWNoIFNvQyB3YXMKPiBkaWZm ZXJlbnQgKHN1Y2ggYXMgcGluY3RybCBvciBjbG9ja3MgZm9yIGluc3RhbmNlKSwgYnV0IElQIGNv cmVzIHdoZXJlCj4gd2UgdGhvdWdoIGFsbCBTb0NzIHdvdWxkIGJlIGhhbmRsZWQgaW4gdGhlIHNh bWUgd2F5LiBJIGFsc28gd291bGRuJ3QKPiBjb3VudCBFUy1zcGVjaWZpYyBkaWZmZXJlbmNlcywg YXMgdGhvc2UgYXJlIGhhbmRsZWQgYnkKPiBzb2NfZGV2aWNlX21hdGNoKCkgYW55d2F5LgoKVGhh bmsgeW91IGZvciBtYWtpbmcgbWUgZGl2ZSBpbnRvIHRoaXMgOy0pCgpGb3IgUi1DYXIgR2VuMyBv bmx5OgoKRFJJRj8KVGhlIGRyaXZlciBzdGlsbCBtYXRjaGVzIGFnYWluc3QgInJlbmVzYXMscmNh ci1nZW4zLWRyaWYiLCBidXQgd2UgZm91bmQgYQpkaWZmZXJlbmNlIG9uIE0zLU4gKGRpZG4ndCBj aGVjayBpZiB0aGF0IHdhcyBkb2N1bWVudGVkIGluaXRpYWxseSBvciBub3QpLgoKUENJZT8KSUlS QywgdGhlcmUgaXMgc3RpbGwgYSBzcGVjaWFsIFBIWSByZWdpc3RlciBvbiBvbmUgb2YgdGhlIFYz eCBTb0NzIHRoYXQKdGhlIGRyaXZlciBkb2Vzbid0IGhhbmRsZSB5ZXQsIGFuZCB3YXNuJ3QgZG9j dW1lbnRlZCBpbml0aWFsbHkuCgpSUEMtSUY/CkxvdHMgb2Ygc21hbGwgZGlmZmVyZW5jZXMgKHlv dSBjYW4gY2xhaW0gdGhleSB3ZXJlIGRvY3VtZW50ZWQsIGJ1dCB0aGV5CndlcmUgdW5leHBlY3Rl ZCksIGFuZCBub24tZG9jdW1lbnRlZCBkaWZmZXJlbnQgbWFnaWMgdmFsdWVzIGluIHRoZQoobm90 IHlldCB1cHN0cmVhbWVkKSBkcml2ZXIuCgpTT1VORD8KUi1DYXIgRTMgc3BlY2lhbCBoYW5kbGlu ZyB3YXMgYm9sdGVkIG9uIGxhdGVyLgoKVGhlcm1hbD8KTTMtVyB0dXJuZWQgb3V0IHRvIGhhdmUg YSBkaWZmZXJlbnQgVGogdGhhbiB0aGUgb3RoZXIgU29DcyB1c2luZyB0aGUgc2FtZQp0aGVybWFs IG1vZHVsZSAoeWVhaCwgdGhlcm1hbCBpcyBhIGJhZCBleGFtcGxlLCBhcyBzb21lIEdlbjMgU29D cyB1c2UKdGhlIEdlbjIgdGhlcm1hbCBtb2R1bGUsIHNvIHdlIG5lZWRlZCB0byBkaWZmZXJlbnRp YXRlIGFueXdheSkuCgpVU0JIUz8KSW5pdGlhbGx5IHdlIHRob3VnaHQgR2VuMyB3YXMgaWRlbnRp Y2FsIHRvIEdlbjIuICBMYXRlciBpdCB0dXJuZWQgb3V0IHRoYXQKKDEpIHdhc24ndCB0cnVlLCBh bmQgKDIpIEUzL0QzIHVzZWQgYSBkaWZmZXJlbnQgUExMIHRoYW4gdGhlIG90aGVyIEdlbjMKU29D cy4KClZJTj8KSUlSQywgd2UgaW5pdGlhbGl6ZSB0aG91Z2h0IGEgZmFtaWx5LXNwZWNpZmljIGNv bXBhdGlibGUgdmFsdWUgd291bGQgd29yawpmb3IgR2VuMywgbGlrZSBpdCBkaWQgZm9yIEdlbjIs IGJ1dCBoYWQgdG8gcmVjb25zaWRlci4KCkkgbWF5IGhhdmUgbWlzc2VkIHNvbWUuLi4KCkNvbnZp bmNlZD8KCkdye29ldGplLGVldGluZ31zLAoKICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQK Ci0tIApHZWVydCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4IGJleW9uZCBp YTMyIC0tIGdlZXJ0QGxpbnV4LW02OGsub3JnCgpJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdp dGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0CndoZW4gSSdt IHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRo aW5nIGxpa2UgdGhhdC4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBU b3J2YWxkcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=