Re: [PATCH] pinctrl: sh-pfc: r8a77990: Add PWM pins, groups and functions

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Laurent,

On Wed, Sep 19, 2018 at 2:18 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The R8A77990 (E3) SoC has 7 PWM outputs, add pins, groups and functions
> for all of them.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks for yur patch, but PWm has already been added, cfr.
https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=sh-pfc-for-v4.20&id=951ae7cb068ffdc53afe6cb532aa5a3f215beaa2

> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c

> +/* - PWM3 --------------------------------------------------------------------*/
> +static const unsigned int pwm3_a_pins[] = {
> +       /* PWM */
> +       RCAR_GP_PIN(1, 1),
> +};
> +static const unsigned int pwm3_a_mux[] = {
> +       PWM3_A_MARK,
> +};
> +static const unsigned int pwm3_b_pins[] = {
> +       /* PWM */
> +       RCAR_GP_PIN(2, 5),

Should be 1, 5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds