From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B1AC4338F for ; Mon, 23 Aug 2021 11:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9B336054E for ; Mon, 23 Aug 2021 11:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235953AbhHWMAj (ORCPT ); Mon, 23 Aug 2021 08:00:39 -0400 Received: from mail-vs1-f54.google.com ([209.85.217.54]:43702 "EHLO mail-vs1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233489AbhHWMAj (ORCPT ); Mon, 23 Aug 2021 08:00:39 -0400 Received: by mail-vs1-f54.google.com with SMTP id j186so10889242vsc.10; Mon, 23 Aug 2021 04:59:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bMRXnqBVA9CZEqnX3UVE4nmccCLqccIYzxKtXkgnlzg=; b=SLhzmdzQL3v5+oCQzsrGT1kcd6R4JsEubAqdGmYZuLBXcB9m04PDNZGCpMTYFxR6x9 3qq+rAP/oKNeoYab9ss8f7Vs5dczX73OYkN5f6WAmL4YQ3NttFI16w3wZv74EDd5ao/A NTQ3SvLZ8nkv9QamX23nIh3O1TvSs9anM5rN4AkjX3wvRs95H0xAiHBTlY8TaC3k4lUZ nJAckMPdwwCszPRneRATJSvm6G7eIG7B7LICz36uNRwq6Ly7QYOzdJGHDN1Zctw98KYW uRWBSDNU9eLtmAawG6Ao+xB57l4kh/eCxuoJJPGh+uGszHk7TsBSZN4R8m/6iqvT2UXY wPAA== X-Gm-Message-State: AOAM532S8MRT6ApaKa5wG1NbNh6WwjmsYTPWvBsSo3YbBydHpjDYvjCn xU5vKarmGOTT21Ih3x6tPbRHio0ZvVWL7squ+d4= X-Google-Smtp-Source: ABdhPJzD25RT28be79TeoWOfxhPVTeZC2RLR71pr/rQh0tohR21TJiJw9gIz0Xwj+B2v/w5AIug9k3/GO0LwM2g8GaA= X-Received: by 2002:a67:c789:: with SMTP id t9mr23561585vsk.60.1629719996239; Mon, 23 Aug 2021 04:59:56 -0700 (PDT) MIME-Version: 1.0 References: <20210818165604.22127-1-zhengxunli.mxic@gmail.com> In-Reply-To: <20210818165604.22127-1-zhengxunli.mxic@gmail.com> From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 13:59:45 +0200 Message-ID: Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address To: Zhengxun Cc: Mark Brown , linux-spi , Linux-Renesas , zhengxunli , Sergey Shtylyov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org CC sergey's new address On Wed, Aug 18, 2021 at 10:57 AM Zhengxun wrote: > In the RPC manual mode, if the data direction is not set > (such as the flash erase command), the address misses the > setting. > > Signed-off-by: Zhengxun > --- > drivers/memory/renesas-rpc-if.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c > index 45eed659b0c6..9dd27c6307f7 100644 > --- a/drivers/memory/renesas-rpc-if.c > +++ b/drivers/memory/renesas-rpc-if.c > @@ -482,6 +482,7 @@ int rpcif_manual_xfer(struct rpcif *rpc) > } > break; > default: > + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr); > regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable); > regmap_write(rpc->regmap, RPCIF_SMCR, > rpc->smcr | RPCIF_SMCR_SPIE); > -- > 2.17.1