From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 2/3] ARM: dts: r7s72100: add ethernet to device tree Date: Thu, 1 Sep 2016 22:50:12 +0200 Message-ID: References: <20160901155430.23400-1-chris.brandt@renesas.com> <20160901155430.23400-2-chris.brandt@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160901155430.23400-2-chris.brandt@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chris Brandt Cc: Mark Rutland , "devicetree@vger.kernel.org" , Magnus Damm , Linux-Renesas , Rob Herring , Simon Horman , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt wrote: > Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven But... > ---" > arch/arm/boot/dts/r7s72100.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index e8e2a5d7..fb9ef9c 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -108,6 +108,15 @@ > clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7"; > }; > > + mstp7_clks: mstp7_clks@fcfe0430 { > + #clock-cells = <1>; > + compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > + reg = <0xfcfe0430 4>; > + clocks = <&p0_clk>; > + clock-indices = ; > + clock-output-names = "ether"; > + }; > + ... please move this chunk to "[PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f67.google.com ([209.85.214.67]:34882 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756241AbcIAVDq (ORCPT ); Thu, 1 Sep 2016 17:03:46 -0400 MIME-Version: 1.0 In-Reply-To: <20160901155430.23400-2-chris.brandt@renesas.com> References: <20160901155430.23400-1-chris.brandt@renesas.com> <20160901155430.23400-2-chris.brandt@renesas.com> From: Geert Uytterhoeven Date: Thu, 1 Sep 2016 22:50:12 +0200 Message-ID: Subject: Re: [PATCH 2/3] ARM: dts: r7s72100: add ethernet to device tree To: Chris Brandt Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Linux-Renesas Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt wrote: > Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven But... > ---" > arch/arm/boot/dts/r7s72100.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index e8e2a5d7..fb9ef9c 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -108,6 +108,15 @@ > clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7"; > }; > > + mstp7_clks: mstp7_clks@fcfe0430 { > + #clock-cells = <1>; > + compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > + reg = <0xfcfe0430 4>; > + clocks = <&p0_clk>; > + clock-indices = ; > + clock-output-names = "ether"; > + }; > + ... please move this chunk to "[PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Thu, 1 Sep 2016 22:50:12 +0200 Subject: [PATCH 2/3] ARM: dts: r7s72100: add ethernet to device tree In-Reply-To: <20160901155430.23400-2-chris.brandt@renesas.com> References: <20160901155430.23400-1-chris.brandt@renesas.com> <20160901155430.23400-2-chris.brandt@renesas.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt wrote: > Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven But... > ---" > arch/arm/boot/dts/r7s72100.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index e8e2a5d7..fb9ef9c 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -108,6 +108,15 @@ > clock-output-names = "scif0", "scif1", "scif2", "scif3", "scif4", "scif5", "scif6", "scif7"; > }; > > + mstp7_clks: mstp7_clks at fcfe0430 { > + #clock-cells = <1>; > + compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > + reg = <0xfcfe0430 4>; > + clocks = <&p0_clk>; > + clock-indices = ; > + clock-output-names = "ether"; > + }; > + ... please move this chunk to "[PATCH 1/3] ARM: dts: r7s72100: add ethernet clock to device tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds