From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 04 Jan 2016 12:42:13 +0000 Subject: Re: [PATCH v2 1/6] arm64: renesas: r8a7795: add usb2_phy device nodes Message-Id: List-Id: References: <1451044361-5896-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1451044361-5896-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1451044361-5896-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Shimoda Cc: Simon Horman , Magnus Damm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-sh list Hi Shimoda-san, On Fri, Dec 25, 2015 at 12:52 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 34 ++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index bb353cd..89393ea 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -775,5 +775,39 @@ > clocks = <&cpg CPG_MOD 815>; > status = "disabled"; > }; > + > + usb2_phy0: usb-phy@ee080200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee080200 0 0x700>, <0 0xe6590100 0 0x100>; > + reg-names = "usb2_host", "hsusb"; > + interrupts = ; Isn't 108 the EHCI0 interrupt? Cfr. the other usb-phy nodes that don't have interrupts. > + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>; > + clock-names = "usb2", "hsusb"; > + power-domains = <&cpg>; This device has two modules clocks, but the CPG/MSSR driver only manages the first modulo clock. Who enables the second clock (HS-USB-IF)? > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + usb2_phy1: usb-phy@ee0a0200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee0a0200 0 0x700>; > + reg-names = "usb2_host"; > + clocks = <&cpg CPG_MOD 702>; > + clock-names = "usb2"; > + power-domains = <&cpg>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + usb2_phy2: usb-phy@ee0c0200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee0c0200 0 0x700>; > + reg-names = "usb2_host"; > + clocks = <&cpg CPG_MOD 701>; > + clock-names = "usb2"; > + power-domains = <&cpg>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 1/6] arm64: renesas: r8a7795: add usb2_phy device nodes Date: Mon, 4 Jan 2016 13:42:13 +0100 Message-ID: References: <1451044361-5896-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1451044361-5896-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1451044361-5896-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yoshihiro Shimoda Cc: Simon Horman , Magnus Damm , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-sh list List-Id: devicetree@vger.kernel.org Hi Shimoda-san, On Fri, Dec 25, 2015 at 12:52 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 34 ++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index bb353cd..89393ea 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -775,5 +775,39 @@ > clocks = <&cpg CPG_MOD 815>; > status = "disabled"; > }; > + > + usb2_phy0: usb-phy@ee080200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee080200 0 0x700>, <0 0xe6590100 0 0x100>; > + reg-names = "usb2_host", "hsusb"; > + interrupts = ; Isn't 108 the EHCI0 interrupt? Cfr. the other usb-phy nodes that don't have interrupts. > + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>; > + clock-names = "usb2", "hsusb"; > + power-domains = <&cpg>; This device has two modules clocks, but the CPG/MSSR driver only manages the first modulo clock. Who enables the second clock (HS-USB-IF)? > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + usb2_phy1: usb-phy@ee0a0200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee0a0200 0 0x700>; > + reg-names = "usb2_host"; > + clocks = <&cpg CPG_MOD 702>; > + clock-names = "usb2"; > + power-domains = <&cpg>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + usb2_phy2: usb-phy@ee0c0200 { > + compatible = "renesas,usb2-phy-r8a7795"; > + reg = <0 0xee0c0200 0 0x700>; > + reg-names = "usb2_host"; > + clocks = <&cpg CPG_MOD 701>; > + clock-names = "usb2"; > + power-domains = <&cpg>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html