From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes Date: Wed, 21 Nov 2018 09:39:15 +0100 Message-ID: References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> <94869436-7841-537a-4760-8f117b06200f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <94869436-7841-537a-4760-8f117b06200f@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marek Vasut Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Takeshi Kihara , Geert Uytterhoeven , Wolfram Sang , Yoshihiro Shimoda , Liam Girdwood , Linux-Renesas , Mark Brown , Simon Horman , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org T24gV2VkLCBOb3YgMjEsIDIwMTggYXQgMTI6MzMgQU0gTWFyZWsgVmFzdXQgPG1hcmVrLnZhc3V0 QGdtYWlsLmNvbT4gd3JvdGU6Cj4gT24gMTEvMjAvMjAxOCAxMToxNiBBTSwgR2VlcnQgVXl0dGVy aG9ldmVuIHdyb3RlOgo+ID4gT24gVHVlLCBOb3YgNiwgMjAxOCBhdCA5OjQ2IFBNIE1hcmVrIFZh c3V0IDxtYXJlay52YXN1dEBnbWFpbC5jb20+IHdyb3RlOgo+ID4+IEZyb206IFRha2VzaGkgS2lo YXJhIDx0YWtlc2hpLmtpaGFyYS5kZkByZW5lc2FzLmNvbT4KPiA+Pgo+ID4+IFRoaXMgcGF0Y2gg YWRkcyBTREhJezAsMSwzfSBkZXZpY2Ugbm9kZXMgZm9yIHRoZSByOGE3Nzk5MCBTb0MKPiA+PiBh bmQgZW5hYmxlcyBTRCBjYXJkIHNsb3QgY29ubmVjdGVkIHRvIFNESEkwLCBtaWNybyBTRCBjYXJk IHNsb3QKPiA+PiBjb25uZWN0ZWQgdG8gU0RISTEgYW5kIGVNTUMgY29ubmVjdGVkIHRvIFNESEkz IG9uIHRoZSBFYmlzdSBib2FyZAo+ID4+IHVzaW5nIHRoZSBSOEE3Nzk5MCBTb0MuCj4gPj4KPiA+ PiBTaWduZWQtb2ZmLWJ5OiBUYWtlc2hpIEtpaGFyYSA8dGFrZXNoaS5raWhhcmEuZGZAcmVuZXNh cy5jb20+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFyZWsgVmFzdXQgPG1hcmVrLnZhc3V0K3JlbmVz YXNAZ21haWwuY29tPgo+ID4KPiA+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMv cjhhNzc5OTAtZWJpc3UuZHRzCj4gPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2Fz L3I4YTc3OTkwLWViaXN1LmR0cwo+ID4+IEBAIC0xMjksNiArMTI5LDE1IEBACj4gPj4gICAgICAg ICAgICAgICAgIH07Cj4gPj4gICAgICAgICB9Owo+ID4+Cj4gPj4gKyAgICAgICByZWdfMXA4djog cmVndWxhdG9yMCB7Cj4gPj4gKyAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAicmVndWxhdG9y LWZpeGVkIjsKPiA+PiArICAgICAgICAgICAgICAgcmVndWxhdG9yLW5hbWUgPSAiZml4ZWQtMS44 ViI7Cj4gPj4gKyAgICAgICAgICAgICAgIHJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDE4MDAw MDA+Owo+ID4+ICsgICAgICAgICAgICAgICByZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwxODAw MDAwPjsKPiA+PiArICAgICAgICAgICAgICAgcmVndWxhdG9yLWJvb3Qtb247Cj4gPj4gKyAgICAg ICAgICAgICAgIHJlZ3VsYXRvci1hbHdheXMtb247Cj4gPj4gKyAgICAgICB9Owo+ID4+ICsKPiA+ PiAgICAgICAgIHJlZ18zcDN2OiByZWd1bGF0b3IxIHsKPiA+PiAgICAgICAgICAgICAgICAgY29t cGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwo+ID4+ICAgICAgICAgICAgICAgICByZWd1bGF0 b3ItbmFtZSA9ICJmaXhlZC0zLjNWIjsKPiA+PiBAQCAtMTgwLDYgKzE4OSw1NCBAQAo+ID4+ICAg ICAgICAgICAgICAgICAjY2xvY2stY2VsbHMgPSA8MD47Cj4gPj4gICAgICAgICAgICAgICAgIGNs b2NrLWZyZXF1ZW5jeSA9IDw3NDI1MDAwMD47Cj4gPj4gICAgICAgICB9Owo+ID4+ICsKPiA+PiAr ICAgICAgIHZjY19zZGhpMDogcmVndWxhdG9yLXZjYy1zZGhpMCB7Cj4gPj4gKyAgICAgICAgICAg ICAgIGNvbXBhdGlibGUgPSAicmVndWxhdG9yLWZpeGVkIjsKPiA+PiArCj4gPj4gKyAgICAgICAg ICAgICAgIHJlZ3VsYXRvci1uYW1lID0gIlNESEkwIFZjYyI7Cj4gPj4gKyAgICAgICAgICAgICAg IHJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ID4+ICsgICAgICAgICAgICAg ICByZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwzMzAwMDAwPjsKPiA+PiArCj4gPj4gKyAgICAg ICAgICAgICAgIGdwaW8gPSA8JmdwaW81IDE3IEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4+ICsgICAg ICAgICAgICAgICBlbmFibGUtYWN0aXZlLWhpZ2g7Cj4gPj4gKyAgICAgICB9Owo+ID4+ICsKPiA+ PiArICAgICAgIHZjY3Ffc2RoaTA6IHJlZ3VsYXRvci12Y2NxLXNkaGkwIHsKPiA+PiArICAgICAg ICAgICAgICAgY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZ3BpbyI7Cj4gPj4gKwo+ID4+ICsgICAg ICAgICAgICAgICByZWd1bGF0b3ItbmFtZSA9ICJTREhJMCBWY2NRIjsKPiA+PiArICAgICAgICAg ICAgICAgcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8MTgwMDAwMD47Cj4gPj4gKyAgICAgICAg ICAgICAgIHJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ID4+ICsKPiA+PiAr ICAgICAgICAgICAgICAgZ3Bpb3MgPSA8JmdwaW81IDE4IEdQSU9fQUNUSVZFX0hJR0g+Owo+ID4+ ICsgICAgICAgICAgICAgICBncGlvcy1zdGF0ZXMgPSA8MT47Cj4gPj4gKyAgICAgICAgICAgICAg IHN0YXRlcyA9IDwzMzAwMDAwIDEKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgIDE4MDAw MDAgMD47Cj4gPgo+ID4gSSBrbm93IHRoaXMgaXMgaG93IGl0J3MgZG9uZSBpbiB0aGUgZXhhbXBs ZSBpbgo+ID4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3JlZ3VsYXRvci9ncGlv LXJlZ3VsYXRvci50eHQsCj4gPiBidXQgdXN1YWxseSBicmFja2V0cyBhcmUgdXNlZCB0byBncm91 cCB0dXBsZXMsIGxpa2U6Cj4gPgo+ID4gICAgIHN0YXRlcyA9IDwzMzAwMDAwIDE+LCA8MTgwMDAw MCAwPjsKPiA+Cj4gPiBQZXJoYXBzIHRoZSBleGFtcGxlIHNob3VsZCBiZSBjaGFuZ2VkPwo+Cj4g V2VsbCwgbG9va2luZyB0aHJvdWdoIHRoZSBEVFMsIEkgZG9uJ3Qgc2VlIGFueW9uZSB1c2luZyB0 dXBsZXMgZm9yIHRoZQo+IEdQSU8gcmVndWxhdG9yIHN0YXRlcy4gVGhlbiBhZ2FpbiwgaXQgY291 bGQgYmUgdXBkYXRlZC4KClByb2JhYmx5IGEgZ29vZCBpZGVhIGdpdmVuIHRoZSBjdXJyZW50IHdv cmsgb24gc2NoZW1hIHZhbGlkYXRpb246CgogICAgRFQgWUFNTCBFbmNvZGluZwogICAgLi4uCiAg ICBkdHMg4oCYPCA+4oCZIGFyZSBtYWludGFpbmVkCiAgICAgIOKXiyBXaWxsIG5lZWQgdG8gYmUg c3RyaWN0ZXIgYWJvdXQgdGhlc2UKICAgICAg4peLIFNhbWUgZm9yIGR0Yiwgbm90IGZvciB2YWxp ZGF0aW9uOgogICAgICAgICAg4pagIHByb3AgPSA8MSAyIDMgND47CiAgICAgICAgICDilqAgcHJv cCA9IDwxPiwgPDI+LCA8Mz4sIDw0PjsKCmh0dHBzOi8vd3d3LmVsaW51eC5vcmcvaW1hZ2VzLzYv NmIvTFBDMjAxOF9qc29uLXNjaGVtYV9mb3JfRGV2aWNldHJlZS5wZGYKCkdye29ldGplLGVldGlu Z31zLAoKICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQKCi0tIApHZWVydCBVeXR0ZXJob2V2 ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4IGJleW9uZCBpYTMyIC0tIGdlZXJ0QGxpbnV4LW02 OGsub3JnCgpJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwg SSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0CndoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlz dHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4KICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f66.google.com ([209.85.222.66]:36187 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728078AbeKUTND (ORCPT ); Wed, 21 Nov 2018 14:13:03 -0500 MIME-Version: 1.0 References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> <94869436-7841-537a-4760-8f117b06200f@gmail.com> In-Reply-To: <94869436-7841-537a-4760-8f117b06200f@gmail.com> From: Geert Uytterhoeven Date: Wed, 21 Nov 2018 09:39:15 +0100 Message-ID: Subject: Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes To: Marek Vasut Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Takeshi Kihara , Marek Vasut , Geert Uytterhoeven , Simon Horman , Wolfram Sang , Yoshihiro Shimoda , Linux-Renesas , Linux ARM , Mark Brown , Liam Girdwood Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Nov 21, 2018 at 12:33 AM Marek Vasut wrote: > On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: > >> From: Takeshi Kihara > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC > >> and enables SD card slot connected to SDHI0, micro SD card slot > >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board > >> using the R8A77990 SoC. > >> > >> Signed-off-by: Takeshi Kihara > >> Signed-off-by: Marek Vasut > > > >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> @@ -129,6 +129,15 @@ > >> }; > >> }; > >> > >> + reg_1p8v: regulator0 { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "fixed-1.8V"; > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> reg_3p3v: regulator1 { > >> compatible = "regulator-fixed"; > >> regulator-name = "fixed-3.3V"; > >> @@ -180,6 +189,54 @@ > >> #clock-cells = <0>; > >> clock-frequency = <74250000>; > >> }; > >> + > >> + vcc_sdhi0: regulator-vcc-sdhi0 { > >> + compatible = "regulator-fixed"; > >> + > >> + regulator-name = "SDHI0 Vcc"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + > >> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + }; > >> + > >> + vccq_sdhi0: regulator-vccq-sdhi0 { > >> + compatible = "regulator-gpio"; > >> + > >> + regulator-name = "SDHI0 VccQ"; > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <3300000>; > >> + > >> + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; > >> + gpios-states = <1>; > >> + states = <3300000 1 > >> + 1800000 0>; > > > > I know this is how it's done in the example in > > Documentation/devicetree/bindings/regulator/gpio-regulator.txt, > > but usually brackets are used to group tuples, like: > > > > states = <3300000 1>, <1800000 0>; > > > > Perhaps the example should be changed? > > Well, looking through the DTS, I don't see anyone using tuples for the > GPIO regulator states. Then again, it could be updated. Probably a good idea given the current work on schema validation: DT YAML Encoding ... dts ‘< >’ are maintained ○ Will need to be stricter about these ○ Same for dtb, not for validation: ■ prop = <1 2 3 4>; ■ prop = <1>, <2>, <3>, <4>; https://www.elinux.org/images/6/6b/LPC2018_json-schema_for_Devicetree.pdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Wed, 21 Nov 2018 09:39:15 +0100 Subject: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes In-Reply-To: <94869436-7841-537a-4760-8f117b06200f@gmail.com> References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> <94869436-7841-537a-4760-8f117b06200f@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 21, 2018 at 12:33 AM Marek Vasut wrote: > On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: > >> From: Takeshi Kihara > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC > >> and enables SD card slot connected to SDHI0, micro SD card slot > >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board > >> using the R8A77990 SoC. > >> > >> Signed-off-by: Takeshi Kihara > >> Signed-off-by: Marek Vasut > > > >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> @@ -129,6 +129,15 @@ > >> }; > >> }; > >> > >> + reg_1p8v: regulator0 { > >> + compatible = "regulator-fixed"; > >> + regulator-name = "fixed-1.8V"; > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> + > >> reg_3p3v: regulator1 { > >> compatible = "regulator-fixed"; > >> regulator-name = "fixed-3.3V"; > >> @@ -180,6 +189,54 @@ > >> #clock-cells = <0>; > >> clock-frequency = <74250000>; > >> }; > >> + > >> + vcc_sdhi0: regulator-vcc-sdhi0 { > >> + compatible = "regulator-fixed"; > >> + > >> + regulator-name = "SDHI0 Vcc"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + > >> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + }; > >> + > >> + vccq_sdhi0: regulator-vccq-sdhi0 { > >> + compatible = "regulator-gpio"; > >> + > >> + regulator-name = "SDHI0 VccQ"; > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <3300000>; > >> + > >> + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; > >> + gpios-states = <1>; > >> + states = <3300000 1 > >> + 1800000 0>; > > > > I know this is how it's done in the example in > > Documentation/devicetree/bindings/regulator/gpio-regulator.txt, > > but usually brackets are used to group tuples, like: > > > > states = <3300000 1>, <1800000 0>; > > > > Perhaps the example should be changed? > > Well, looking through the DTS, I don't see anyone using tuples for the > GPIO regulator states. Then again, it could be updated. Probably a good idea given the current work on schema validation: DT YAML Encoding ... dts ?< >? are maintained ? Will need to be stricter about these ? Same for dtb, not for validation: ? prop = <1 2 3 4>; ? prop = <1>, <2>, <3>, <4>; https://www.elinux.org/images/6/6b/LPC2018_json-schema_for_Devicetree.pdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds