From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 20 Jan 2014 11:43:40 +0000 Subject: Re: [PATCH v5] can: add Renesas R-Car CAN driver Message-Id: List-Id: References: <201312270037.15822.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201312270037.15822.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: "netdev@vger.kernel.org" , wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org, Linux-sh list , vksavl@gmail.com Hi Sergei, On Thu, Dec 26, 2013 at 10:37 PM, Sergei Shtylyov wrote: > Changes in version 3: > - added '__packed' to 'struct rcar_can_mbox_regs' and 'struct rcar_can_regs'; > - removed unneeded type cast in the probe() method. > +/* Mailbox registers structure */ > +struct rcar_can_mbox_regs { > + u32 id; /* IDE and RTR bits, SID and EID */ > + u8 stub; /* Not used */ > + u8 dlc; /* Data Length Code - bits [0..3] */ > + u8 data[8]; /* Data Bytes */ > + u8 tsh; /* Time Stamp Higher Byte */ > + u8 tsl; /* Time Stamp Lower Byte */ > +} __packed; Sorry, I missed the earlier discussion, but why the _packed? One u32 and 12 bytes makes a nice multiple of 4. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v5] can: add Renesas R-Car CAN driver Date: Mon, 20 Jan 2014 12:43:40 +0100 Message-ID: References: <201312270037.15822.sergei.shtylyov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <201312270037.15822.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: "netdev@vger.kernel.org" , wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org, Linux-sh list , vksavl@gmail.com List-Id: linux-can.vger.kernel.org Hi Sergei, On Thu, Dec 26, 2013 at 10:37 PM, Sergei Shtylyov wrote: > Changes in version 3: > - added '__packed' to 'struct rcar_can_mbox_regs' and 'struct rcar_can_regs'; > - removed unneeded type cast in the probe() method. > +/* Mailbox registers structure */ > +struct rcar_can_mbox_regs { > + u32 id; /* IDE and RTR bits, SID and EID */ > + u8 stub; /* Not used */ > + u8 dlc; /* Data Length Code - bits [0..3] */ > + u8 data[8]; /* Data Bytes */ > + u8 tsh; /* Time Stamp Higher Byte */ > + u8 tsl; /* Time Stamp Lower Byte */ > +} __packed; Sorry, I missed the earlier discussion, but why the _packed? One u32 and 12 bytes makes a nice multiple of 4. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds