From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Tue, 09 Sep 2014 09:48:23 +0000 Subject: Re: [PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype pm domain support Message-Id: List-Id: References: <1409320217-13278-1-git-send-email-geert+renesas@glider.be> <20140909022649.GC31320@verge.net.au> In-Reply-To: <20140909022649.GC31320@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Simon, Magnus, On Tue, Sep 9, 2014 at 4:26 AM, Simon Horman wrote: > I would like Magnus's opinion but mine is that the non-WIP patches > could be queued up. At least patch 1 and 2. Possibly others if > they don't depend (other than diff noise) on WIP patches. The legacy platforms are meant to be extinct in the near future, but Armadillo-legacy already has some PM domain support, so adding a little bit more can't hurt much, IMHO. Besides diff noise, there should not be any dependencies on WIP patches. > With the WIP patches, I am not entirely opposed to merging them > too, so long as they move things in a good direction. And in particular > don't break anything. "[PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices" should be OK, as this turned out to be intended behavior. "[PATCH 10/11] [WIP] ARM: shmobile: r8a7740: Add A4SU pm domain support" probably introduces a regression for USB, as the domain is now powered down after boot-up. I haven't tried USB on Armadillo yet, though. So don't apply this one. "[PATCH 11/11] [WIP] ARM: shmobile: r8a7740: Add A3SM pm domain support" should be safe. I would not apply the other WIP patches that add C99-commented-out code. These issues must be fixed for DT as well. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype pm domain support Date: Tue, 9 Sep 2014 11:48:23 +0200 Message-ID: References: <1409320217-13278-1-git-send-email-geert+renesas@glider.be> <20140909022649.GC31320@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140909022649.GC31320@verge.net.au> Sender: linux-sh-owner@vger.kernel.org To: Simon Horman Cc: Geert Uytterhoeven , Magnus Damm , "Rafael J. Wysocki" , Linux-sh list , Linux PM list , "linux-arm-kernel@lists.infradead.org" List-Id: linux-pm@vger.kernel.org Hi Simon, Magnus, On Tue, Sep 9, 2014 at 4:26 AM, Simon Horman wrote: > I would like Magnus's opinion but mine is that the non-WIP patches > could be queued up. At least patch 1 and 2. Possibly others if > they don't depend (other than diff noise) on WIP patches. The legacy platforms are meant to be extinct in the near future, but Armadillo-legacy already has some PM domain support, so adding a little bit more can't hurt much, IMHO. Besides diff noise, there should not be any dependencies on WIP patches. > With the WIP patches, I am not entirely opposed to merging them > too, so long as they move things in a good direction. And in particular > don't break anything. "[PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices" should be OK, as this turned out to be intended behavior. "[PATCH 10/11] [WIP] ARM: shmobile: r8a7740: Add A4SU pm domain support" probably introduces a regression for USB, as the domain is now powered down after boot-up. I haven't tried USB on Armadillo yet, though. So don't apply this one. "[PATCH 11/11] [WIP] ARM: shmobile: r8a7740: Add A3SM pm domain support" should be safe. I would not apply the other WIP patches that add C99-commented-out code. These issues must be fixed for DT as well. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Tue, 9 Sep 2014 11:48:23 +0200 Subject: [PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype pm domain support In-Reply-To: <20140909022649.GC31320@verge.net.au> References: <1409320217-13278-1-git-send-email-geert+renesas@glider.be> <20140909022649.GC31320@verge.net.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Simon, Magnus, On Tue, Sep 9, 2014 at 4:26 AM, Simon Horman wrote: > I would like Magnus's opinion but mine is that the non-WIP patches > could be queued up. At least patch 1 and 2. Possibly others if > they don't depend (other than diff noise) on WIP patches. The legacy platforms are meant to be extinct in the near future, but Armadillo-legacy already has some PM domain support, so adding a little bit more can't hurt much, IMHO. Besides diff noise, there should not be any dependencies on WIP patches. > With the WIP patches, I am not entirely opposed to merging them > too, so long as they move things in a good direction. And in particular > don't break anything. "[PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices" should be OK, as this turned out to be intended behavior. "[PATCH 10/11] [WIP] ARM: shmobile: r8a7740: Add A4SU pm domain support" probably introduces a regression for USB, as the domain is now powered down after boot-up. I haven't tried USB on Armadillo yet, though. So don't apply this one. "[PATCH 11/11] [WIP] ARM: shmobile: r8a7740: Add A3SM pm domain support" should be safe. I would not apply the other WIP patches that add C99-commented-out code. These issues must be fixed for DT as well. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds