From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA9CC2D0A7 for ; Thu, 10 Sep 2020 09:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E092C20C09 for ; Thu, 10 Sep 2020 09:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730657AbgIJJeF (ORCPT ); Thu, 10 Sep 2020 05:34:05 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:40810 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730791AbgIJJdt (ORCPT ); Thu, 10 Sep 2020 05:33:49 -0400 Received: by mail-ot1-f68.google.com with SMTP id e23so4791290otk.7; Thu, 10 Sep 2020 02:33:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/C47IB+M4nbaJ9760h1nUtZkhySt02neFnlZ98xNcsk=; b=X6CvrbmrMXIQZ9XAdwJxI3iIAEp9o/w/jhssu47T7nVwji7LN21JlQaF67YJgQyDaB eXF2DYp5RHqshNjSW8hD64pl4nb6EdL1/2m+a47uMN5djGqS4o/Es+VsUtNQg/jiZ7pG 7VNnxchVA5RupQpTsLZHZn4BH7QL1aoD/x++dx1IEgm90xwBbMgN7umcy2Yk2qz4luTq Sp8bph9ur0IW/C+3j++y1JlyYAvbDqE8XZPKe7HwBd/K3H/LjtUybZvd29dFr97hCjf0 Xde5cldfpw8c7vBvJX7RXHzcB87FMZzoixTJ00TWI/B81Dpfrl9EcDILcc4Kp0qcyG48 eHJQ== X-Gm-Message-State: AOAM533Wp3icg8dDtRrN5/VZbJoF+KFDbYfStdbIIr3EqovGB9M4o+ST uaOyim5s3wGMPmN6jfcx4wTfrghMBb0oTpz+Fn0= X-Google-Smtp-Source: ABdhPJyKtepHyQ3hj+VpqxVbmkIPUxk+KZPk5olzAOt0nNaXE+lJagqO0th4OOsmJLg0LdaTe+wwlek1fosVWcd6QfQ= X-Received: by 2002:a9d:3b76:: with SMTP id z109mr3428638otb.250.1599730428650; Thu, 10 Sep 2020 02:33:48 -0700 (PDT) MIME-Version: 1.0 References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> In-Reply-To: <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> From: Geert Uytterhoeven Date: Thu, 10 Sep 2020 11:33:37 +0200 Message-ID: Subject: Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes To: Kuninori Morimoto Cc: Rob Herring , Laurent , David Airlie , Daniel Vetter , Magnus , Linux-Renesas , Linux-DT , Kieran Bingham , shimoda , DRI Development Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2004,6 +2004,58 @@ pciec1: pcie@ee800000 { > status = "disabled"; > }; > > + fcpf0: fcp@fe950000 { > + compatible = "renesas,fcpf"; > + reg = <0 0xfe950000 0 0x200>; > + clocks = <&cpg CPG_MOD 615>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 615>; Missing "iommus = <&ipmmu_vc0 16>;" > + }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 607>; Missing "iommus = <&ipmmu_vi0 5>;" > + }; The rest looks good to me, so with the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA0AC433E2 for ; Thu, 10 Sep 2020 09:33:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51DF6207EA for ; Thu, 10 Sep 2020 09:33:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51DF6207EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94FBA6E8CE; Thu, 10 Sep 2020 09:33:50 +0000 (UTC) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72F4E6E8CE for ; Thu, 10 Sep 2020 09:33:49 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id y5so4801064otg.5 for ; Thu, 10 Sep 2020 02:33:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/C47IB+M4nbaJ9760h1nUtZkhySt02neFnlZ98xNcsk=; b=hdTucgkUlP/DDkSEXSuNmB00xCCTBas7HOTMto+DBr61AVUzWWjm4rKUQ6CkpEllhd Yn4jMKeo4SKVvjZOPEJwqxYx52zlcaqObW4TBRknK+sJkd0u4wd315qD67U9Tnc7Bv87 HDHXALxw+OB10XP4/On/rgLoiEoSPjTUSCkWWsp1qSwe8yUuDXnAbFVlG4j3Xd+lo7im XUkKaEVv6pkW9xbk2xxCM/1wbZGP04A2lwMi8Id1fQPAp7trDmlGuBnTm6aZMzBBK46O pfQsBi/h1s0Ir6UAsNoqHezuN1pS1I3ebYDhdBpkSSjWPb0PzCkenbpn6UuiLv28t/80 yLqA== X-Gm-Message-State: AOAM531gWYehz09CNT4UTIG56RjbaQTtv6tqRr2FbXHm8EFdfldEmoxH X/F3ysJTyxE8kjixeAI9Wqorzgt7m3DZ8QRmi1XY4t/0grU= X-Google-Smtp-Source: ABdhPJyKtepHyQ3hj+VpqxVbmkIPUxk+KZPk5olzAOt0nNaXE+lJagqO0th4OOsmJLg0LdaTe+wwlek1fosVWcd6QfQ= X-Received: by 2002:a9d:3b76:: with SMTP id z109mr3428638otb.250.1599730428650; Thu, 10 Sep 2020 02:33:48 -0700 (PDT) MIME-Version: 1.0 References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> In-Reply-To: <87h7s9rtvl.wl-kuninori.morimoto.gx@renesas.com> From: Geert Uytterhoeven Date: Thu, 10 Sep 2020 11:33:37 +0200 Message-ID: Subject: Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes To: Kuninori Morimoto X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-DT , David Airlie , shimoda , Kieran Bingham , Magnus , DRI Development , Linux-Renesas , Rob Herring , Laurent Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2004,6 +2004,58 @@ pciec1: pcie@ee800000 { > status = "disabled"; > }; > > + fcpf0: fcp@fe950000 { > + compatible = "renesas,fcpf"; > + reg = <0 0xfe950000 0 0x200>; > + clocks = <&cpg CPG_MOD 615>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 615>; Missing "iommus = <&ipmmu_vc0 16>;" > + }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 607>; Missing "iommus = <&ipmmu_vi0 5>;" > + }; The rest looks good to me, so with the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel