From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C62C83003 for ; Fri, 9 Jun 2023 12:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240725AbjFIMsd convert rfc822-to-8bit (ORCPT ); Fri, 9 Jun 2023 08:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240719AbjFIMsO (ORCPT ); Fri, 9 Jun 2023 08:48:14 -0400 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A2E22136; Fri, 9 Jun 2023 05:48:14 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-bacbc7a2998so1668039276.3; Fri, 09 Jun 2023 05:48:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686314893; x=1688906893; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oUnX0UM+Igwa0fUtgyLnX5bA3wv9FfoFnuZ0mnmyxD8=; b=QNfBp9nfbz0AfKG00qc1JiVBqf8gMHVWNRy0eaSgvW3FiSjCm7J2ET7tgcwDP+NOXz v3ZPc0HMUzAVTumUMPfROmQBlCdKSYCUur6/NeRoBdhGbiDmNChwc2enJoXrwt8Bdz0K fIqrWitTmWdNe0gpkhpzu6tmemVvwIbg0nVtAsz+oulZgAO8dNeiledSXDBSw/HBcvdw +lOxjSnxbwrsxl9eX7YBW564T5bnrAgWpDb/0mEghoe01DxyUqoQ+TArYQ5czNAJJVqJ c5wEL8os1hRXOVTJUoW/TmiUtcVpwGuSKT6av9urD9UQ8lMD/DMAE20apVvmjDFCNCOH 1ICQ== X-Gm-Message-State: AC+VfDz+3pwdC/wYEgUXXMNiRFV9o4uSgJuHudZeesogVcMmyCQ8q0fE o1m2N5zd8ixE8HwDCg1EJFSGkavCBonYcg== X-Google-Smtp-Source: ACHHUZ7iOVF1xsri3laKFtxHiXxBTzdHcJz92n4d/K3jiRMka4jRQy8Ck96PBiGAEaEHSisSKXkFNQ== X-Received: by 2002:a25:8207:0:b0:bab:f4bb:9402 with SMTP id q7-20020a258207000000b00babf4bb9402mr997724ybk.46.1686314893217; Fri, 09 Jun 2023 05:48:13 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id ch22-20020a0569020b1600b00bac1087b44esm847720ybb.35.2023.06.09.05.48.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 05:48:11 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-565ee3d14c2so15657597b3.2; Fri, 09 Jun 2023 05:48:10 -0700 (PDT) X-Received: by 2002:a81:8841:0:b0:569:1ff9:58d3 with SMTP id y62-20020a818841000000b005691ff958d3mr1254652ywf.1.1686314890673; Fri, 09 Jun 2023 05:48:10 -0700 (PDT) MIME-Version: 1.0 References: <14e091fc522aa63a3e33bda1016e5fa946d47d18.1685696114.git.geert+renesas@glider.be> <20230602110459.GC26944@pendragon.ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 9 Jun 2023 14:47:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] drm: Remove references to removed transitional helpers To: Laurent Pinchart Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Jyri Sarha , Tomi Valkeinen , Biju Das , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 2, 2023 at 1:17 PM Geert Uytterhoeven wrote: > On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart > wrote: > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > The transitional helpers were removed a long time ago, but some > > > references stuck. Remove them. > > > > > > Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") > > > Signed-off-by: Geert Uytterhoeven > > > > --- a/drivers/gpu/drm/drm_plane_helper.c > > > +++ b/drivers/gpu/drm/drm_plane_helper.c > > > @@ -51,14 +51,6 @@ > > > * planes, and newly merged drivers must not rely upon these transitional > > > * helpers. > > > * > > > > The first paragraph starts with "This helper library has two parts.". As > > you're dropping the mention of the second part, I think you should > > rework the first paragraph too. > > That was my initial thought, too. > However, the code still has a second part, not related to the topic of > the first part (primary plane support). Upon deeper investigation, all of this is related to primary plane support. Will update... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D56FC7EE2E for ; Fri, 9 Jun 2023 12:48:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE47110E693; Fri, 9 Jun 2023 12:48:17 +0000 (UTC) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7151910E693 for ; Fri, 9 Jun 2023 12:48:15 +0000 (UTC) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-565f1145dc8so15622177b3.1 for ; Fri, 09 Jun 2023 05:48:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686314893; x=1688906893; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oUnX0UM+Igwa0fUtgyLnX5bA3wv9FfoFnuZ0mnmyxD8=; b=RBDveGhT5MAuSV4czWPpOTOrVMumVYqapV63DdjV/2vxRe9sSm7AyXkzzR0kGF/wns BuevM/igAOiNjrBH7pbqlVXOLNFhOaiQ+hg02JTOPsinowU8WnT0+obEZa2VHx3i8NXS hVJ9IQSumHXCXfIbWYQUwyNt0htHzd9h/FVj2kqYxZ/rLbNe2mI3Gn/g2P0j2nVvReq5 RIQYn9jyE6H7+Ey8Q6w+heW6hHZz4Cis9i9KJ4nN8nIOD2JFF2qTixxX4E3bxXXraAFM +Ny54mMJc4OrSwSxxziCaT/LCY+aSwvAbcGRZzrUK7UFRIBYl2zdk/KAM5xO0IKK73JI Tz1Q== X-Gm-Message-State: AC+VfDxTgOwK0do9edtYGCKU76StfjmX+P99D8qWGPQW/2oG7ETF9jjy cnl/BpAvE/XJ19aSZZdon6zqSMukuCt+Tw== X-Google-Smtp-Source: ACHHUZ5xWlXtRMyxU0V2GL5Z4C/3y3LkdLjMpt7mWMmL54ZZmTy6SpryruQKp5dx1TzVcNfMCtnq9g== X-Received: by 2002:a0d:dd10:0:b0:564:a549:babc with SMTP id g16-20020a0ddd10000000b00564a549babcmr1080166ywe.32.1686314893481; Fri, 09 Jun 2023 05:48:13 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id t202-20020a8183d3000000b005619cfb1b88sm586928ywf.52.2023.06.09.05.48.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 05:48:11 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-565eaf83853so15678497b3.3 for ; Fri, 09 Jun 2023 05:48:10 -0700 (PDT) X-Received: by 2002:a81:8841:0:b0:569:1ff9:58d3 with SMTP id y62-20020a818841000000b005691ff958d3mr1254652ywf.1.1686314890673; Fri, 09 Jun 2023 05:48:10 -0700 (PDT) MIME-Version: 1.0 References: <14e091fc522aa63a3e33bda1016e5fa946d47d18.1685696114.git.geert+renesas@glider.be> <20230602110459.GC26944@pendragon.ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 9 Jun 2023 14:47:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] drm: Remove references to removed transitional helpers To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Tomi Valkeinen , Jonathan Corbet , Jyri Sarha , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Biju Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 2, 2023 at 1:17=E2=80=AFPM Geert Uytterhoeven wrote: > On Fri, Jun 2, 2023 at 1:05=E2=80=AFPM Laurent Pinchart > wrote: > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > The transitional helpers were removed a long time ago, but some > > > references stuck. Remove them. > > > > > > Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") > > > Signed-off-by: Geert Uytterhoeven > > > > --- a/drivers/gpu/drm/drm_plane_helper.c > > > +++ b/drivers/gpu/drm/drm_plane_helper.c > > > @@ -51,14 +51,6 @@ > > > * planes, and newly merged drivers must not rely upon these transit= ional > > > * helpers. > > > * > > > > The first paragraph starts with "This helper library has two parts.". A= s > > you're dropping the mention of the second part, I think you should > > rework the first paragraph too. > > That was my initial thought, too. > However, the code still has a second part, not related to the topic of > the first part (primary plane support). Upon deeper investigation, all of this is related to primary plane support. Will update... Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds