From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FE5C433F5 for ; Tue, 21 Sep 2021 07:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A9CF611C5 for ; Tue, 21 Sep 2021 07:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbhIUHwi (ORCPT ); Tue, 21 Sep 2021 03:52:38 -0400 Received: from mail-vs1-f52.google.com ([209.85.217.52]:38417 "EHLO mail-vs1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhIUHwh (ORCPT ); Tue, 21 Sep 2021 03:52:37 -0400 Received: by mail-vs1-f52.google.com with SMTP id y141so7858387vsy.5; Tue, 21 Sep 2021 00:51:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/N4irXZXXoqT9WU1NeZNtea91/GmlWjvw07gZnEdTY=; b=VZsnPjqOc1S6CsBhivezYB6nPC7RbRUfNYPuOeMhub8Lov3xz7ft/TQkbhPQvOGlUQ b+tB6H8H64GIEDPV7PKsskMZHfBU2NbVIb001bUwf0gM3aKlImQFLoB/sIDQ8Uc6js8X 1R6T6U3P7VwjDE6qUryDvf6sh5FiJ74674WM5aWycnFa+KVmtokZuQKlOqMc8DH6A1bI JtJQiL/4p0Z6sG4CHF/8akqbFR8PUShqgBs1gd2IEDsRmQCJh9s8P5NEraI/sXqf4HRC 0Pe4bziE4NJKOsNiMONL5KJdBqneMjHjg9YP2L4xwTSIf0s5svH3ZZEG5WbClGMm/W8j 5SXg== X-Gm-Message-State: AOAM533cOxsO17fXr8JulND28XLFNHCTfZoXTvrfZ6g+/E8odW7zWozx 6jkqlNTRW1BLfyuZvqmqGbcriZiw6A5RUFsdU2s= X-Google-Smtp-Source: ABdhPJzYZGsZ4dZcqwbCdynpvilMS743u09VJ9Cuu54KRX/0QCI+aNebqqkhz49kmbioxdtwj7MTDXk6FsjhvAqZnFE= X-Received: by 2002:a67:2c58:: with SMTP id s85mr2438234vss.35.1632210668743; Tue, 21 Sep 2021 00:51:08 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-2-willmcvicker@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 21 Sep 2021 09:50:57 +0200 Message-ID: Subject: Re: [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic To: Krzysztof Kozlowski Cc: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Lee Jones , Android Kernel Team , Linux ARM , Linux Kernel Mailing List , linux-samsung-soc , linux-clk Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 9:31 AM Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: > > COMMON_CLK_SAMSUNG is selected by ARCH_EXYNOS which forces this config > > to be built-in when ARCH_EXYNOS is enabled. Switch the logic to use a > > "default y if ARCH_EXYNOS" to provide flexibilty for vendors to disable > > or modularize this driver. > > The clock drivers are essential, you cannot disable them for a generic > kernel supporting ARCH_EXYNOS. Such kernel won't work properly on platforms. Obviously it's not gonna work if the clock driver is not enabled at all. But does it work if you make the clock driver modular, and put it with all other essential driver modules in initramfs? Debugging would be hard, as the serial console driver also relies on clocks and PM Domains etc. If not, this patch should be NAKed, until it works with a modular clock driver. If yes, perhaps another line should be added (_before_ the other line)? + default m if ARCH_EXYNOS && MODULES default y if ARCH_EXYNOS However, many developers may want MODULES=y, but not want to bother with an initramfs. So perhaps we need a new symbol MINIMUM_GENERIC_KERNEL or so, protected by EXPERT, and make the driver default to m if that is enabled? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDA5C433EF for ; Tue, 21 Sep 2021 07:53:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3E3160F70 for ; Tue, 21 Sep 2021 07:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E3E3160F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/NpED6EWIrQ1qwQ6C/FFAigxVZb3CZvFEXeKcio1nI=; b=X9MvVXeDDqJecy 1iFCBK1V0jzZnGlKc6l/YoFalQwmou2kWsU6zrjKUDi1OGhzM0+QVvfMfDNfQylZkmRTYKj2CvsZx SkF3kCR1ojJqI7aT08JGmhYAcDOqVZnBLHm4bPisja1fg4be6xYlsxxmvw9XqaWqEJEuDay4TJ574 S7MN9c4p4HxTc9WsK1TvYO7JEoX/oMt/zAVw/757mLx/0c26bpRMJ5LCxVsok2/+d7RZ+bzX/gZwz n6Lx4PWw9gxB9TJMEzU8bAtHUfq70r1jZQsqyg52aqvCSbjxOcCZ5E7DnN0wjjr+nbpDwShKyd7N6 0ypRdWfNvupvVc5w4XlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSaYd-003rmn-Mr; Tue, 21 Sep 2021 07:51:15 +0000 Received: from mail-vs1-f51.google.com ([209.85.217.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSaYZ-003rlp-7k for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 07:51:12 +0000 Received: by mail-vs1-f51.google.com with SMTP id o124so19307684vsc.6 for ; Tue, 21 Sep 2021 00:51:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/N4irXZXXoqT9WU1NeZNtea91/GmlWjvw07gZnEdTY=; b=p2SGbQGdvNCIy49DwogYiqgjjwPHl9cFdokchqnTBSsWOr6T/CukKYPgimnc8eqQwI aGAAatp1OZqJMaBAw9ipFSfyRmj820nTxcDnXb6F8Z5+fixD+mCKKM7ONBUtgH//h7bA dRM5BZyWlfhfXJo3dI5HBjVdMm5PI0VIuAfIkqSN9NCIKCQqyMg6B7JjGX+04ahjJVpq 7I+2QvB7rd0jxiY9kaO8tpzpUEHYI1ZxB8JUpLoTJcTLp+d1dGwydaomCvRxkId2w/2v RdzHkTwC6mGqrCZCum1XTNqT/wPl8TW2zo/c1xrxtBjG58zXZgc54OOuV1EQY+NHNpof czGA== X-Gm-Message-State: AOAM532uRMY+09Geh6/XzQIWC+bSX5JCNipatu9qme6gxriwPHGUnkaC Md/edfdEA8SFOiy8icevot5p1IVfehOVzUrulDU= X-Google-Smtp-Source: ABdhPJzYZGsZ4dZcqwbCdynpvilMS743u09VJ9Cuu54KRX/0QCI+aNebqqkhz49kmbioxdtwj7MTDXk6FsjhvAqZnFE= X-Received: by 2002:a67:2c58:: with SMTP id s85mr2438234vss.35.1632210668743; Tue, 21 Sep 2021 00:51:08 -0700 (PDT) MIME-Version: 1.0 References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-2-willmcvicker@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 21 Sep 2021 09:50:57 +0200 Message-ID: Subject: Re: [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic To: Krzysztof Kozlowski Cc: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Lee Jones , Android Kernel Team , Linux ARM , Linux Kernel Mailing List , linux-samsung-soc , linux-clk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_005111_322501_648691C8 X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 9:31 AM Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: > > COMMON_CLK_SAMSUNG is selected by ARCH_EXYNOS which forces this config > > to be built-in when ARCH_EXYNOS is enabled. Switch the logic to use a > > "default y if ARCH_EXYNOS" to provide flexibilty for vendors to disable > > or modularize this driver. > > The clock drivers are essential, you cannot disable them for a generic > kernel supporting ARCH_EXYNOS. Such kernel won't work properly on platforms. Obviously it's not gonna work if the clock driver is not enabled at all. But does it work if you make the clock driver modular, and put it with all other essential driver modules in initramfs? Debugging would be hard, as the serial console driver also relies on clocks and PM Domains etc. If not, this patch should be NAKed, until it works with a modular clock driver. If yes, perhaps another line should be added (_before_ the other line)? + default m if ARCH_EXYNOS && MODULES default y if ARCH_EXYNOS However, many developers may want MODULES=y, but not want to bother with an initramfs. So perhaps we need a new symbol MINIMUM_GENERIC_KERNEL or so, protected by EXPERT, and make the driver default to m if that is enabled? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel