All of lore.kernel.org
 help / color / mirror / Atom feed
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook
Date: Wed, 28 Feb 2018 15:23:28 +0100	[thread overview]
Message-ID: <CAMuHMdWdua0+wsaMnkqRceOO=C5r23F-8jdnkwuR6kLBpUPb2g@mail.gmail.com> (raw)
In-Reply-To: <20180228135704.vuhk5mb6mqgc6jlr@lakrids.cambridge.arm.com>

On Wed, Feb 28, 2018 at 2:57 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Feb 26, 2018 at 04:10:56PM +0000, Will Deacon wrote:
>> Commit 6de3f79112cc ("arm_pmu: explicitly enable/disable SPIs at hotplug")
>> moved all of the arm_pmu IRQ enable/disable calls to the CPU hotplug hooks,
>> regardless of whether they are implemented as PPIs or SPIs. This can
>> lead to us sleeping from atomic context due to disable_irq blocking:
>
>> Acked-by: Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> I think something went wrong here when you applied the tag. ;)

In case of respinning:
Fixes: 6de3f79112cc26bf ("arm_pmu: explicitly enable/disable SPIs at hotplug")

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2018-02-28 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 16:10 [PATCH] arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook Will Deacon
2018-02-28 13:57 ` Mark Rutland
2018-02-28 14:23   ` Geert Uytterhoeven [this message]
2018-02-28 14:27     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWdua0+wsaMnkqRceOO=C5r23F-8jdnkwuR6kLBpUPb2g@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.