From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbeDINOd (ORCPT ); Mon, 9 Apr 2018 09:14:33 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:34730 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbeDINOb (ORCPT ); Mon, 9 Apr 2018 09:14:31 -0400 X-Google-Smtp-Source: AIpwx4/TARL9lOQGao88eSTS/Luj5Jdzn0czm+xisdYLcSyEVAKLvGXqZDlNiUHYu0m06r7ZipxlNJ8e0AxZGk8qepw= MIME-Version: 1.0 In-Reply-To: <803fabab1f0349bafe52b5589eff3edc077eee2d.1522546571.git.fthain@telegraphics.com.au> References: <803fabab1f0349bafe52b5589eff3edc077eee2d.1522546571.git.fthain@telegraphics.com.au> From: Geert Uytterhoeven Date: Mon, 9 Apr 2018 15:14:29 +0200 X-Google-Sender-Auth: CthSo3xa-y_4OawkOlmvQNz09Qg Message-ID: Subject: Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl To: Finn Thain Cc: Laurent Vivier , Jens Axboe , linux-m68k , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain wrote: > The 'eject' shell command may send various different ioctl commands. > This leads to error messages on the console even though the FDEJECT > ioctl succeeds. > > ~# eject floppy > SWIM floppy_ioctl: unknown cmd 21257 > SWIM floppy_ioctl: unknown cmd 1 > > Don't log an error message for an invalid ioctl, just do as the > swim3 driver does and return -ENOTTY. > > Cc: Laurent Vivier > Cc: Jens Axboe > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven Looks like amiflop can use a similar fix. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds