From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44503C48BD1 for ; Fri, 11 Jun 2021 08:50:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2611F613CA for ; Fri, 11 Jun 2021 08:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbhFKIwH (ORCPT ); Fri, 11 Jun 2021 04:52:07 -0400 Received: from mail-ua1-f51.google.com ([209.85.222.51]:43627 "EHLO mail-ua1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231230AbhFKIwF (ORCPT ); Fri, 11 Jun 2021 04:52:05 -0400 Received: by mail-ua1-f51.google.com with SMTP id f1so2310733uaj.10; Fri, 11 Jun 2021 01:50:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ifAGUPWDxWLdwD/TBCG2zW8z6+MGYCS4uLUux0tgU4s=; b=cwSVbedGPH1HoQRU7LcjJut5OAMax5Vs/AvytjLY3x/2sZEmG9MoY0UsaxTSmXNqq3 fL6Zg20JQOObNHDt2GHNX710V8AwHqKTNqYE9ZgWwwGEKkclYj0bTq/HXIK31uFEN1p8 tF/ZC0OjuKzWvT/tklFjA/3gZfY/TKhIpLYPSaT7DzvRxT/CPOTfZVTuPz1k2c4XHFsp fVIkmEoe723W5sqFll1Okfs30WseGcZ76CKAPviz46jEkpZeTTIpIkCEhW0Va6YdZUs/ WWjb46LCrPBh+xRII+666+17FCbe1tVk2d1I5TZkac/pdtkT/ILpvGIBPLumuEQxdeWm jkpw== X-Gm-Message-State: AOAM532g7/zohzVsjVaFYTs+9/5/D7NF5NCla8gKugvmiL9ZLIRLlo67 mNuCw2K8b5sXrZ/bC/YnKqVN2ciP4f8HZQtyoqE= X-Google-Smtp-Source: ABdhPJzbyPX5gPeNCkUUxGlNBv5MPjCTQnfbsIAbZJkKiL21UsU0PKAX3/X6PRWC2NYqV9JQbybafT1XLL5zi6s4hwQ= X-Received: by 2002:ab0:484b:: with SMTP id c11mr1936247uad.100.1623401407055; Fri, 11 Jun 2021 01:50:07 -0700 (PDT) MIME-Version: 1.0 References: <20210611082810.970791107@infradead.org> <20210611082838.222401495@infradead.org> In-Reply-To: <20210611082838.222401495@infradead.org> From: Geert Uytterhoeven Date: Fri, 11 Jun 2021 10:49:56 +0200 Message-ID: Subject: Re: [PATCH v2 2/7] sched: Introduce task_is_running() To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Borislav Petkov , "the arch/x86 maintainers" , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , Stephen Rothwell , Linux Kernel Mailing List , Linux-Arch Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hoi Peter, Thanks for your patch! On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra wrote: > Replace a bunch of 'p->state == TASK_RUNNING' with a new helper: > task_is_running(p). You're also sticking a READ_ONCE() in the helper, which wasn't done by any of the old implementations? Care to mention why? > Signed-off-by: Peter Zijlstra (Intel) > Acked-by: Davidlohr Bueso > arch/m68k/kernel/process.c | 2 +- Regardless: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds