From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7237FC3A59E for ; Mon, 26 Aug 2019 08:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C4D820874 for ; Mon, 26 Aug 2019 08:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730737AbfHZIiR (ORCPT ); Mon, 26 Aug 2019 04:38:17 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34912 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730705AbfHZIiQ (ORCPT ); Mon, 26 Aug 2019 04:38:16 -0400 Received: by mail-oi1-f195.google.com with SMTP id a127so11516589oii.2; Mon, 26 Aug 2019 01:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S97RvsRiKIiK8t6HN0Bo20TQZGEw922DDvAZ31Eixeg=; b=nf74FlP0FzTCTsXSDHfqdRtUaBLWvrT9s52Rci+0W82VVPyr1phHG9lemAmZj4Tuc3 46TJ4Gyh2dvnVjJdRWfFi/rqZIwFz97dBpn0aBItAiJjDM6NQSau2cVYnZHeMSCC0vVa nfLxe0zzfKywiXhjjnCkqkvuOLI0FAzddG9p08FLmkfbXldZDfXnXZh8r37vRHOWnLRg P+UNo3RO6gUvlEDmm9jXVmdPJDV1sm9CUO8oQKTA4XIFFgNSz6DAnFueKcwt3gNv61YO sg1Xt9vSXRd7jOJ7OjIgHFmT4b57ZTXsFOR39NuF6w79DxE4j9qDV+aXVbowrxZoLcWa ZzRg== X-Gm-Message-State: APjAAAUI2RCM0/DekfVsK/VurKumrRjwGBK+CIkrhn22rFf+EDFUb11D 99WqxztWcUE92BTH3jxSMRHodHO3Jnw4QMfk0K7lECo7 X-Google-Smtp-Source: APXvYqwS8pPXQBTu7rOA7Ra36ZN5byF9JEUVZwQ88s7wxrXqb3PQ6w+mwoiH0MbAT1cJodMEFqRUkvdBUISj1SUi2yc= X-Received: by 2002:aca:b154:: with SMTP id a81mr10921390oif.148.1566808695135; Mon, 26 Aug 2019 01:38:15 -0700 (PDT) MIME-Version: 1.0 References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-2-jacopo+renesas@jmondi.org> <20190826075943.h7ivwagape3glym5@uno.localdomain> In-Reply-To: <20190826075943.h7ivwagape3glym5@uno.localdomain> From: Geert Uytterhoeven Date: Mon, 26 Aug 2019 10:38:04 +0200 Message-ID: Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation To: Jacopo Mondi Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Mon, Aug 26, 2019 at 9:58 AM Jacopo Mondi wrote: > On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > > > Add device tree bindings documentation for the Renesas R-Car Display > > > Unit Color Management Module. > > > > > > CMM is the image enhancement module available on each R-Car DU video > > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > > > Signed-off-by: Jacopo Mondi > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > > @@ -0,0 +1,33 @@ > > > +* Renesas R-Car Color Management Module (CMM) > > > + > > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > > + > > > +Required properties: > > > + - compatible: shall be one or more of the following: > > > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM. > > > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM. > > > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM. > > > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM. > > > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM. > > > > Please use "renesas,-cmm" instead of "renesas,cmm-". > > > > I actually copied it from the r-car gpio bindings, and I liked > cmm- better. If you prefer I can change it though. We switched from "renesas,cmm-" to "renesas,-cmm" a few years ago, upon request from the DT people: vendor -> family/SoC -> IP core Unfortunately we cannot change the old style in existing bindings, without great effort and backwards compatibility ramifications. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Date: Mon, 26 Aug 2019 10:38:04 +0200 Message-ID: References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-2-jacopo+renesas@jmondi.org> <20190826075943.h7ivwagape3glym5@uno.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190826075943.h7ivwagape3glym5@uno.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Jacopo Mondi Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Hi Jacopo, On Mon, Aug 26, 2019 at 9:58 AM Jacopo Mondi wrote: > On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > > > Add device tree bindings documentation for the Renesas R-Car Display > > > Unit Color Management Module. > > > > > > CMM is the image enhancement module available on each R-Car DU video > > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > > > Signed-off-by: Jacopo Mondi > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > > @@ -0,0 +1,33 @@ > > > +* Renesas R-Car Color Management Module (CMM) > > > + > > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > > + > > > +Required properties: > > > + - compatible: shall be one or more of the following: > > > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM. > > > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM. > > > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM. > > > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM. > > > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM. > > > > Please use "renesas,-cmm" instead of "renesas,cmm-". > > > > I actually copied it from the r-car gpio bindings, and I liked > cmm- better. If you prefer I can change it though. We switched from "renesas,cmm-" to "renesas,-cmm" a few years ago, upon request from the DT people: vendor -> family/SoC -> IP core Unfortunately we cannot change the old style in existing bindings, without great effort and backwards compatibility ramifications. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds