From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E9EC433E6 for ; Mon, 22 Mar 2021 17:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFD8E61983 for ; Mon, 22 Mar 2021 17:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230365AbhCVRxe (ORCPT ); Mon, 22 Mar 2021 13:53:34 -0400 Received: from mail-vk1-f173.google.com ([209.85.221.173]:41683 "EHLO mail-vk1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbhCVRxM (ORCPT ); Mon, 22 Mar 2021 13:53:12 -0400 Received: by mail-vk1-f173.google.com with SMTP id o85so3997492vko.8; Mon, 22 Mar 2021 10:53:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=51zGCqBXl43ZX311IoQVz5nD7uSEuSK9azOqp9/NNbM=; b=p+uTj9SB+SWIOU4RI9xGoSOSVyDFLxRwwLxzxlzFOV6/FlvsyhDj11e3dV65r3Fn4X 7I6IntLTgOqaJH3RxykloS+jyz3k9gRoVlFiFJVNfu6ZGDlPPam6LHC3TcivMOBaXg1S YyV8lJwlQ2TogEAQHtTOGeCwtbAHjqH/hSH/Llp6wepTAjA7RtxrN7ua5Epj4OwAqhYd o9b7NjBmnQ34kIaLAtjdYaERw0awpSQsyvoMxfLlIkLEBzhh6BG7scZrjD22wJ/NGOa0 IxR/6YzhZT+i7tZDi/EwbePkRW9yoxAjOUlsdaaSJqrVX46MgmXiS3W6w+d4lOnGemSx wKKg== X-Gm-Message-State: AOAM530UgN9k6YJWeZMTx0xcsriPWW8E2tFmpPqxO1NP0D1vUVRwRtrg A2q+rHNGp/bWtdlhpGPmaT/zcaS4hTrUMVMyt0k= X-Google-Smtp-Source: ABdhPJwV75rRcQ1W+AfL+sk8wmoLPCnpP/A7gDAMFs4WtMd7EVrylU6+gzXqmOlYAkXlJrsD2M3/fRhvURo7Acq/Drs= X-Received: by 2002:a1f:2502:: with SMTP id l2mr875345vkl.5.1616435591316; Mon, 22 Mar 2021 10:53:11 -0700 (PDT) MIME-Version: 1.0 References: <20210322144848.1065067-1-geert@linux-m68k.org> <20210322144848.1065067-5-geert@linux-m68k.org> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 22 Mar 2021 18:53:00 +0100 Message-ID: Subject: Re: [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev To: Miguel Ojeda Cc: Robin van der Gracht , Rob Herring , Miguel Ojeda , Paul Burton , Greg Kroah-Hartman , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:BROADCOM NVRAM DRIVER" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miguel, On Mon, Mar 22, 2021 at 5:59 PM Miguel Ojeda wrote: > On Mon, Mar 22, 2021 at 3:48 PM Geert Uytterhoeven wrote: > > + struct device *dev = &pdev->dev; > > Do we want helpers like this to be `*const` (assuming they can)? (same > for patch 12). No, e.g. the devm_*() functions need to make changes to the device's structure. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds