Re: [PATCH RFC 2/2] m68k: setup_mm.c: set isa_sex for Atari if ATARI_ROM_ISA not used

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Michael,

On Wed, Jun 2, 2021 at 7:21 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> For multiplatform kernels where CONFIG_ATARI_ROM_ISA is not set,
> at least isa_sex must be set correctly to allow for correct I/O
> primitive selection in shared drivers.
>
> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>

Thanks for your patch!


> --- a/arch/m68k/kernel/setup_mm.c
> +++ b/arch/m68k/kernel/setup_mm.c
> @@ -386,6 +386,10 @@ void __init setup_arch(char **cmdline_p)
>                 isa_type = ISA_TYPE_ENEC;
>                 isa_sex = 0;
>         }
> +#else
> +       if (MACH_IS_ATARI) {
> +               isa_sex = 0;

I find it strange that you set isa_sex, but not isa_type?
However, this is inside the CONFIG_ISA && MULTI_ISA block, so
what kind of ISA does this correspond to?

> +       }
>  #endif
>  #endif

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds