From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Lars Persson <lars.persson@axis.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-kernel@axis.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mmc: usdhi6rol0: : use proper DMAENGINE API for termination
Date: Wed, 23 Jun 2021 15:56:16 +0200 [thread overview]
Message-ID: <CAMuHMdWk4gHc682m1YeAYJ8DLjSVuXaBNNXLfjUR4E=n0ZRJ2w@mail.gmail.com> (raw)
In-Reply-To: <20210623095734.3046-4-wsa+renesas@sang-engineering.com>
On Wed, Jun 23, 2021 at 11:58 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> dmaengine_terminate_all() is deprecated in favor of explicitly saying if
> it should be sync or async. Here, we want dmaengine_terminate_sync()
> because there is no other synchronization code in the driver to handle
> an async case.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Looks OK, as this driver uses a threaded irq handler.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Have you tried triggering DMA termination, with lockdep enabled?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-06-23 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 9:57 [PATCH 0/3] mmc: use proper DMAENGINE API for termination Wolfram Sang
2021-06-23 9:57 ` [PATCH 1/3] mmc: renesas_sdhi_sys_dmac: : " Wolfram Sang
2021-06-23 9:57 ` [PATCH 2/3] mmc: sh_mmcif: " Wolfram Sang
2021-06-23 13:55 ` Geert Uytterhoeven
2021-06-23 9:57 ` [PATCH 3/3] mmc: usdhi6rol0: " Wolfram Sang
2021-06-23 13:56 ` Geert Uytterhoeven [this message]
2021-06-29 15:09 ` [PATCH 0/3] mmc: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWk4gHc682m1YeAYJ8DLjSVuXaBNNXLfjUR4E=n0ZRJ2w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=jesper.nilsson@axis.com \
--cc=lars.persson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.