From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 11 Jun 2014 13:38:49 +0000 Subject: Re: [PATCH] arm/ftrace: Fix function_return_addr() to function_return_address() Message-Id: List-Id: References: <1394862048-28758-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-2-git-send-email-takahiro.akashi@linaro.org> <20140611092330.7930eff2@gandalf.local.home> In-Reply-To: <20140611092330.7930eff2@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Steven, On Wed, Jun 11, 2014 at 3:23 PM, Steven Rostedt wrote: > The clean up of CALLER_ADDR*() functions required the archs to either > use the default __builtin_return_address(X) (where X > 0) or override > it with something the arch can use. To override it, the arch would > define function_return_address(x). ftrace_return_address(x) > The arm architecture requires this to be redefined but instead of > defining function_return_address(x) it defined function_return_addr(x). ftrace_return_address(x) ... ftrace_return_address(x) > Reported-by: Geert Uytterhoeven > Signed-off-by: Steven Rostedt Nevertheless, your patch kills the warnings. Thanks! Tested-by: Geert Uytterhoeven > ---- > diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h > index eb577f4..39eb16b 100644 > --- a/arch/arm/include/asm/ftrace.h > +++ b/arch/arm/include/asm/ftrace.h > @@ -52,7 +52,7 @@ extern inline void *return_address(unsigned int level) > > #endif > > -#define ftrace_return_addr(n) return_address(n) > +#define ftrace_return_address(n) return_address(n) > > #endif /* ifndef __ASSEMBLY__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755705AbaFKNiz (ORCPT ); Wed, 11 Jun 2014 09:38:55 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:54207 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754449AbaFKNix (ORCPT ); Wed, 11 Jun 2014 09:38:53 -0400 MIME-Version: 1.0 In-Reply-To: <20140611092330.7930eff2@gandalf.local.home> References: <1394862048-28758-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-2-git-send-email-takahiro.akashi@linaro.org> <20140611092330.7930eff2@gandalf.local.home> Date: Wed, 11 Jun 2014 15:38:49 +0200 X-Google-Sender-Auth: AMGVoCdtGEUyQolbjo7A4hnvLO8 Message-ID: Subject: Re: [PATCH] arm/ftrace: Fix function_return_addr() to function_return_address() From: Geert Uytterhoeven To: Steven Rostedt Cc: Will Deacon , AKASHI Takahiro , =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= , Ingo Molnar , Catalin Marinas , Tim Bird , gkulkarni@caviumnetworks.com, Deepak Saxena , arndb@arndb.de, "linux-arm-kernel@lists.infradead.org" , linaro-kernel , "linux-kernel@vger.kernel.org" , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On Wed, Jun 11, 2014 at 3:23 PM, Steven Rostedt wrote: > The clean up of CALLER_ADDR*() functions required the archs to either > use the default __builtin_return_address(X) (where X > 0) or override > it with something the arch can use. To override it, the arch would > define function_return_address(x). ftrace_return_address(x) > The arm architecture requires this to be redefined but instead of > defining function_return_address(x) it defined function_return_addr(x). ftrace_return_address(x) ... ftrace_return_address(x) > Reported-by: Geert Uytterhoeven > Signed-off-by: Steven Rostedt Nevertheless, your patch kills the warnings. Thanks! Tested-by: Geert Uytterhoeven > ---- > diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h > index eb577f4..39eb16b 100644 > --- a/arch/arm/include/asm/ftrace.h > +++ b/arch/arm/include/asm/ftrace.h > @@ -52,7 +52,7 @@ extern inline void *return_address(unsigned int level) > > #endif > > -#define ftrace_return_addr(n) return_address(n) > +#define ftrace_return_address(n) return_address(n) > > #endif /* ifndef __ASSEMBLY__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Wed, 11 Jun 2014 15:38:49 +0200 Subject: [PATCH] arm/ftrace: Fix function_return_addr() to function_return_address() In-Reply-To: <20140611092330.7930eff2@gandalf.local.home> References: <1394862048-28758-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-1-git-send-email-takahiro.akashi@linaro.org> <1398851676-16389-2-git-send-email-takahiro.akashi@linaro.org> <20140611092330.7930eff2@gandalf.local.home> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Steven, On Wed, Jun 11, 2014 at 3:23 PM, Steven Rostedt wrote: > The clean up of CALLER_ADDR*() functions required the archs to either > use the default __builtin_return_address(X) (where X > 0) or override > it with something the arch can use. To override it, the arch would > define function_return_address(x). ftrace_return_address(x) > The arm architecture requires this to be redefined but instead of > defining function_return_address(x) it defined function_return_addr(x). ftrace_return_address(x) ... ftrace_return_address(x) > Reported-by: Geert Uytterhoeven > Signed-off-by: Steven Rostedt Nevertheless, your patch kills the warnings. Thanks! Tested-by: Geert Uytterhoeven > ---- > diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h > index eb577f4..39eb16b 100644 > --- a/arch/arm/include/asm/ftrace.h > +++ b/arch/arm/include/asm/ftrace.h > @@ -52,7 +52,7 @@ extern inline void *return_address(unsigned int level) > > #endif > > -#define ftrace_return_addr(n) return_address(n) > +#define ftrace_return_address(n) return_address(n) > > #endif /* ifndef __ASSEMBLY__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds