From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Max Staudt <max@enpas.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"Linux/m68k" <linux-m68k@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Date: Tue, 13 Aug 2019 08:53:14 +0200 [thread overview]
Message-ID: <CAMuHMdWr8VNBBVjgcu9wtdby-0pznEtg=GeVmAcrk78Of7gwNA@mail.gmail.com> (raw)
In-Reply-To: <0d61e12f-5fc5-7cb6-755f-298ebf4c935f@enpas.org>
Hi Max,
On Tue, Aug 13, 2019 at 12:21 AM Max Staudt <max@enpas.org> wrote:
> On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote:
> >> + iowrite8(val, address);
> >
> > As this is on a Zorro bus, z_writeb()?
>
> I forgot to ask about this.
>
> What is the reasoning behind having a separate z_writeb() for Zorro?
> As far as I can see in arch/m68k/include/asm this maps 1:1 to a direct memory access, and it prohibits cross-arch code as in i2c-elektor.
write*() and friends are intended for PCI, and thus little endian, while
the Zorro bus is big endian. For byte accesses this doesn't matter,
obviously.
Note that this predates iowrite*(), which does have *be variants.
If you want to add compile-testing to your driver, using iowrite*() is fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-08-13 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 4:32 [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-11 4:40 ` Max Staudt
2019-08-12 9:37 ` Geert Uytterhoeven
2019-08-12 10:43 ` Max Staudt
2019-08-12 11:07 ` Geert Uytterhoeven
2019-08-12 11:48 ` Max Staudt
2019-08-12 22:21 ` Max Staudt
2019-08-13 6:53 ` Geert Uytterhoeven [this message]
2019-08-20 9:23 [PATCH v5 1/3] " Max
2019-08-20 9:27 ` [PATCH] " Max Staudt
2019-08-29 19:00 ` Wolfram Sang
2019-08-29 19:17 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWr8VNBBVjgcu9wtdby-0pznEtg=GeVmAcrk78Of7gwNA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=max@enpas.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.