From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 18 Dec 2015 10:07:23 +0000 Subject: Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT Message-Id: List-Id: References: <1448863990-16276-1-git-send-email-horms+renesas@verge.net.au> <20151201064149.GH16260@verge.net.au> <20151218025410.GA10973@verge.net.au> In-Reply-To: <20151218025410.GA10973@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org Hi Simon, On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman wrote: > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman wrote: >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> wrote: >> >> > Enable the QSPI controller in the alt device tree. >> >> > >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> > Sergei Shtylyov. >> >> > >> >> > Cc: Vladimir Barinov >> >> > Cc: Sergei Shtylyov >> >> > Signed-off-by: Simon Horman >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> Acked-by: Geert Uytterhoeven >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> FLASH layout for the second and third partition. >> > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> > the same as the document you referred to above? >> > >> > >> > partition@0 { >> > label =3D "loader"; >> > reg =3D <0x00000000 0x00080000>; >> > read-only; >> > }; >> > partition@40000 { >> > label =3D "user"; >> > reg =3D <0x00080000 0x00580000>; >> > read-only; >> > }; >> > partition@440000 { >> > label =3D "flash"; >> > reg =3D <0x00600000 0x03a00000>; >> > }; >> > >> > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backpor= t.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=3Drcar-gen2/v1.9.6&id=E1acbe= 074f36d96e901bf5346c50ee51da2ced42#n379 >> >> No, the document specifies 3 partitions: >> - SA0: loader program area, 16 KiB, Sorry, I missed a "Not used" part after that, and started miscounting zeroes on top of that :-( So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> - SA1: System area, 16 KiB, Should be 256 KiB. >> - SA2: User program area, remainder. >> >> FWIW, the unit addresses in the device nodes above are not consistent >> with their reg properties. > > My feeling is that we should follow the documentation. > Does this reflect the scheme it describes? > > > partitions { > #address-cells =3D <1>; > #size-cells =3D <1>; > > partition@0 { > label =3D "loader"; > reg =3D <0x00000000 0x00004000>; reg =3D <0x00000000 0x00040000>; > read-only; > }; > partition@4000 { partition@40000 > label =3D "system"; > reg =3D <0x00004000 0x00004000>; reg =3D <0x00040000 0x00040000>; > read-only; > }; > partition@8000 { partition@80000 > label =3D "user"; > reg =3D <0x00008000 0x03ff8000>; reg =3D <0x00080000 0x03f80000>; > }; > }; I don't have an ALT. Does this match with the actual FLASH contents? Sorry for the wreck on my side. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 18 Dec 2015 11:07:23 +0100 Subject: [PATCH] ARM: shmobile: alt: Add QSPI device to DT In-Reply-To: <20151218025410.GA10973@verge.net.au> References: <1448863990-16276-1-git-send-email-horms+renesas@verge.net.au> <20151201064149.GH16260@verge.net.au> <20151218025410.GA10973@verge.net.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Simon, On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman wrote: > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman wrote: >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> wrote: >> >> > Enable the QSPI controller in the alt device tree. >> >> > >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> > Sergei Shtylyov. >> >> > >> >> > Cc: Vladimir Barinov >> >> > Cc: Sergei Shtylyov >> >> > Signed-off-by: Simon Horman >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> Acked-by: Geert Uytterhoeven >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> FLASH layout for the second and third partition. >> > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> > the same as the document you referred to above? >> > >> > >> > partition at 0 { >> > label = "loader"; >> > reg = <0x00000000 0x00080000>; >> > read-only; >> > }; >> > partition at 40000 { >> > label = "user"; >> > reg = <0x00080000 0x00580000>; >> > read-only; >> > }; >> > partition at 440000 { >> > label = "flash"; >> > reg = <0x00600000 0x03a00000>; >> > }; >> > >> > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 >> >> No, the document specifies 3 partitions: >> - SA0: loader program area, 16 KiB, Sorry, I missed a "Not used" part after that, and started miscounting zeroes on top of that :-( So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> - SA1: System area, 16 KiB, Should be 256 KiB. >> - SA2: User program area, remainder. >> >> FWIW, the unit addresses in the device nodes above are not consistent >> with their reg properties. > > My feeling is that we should follow the documentation. > Does this reflect the scheme it describes? > > > partitions { > #address-cells = <1>; > #size-cells = <1>; > > partition at 0 { > label = "loader"; > reg = <0x00000000 0x00004000>; reg = <0x00000000 0x00040000>; > read-only; > }; > partition at 4000 { partition at 40000 > label = "system"; > reg = <0x00004000 0x00004000>; reg = <0x00040000 0x00040000>; > read-only; > }; > partition at 8000 { partition at 80000 > label = "user"; > reg = <0x00008000 0x03ff8000>; reg = <0x00080000 0x03f80000>; > }; > }; I don't have an ALT. Does this match with the actual FLASH contents? Sorry for the wreck on my side. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds