From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbdK0KpE (ORCPT ); Mon, 27 Nov 2017 05:45:04 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:39243 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbdK0KpB (ORCPT ); Mon, 27 Nov 2017 05:45:01 -0500 X-Google-Smtp-Source: AGs4zMagbjwQ5TXjKPYem880dW3W8ODOZ+YzX2SVjuWH1VE3ep9DBhwGdEPwB5HL0yzCBUsujlAlIKS8YZZ5rcAiWxs= MIME-Version: 1.0 In-Reply-To: <20171127094622.phmx4ej2fljcytce@mwanda> References: <20171125182636.15245-1-j.lacomis@gmail.com> <20171127094622.phmx4ej2fljcytce@mwanda> From: Geert Uytterhoeven Date: Mon, 27 Nov 2017 11:45:00 +0100 X-Google-Sender-Auth: dDdRDw9lDocrBpN6YMlpyQBSmpk Message-ID: Subject: Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h To: Dan Carpenter Cc: Jeremy Lacomis , Sudip Mukherjee , Teddy Wang , Greg KH , driverdevel , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter wrote: > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: >> This patch to ddk750_sii164.h fixes line length warnings found by the >> checkpatch.pl script and reformats comments uniformly. >> >> Signed-off-by: Jeremy Lacomis >> --- >> drivers/staging/sm750fb/ddk750_sii164.h | 57 +++++++++++++-------------------- >> 1 file changed, 22 insertions(+), 35 deletions(-) >> >> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h >> index 2e9a88cd6af3..393a3c5be3ae 100644 >> --- a/drivers/staging/sm750fb/ddk750_sii164.h >> +++ b/drivers/staging/sm750fb/ddk750_sii164.h >> @@ -4,15 +4,20 @@ >> >> #define USE_DVICHIP >> >> -/* Hot Plug detection mode structure */ >> +/* >> + * Hot Plug detection mode structure: >> + * Disable Hot Plug output bit (always high). >> + * Use Monitor Detect Interrupt bit. >> + * Use Receiver Sense detect bit. >> + * Use Hot Plug detect bit. >> + */ >> enum sii164_hot_plug_mode { >> - SII164_HOTPLUG_DISABLE = 0, /* Disable Hot Plug output bit (always high). */ >> - SII164_HOTPLUG_USE_MDI, /* Use Monitor Detect Interrupt bit. */ >> - SII164_HOTPLUG_USE_RSEN, /* Use Receiver Sense detect bit. */ >> - SII164_HOTPLUG_USE_HTPLG /* Use Hot Plug detect bit. */ >> + SII164_HOTPLUG_DISABLE = 0, >> + SII164_HOTPLUG_USE_MDI, >> + SII164_HOTPLUG_USE_RSEN, >> + SII164_HOTPLUG_USE_HTPLG >> }; > > I feel like this makes it less readable. The original was better. And more error prone. NAKed-by: Geert Uytterhoeven Please use common sense when following checkpatch.pl's advise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 27 Nov 2017 10:45:00 +0000 Subject: Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h Message-Id: List-Id: References: <20171125182636.15245-1-j.lacomis@gmail.com> <20171127094622.phmx4ej2fljcytce@mwanda> In-Reply-To: <20171127094622.phmx4ej2fljcytce@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Jeremy Lacomis , Sudip Mukherjee , Teddy Wang , Greg KH , driverdevel , Linux Fbdev development list , "linux-kernel@vger.kernel.org" On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter wrote: > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: >> This patch to ddk750_sii164.h fixes line length warnings found by the >> checkpatch.pl script and reformats comments uniformly. >> >> Signed-off-by: Jeremy Lacomis >> --- >> drivers/staging/sm750fb/ddk750_sii164.h | 57 +++++++++++++-------------------- >> 1 file changed, 22 insertions(+), 35 deletions(-) >> >> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h >> index 2e9a88cd6af3..393a3c5be3ae 100644 >> --- a/drivers/staging/sm750fb/ddk750_sii164.h >> +++ b/drivers/staging/sm750fb/ddk750_sii164.h >> @@ -4,15 +4,20 @@ >> >> #define USE_DVICHIP >> >> -/* Hot Plug detection mode structure */ >> +/* >> + * Hot Plug detection mode structure: >> + * Disable Hot Plug output bit (always high). >> + * Use Monitor Detect Interrupt bit. >> + * Use Receiver Sense detect bit. >> + * Use Hot Plug detect bit. >> + */ >> enum sii164_hot_plug_mode { >> - SII164_HOTPLUG_DISABLE = 0, /* Disable Hot Plug output bit (always high). */ >> - SII164_HOTPLUG_USE_MDI, /* Use Monitor Detect Interrupt bit. */ >> - SII164_HOTPLUG_USE_RSEN, /* Use Receiver Sense detect bit. */ >> - SII164_HOTPLUG_USE_HTPLG /* Use Hot Plug detect bit. */ >> + SII164_HOTPLUG_DISABLE = 0, >> + SII164_HOTPLUG_USE_MDI, >> + SII164_HOTPLUG_USE_RSEN, >> + SII164_HOTPLUG_USE_HTPLG >> }; > > I feel like this makes it less readable. The original was better. And more error prone. NAKed-by: Geert Uytterhoeven Please use common sense when following checkpatch.pl's advise. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds