* [PATCH] arm64: dts: renesas: adjust whitespace around '='
@ 2022-05-26 20:42 Krzysztof Kozlowski
2022-05-26 21:05 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-26 20:42 UTC (permalink / raw)
To: Arnd Bergmann, Olof Johansson, arm, soc, Geert Uytterhoeven,
Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Fix whitespace coding style: use single space instead of tabs or
multiple spaces around '=' sign in property assignment. No functional
changes (same DTB).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Output compared with dtx_diff and fdtdump.
---
arch/arm64/boot/dts/renesas/draak.dtsi | 2 +-
arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +-
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 +++++++-------
arch/arm64/boot/dts/renesas/ulcb.dtsi | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
index 7231f820d601..ef3bb835d5c0 100644
--- a/arch/arm64/boot/dts/renesas/draak.dtsi
+++ b/arch/arm64/boot/dts/renesas/draak.dtsi
@@ -630,7 +630,7 @@ rsnd_for_ak4613: endpoint {
bitclock-master = <&rsnd_for_ak4613>;
frame-master = <&rsnd_for_ak4613>;
playback = <&ssi3>, <&src5>, <&dvc0>;
- capture = <&ssi4>, <&src6>, <&dvc1>;
+ capture = <&ssi4>, <&src6>, <&dvc1>;
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi
index 72f359efa23e..aef0896b2f5f 100644
--- a/arch/arm64/boot/dts/renesas/ebisu.dtsi
+++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi
@@ -711,7 +711,7 @@ &rcar_sound {
rcar_sound,dai {
dai0 {
playback = <&ssi0>, <&src0>, <&dvc0>;
- capture = <&ssi1>, <&src1>, <&dvc1>;
+ capture = <&ssi1>, <&src1>, <&dvc1>;
};
};
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 31837fcd7bf0..09ff1708cfa6 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -832,7 +832,7 @@ rsnd_endpoint0: endpoint {
frame-master = <&rsnd_endpoint0>;
playback = <&ssi0>, <&src0>, <&dvc0>;
- capture = <&ssi1>, <&src1>, <&dvc1>;
+ capture = <&ssi1>, <&src1>, <&dvc1>;
};
};
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 5bcb84403ef6..408871c2859d 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -206,12 +206,12 @@ pcm3168a: audio-codec@44 {
clocks = <&clksndsel>;
clock-names = "scki";
- VDD1-supply = <&snd_3p3v>;
- VDD2-supply = <&snd_3p3v>;
- VCCAD1-supply = <&snd_vcc5v>;
- VCCAD2-supply = <&snd_vcc5v>;
- VCCDA1-supply = <&snd_vcc5v>;
- VCCDA2-supply = <&snd_vcc5v>;
+ VDD1-supply = <&snd_3p3v>;
+ VDD2-supply = <&snd_3p3v>;
+ VCCAD1-supply = <&snd_vcc5v>;
+ VCCAD2-supply = <&snd_vcc5v>;
+ VCCDA1-supply = <&snd_vcc5v>;
+ VCCDA2-supply = <&snd_vcc5v>;
ports {
#address-cells = <1>;
@@ -438,7 +438,7 @@ rsnd_for_pcm3168a_capture: endpoint {
bitclock-master;
frame-master;
dai-tdm-slot-num = <6>;
- capture = <&ssi4>;
+ capture = <&ssi4>;
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 90a4c0629d24..5f390865a4cd 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -411,7 +411,7 @@ rsnd_for_ak4613: endpoint {
bitclock-master;
frame-master;
playback = <&ssi0>, <&src0>, <&dvc0>;
- capture = <&ssi1>, <&src1>, <&dvc1>;
+ capture = <&ssi1>, <&src1>, <&dvc1>;
};
};
rsnd_port1: port@1 {
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: renesas: adjust whitespace around '='
2022-05-26 20:42 [PATCH] arm64: dts: renesas: adjust whitespace around '=' Krzysztof Kozlowski
@ 2022-05-26 21:05 ` Geert Uytterhoeven
2022-05-26 21:10 ` Krzysztof Kozlowski
2022-06-09 9:40 ` Geert Uytterhoeven
2022-07-01 20:41 ` patchwork-bot+linux-soc
2 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-05-26 21:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Olof Johansson, arm-soc, arm-soc,
Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Krzysztof,
On Thu, May 26, 2022 at 10:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Fix whitespace coding style: use single space instead of tabs or
> multiple spaces around '=' sign in property assignment. No functional
> changes (same DTB).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/draak.dtsi
> +++ b/arch/arm64/boot/dts/renesas/draak.dtsi
> @@ -630,7 +630,7 @@ rsnd_for_ak4613: endpoint {
> bitclock-master = <&rsnd_for_ak4613>;
> frame-master = <&rsnd_for_ak4613>;
> playback = <&ssi3>, <&src5>, <&dvc0>;
> - capture = <&ssi4>, <&src6>, <&dvc1>;
> + capture = <&ssi4>, <&src6>, <&dvc1>;
I think the idea was to align the playback and capture properties,
for easier comparison.
Hence I'm a bit undecided if this needs to be fixed or not...
> };
> };
> };
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -206,12 +206,12 @@ pcm3168a: audio-codec@44 {
> clocks = <&clksndsel>;
> clock-names = "scki";
>
> - VDD1-supply = <&snd_3p3v>;
> - VDD2-supply = <&snd_3p3v>;
> - VCCAD1-supply = <&snd_vcc5v>;
> - VCCAD2-supply = <&snd_vcc5v>;
> - VCCDA1-supply = <&snd_vcc5v>;
> - VCCDA2-supply = <&snd_vcc5v>;
> + VDD1-supply = <&snd_3p3v>;
> + VDD2-supply = <&snd_3p3v>;
> + VCCAD1-supply = <&snd_vcc5v>;
> + VCCAD2-supply = <&snd_vcc5v>;
> + VCCDA1-supply = <&snd_vcc5v>;
> + VCCDA2-supply = <&snd_vcc5v>;
Same for the various supplies.
>
> ports {
> #address-cells = <1>;
> @@ -438,7 +438,7 @@ rsnd_for_pcm3168a_capture: endpoint {
> bitclock-master;
> frame-master;
> dai-tdm-slot-num = <6>;
> - capture = <&ssi4>;
> + capture = <&ssi4>;
Right, there's nothing to align here.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: renesas: adjust whitespace around '='
2022-05-26 21:05 ` Geert Uytterhoeven
@ 2022-05-26 21:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-26 21:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Olof Johansson, arm-soc, arm-soc,
Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On 26/05/2022 23:05, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Thu, May 26, 2022 at 10:42 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> Fix whitespace coding style: use single space instead of tabs or
>> multiple spaces around '=' sign in property assignment. No functional
>> changes (same DTB).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/draak.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/draak.dtsi
>> @@ -630,7 +630,7 @@ rsnd_for_ak4613: endpoint {
>> bitclock-master = <&rsnd_for_ak4613>;
>> frame-master = <&rsnd_for_ak4613>;
>> playback = <&ssi3>, <&src5>, <&dvc0>;
>> - capture = <&ssi4>, <&src6>, <&dvc1>;
>> + capture = <&ssi4>, <&src6>, <&dvc1>;
>
> I think the idea was to align the playback and capture properties,
> for easier comparison.
> Hence I'm a bit undecided if this needs to be fixed or not...
yeah, but then one should align "frame-master" to "bitclock-master" and
several other properties.
>
>> };
>> };
>> };
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -206,12 +206,12 @@ pcm3168a: audio-codec@44 {
>> clocks = <&clksndsel>;
>> clock-names = "scki";
like here ^^^ - clocks with clock-names...
>>
>> - VDD1-supply = <&snd_3p3v>;
>> - VDD2-supply = <&snd_3p3v>;
>> - VCCAD1-supply = <&snd_vcc5v>;
>> - VCCAD2-supply = <&snd_vcc5v>;
>> - VCCDA1-supply = <&snd_vcc5v>;
>> - VCCDA2-supply = <&snd_vcc5v>;
>> + VDD1-supply = <&snd_3p3v>;
>> + VDD2-supply = <&snd_3p3v>;
>> + VCCAD1-supply = <&snd_vcc5v>;
>> + VCCAD2-supply = <&snd_vcc5v>;
>> + VCCDA1-supply = <&snd_vcc5v>;
>> + VCCDA2-supply = <&snd_vcc5v>;
>
> Same for the various supplies.
I don't think there is benefit to order few single entries, while entire
file does not follow that convention. It would be different for some
multiple-line entries, but that's not the case here.
Anyway that's only my opinion, so I am happy to trim the patch to the
last part (although then it is a bit churn :) ).
>
>>
>> ports {
>> #address-cells = <1>;
>> @@ -438,7 +438,7 @@ rsnd_for_pcm3168a_capture: endpoint {
>> bitclock-master;
>> frame-master;
>> dai-tdm-slot-num = <6>;
>> - capture = <&ssi4>;
>> + capture = <&ssi4>;
>
> Right, there's nothing to align here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: renesas: adjust whitespace around '='
2022-05-26 20:42 [PATCH] arm64: dts: renesas: adjust whitespace around '=' Krzysztof Kozlowski
2022-05-26 21:05 ` Geert Uytterhoeven
@ 2022-06-09 9:40 ` Geert Uytterhoeven
2022-07-01 20:41 ` patchwork-bot+linux-soc
2 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-06-09 9:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Olof Johansson, arm-soc, arm-soc,
Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Thu, May 26, 2022 at 10:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Fix whitespace coding style: use single space instead of tabs or
> multiple spaces around '=' sign in property assignment. No functional
> changes (same DTB).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: renesas: adjust whitespace around '='
2022-05-26 20:42 [PATCH] arm64: dts: renesas: adjust whitespace around '=' Krzysztof Kozlowski
2022-05-26 21:05 ` Geert Uytterhoeven
2022-06-09 9:40 ` Geert Uytterhoeven
@ 2022-07-01 20:41 ` patchwork-bot+linux-soc
2 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+linux-soc @ 2022-07-01 20:41 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: soc
Hello:
This patch was applied to soc/soc.git (for-next)
by Geert Uytterhoeven <geert+renesas@glider.be>:
On Thu, 26 May 2022 22:42:31 +0200 you wrote:
> Fix whitespace coding style: use single space instead of tabs or
> multiple spaces around '=' sign in property assignment. No functional
> changes (same DTB).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> [...]
Here is the summary with links:
- arm64: dts: renesas: adjust whitespace around '='
https://git.kernel.org/soc/soc/c/76f9a5615202
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: renesas: Adjust whitespace around '{'
@ 2022-09-16 10:02 Prabhakar
2022-09-18 9:17 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Prabhakar @ 2022-09-16 10:02 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Drop extra space around the '{' sign. No functional changes (same DTB).
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
index ff6aab388eb7..689aa4ba416b 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
@@ -619,7 +619,7 @@ gic: interrupt-controller@11900000 {
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
};
- sdhi0: mmc@11c00000 {
+ sdhi0: mmc@11c00000 {
compatible = "renesas,sdhi-r9a07g043",
"renesas,rcar-gen3-sdhi";
reg = <0x0 0x11c00000 0 0x10000>;
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 35e7255471b8..2283d4fb8736 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -778,7 +778,7 @@ gic: interrupt-controller@11900000 {
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
};
- sdhi0: mmc@11c00000 {
+ sdhi0: mmc@11c00000 {
compatible = "renesas,sdhi-r9a07g044",
"renesas,rcar-gen3-sdhi";
reg = <0x0 0x11c00000 0 0x10000>;
diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
index d27b6c388580..358d4c34465f 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
@@ -784,7 +784,7 @@ gic: interrupt-controller@11900000 {
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
};
- sdhi0: mmc@11c00000 {
+ sdhi0: mmc@11c00000 {
compatible = "renesas,sdhi-r9a07g054",
"renesas,rcar-gen3-sdhi";
reg = <0x0 0x11c00000 0 0x10000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: renesas: Adjust whitespace around '{'
2022-09-16 10:02 [PATCH] arm64: dts: renesas: Adjust whitespace around '{' Prabhakar
@ 2022-09-18 9:17 ` Geert Uytterhoeven
0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-09-18 9:17 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, linux-renesas-soc,
devicetree, linux-kernel, Biju Das, Lad Prabhakar
On Fri, Sep 16, 2022 at 12:03 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Drop extra space around the '{' sign. No functional changes (same DTB).
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.1.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-18 9:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 20:42 [PATCH] arm64: dts: renesas: adjust whitespace around '=' Krzysztof Kozlowski
2022-05-26 21:05 ` Geert Uytterhoeven
2022-05-26 21:10 ` Krzysztof Kozlowski
2022-06-09 9:40 ` Geert Uytterhoeven
2022-07-01 20:41 ` patchwork-bot+linux-soc
2022-09-16 10:02 [PATCH] arm64: dts: renesas: Adjust whitespace around '{' Prabhakar
2022-09-18 9:17 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.