Re: [RFC 5/5] arm: dts: genmai: Add SCIF2 pin group

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linus Walleij <linus.walleij@linaro.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC 5/5] arm: dts: genmai: Add SCIF2 pin group
Date: Mon, 30 Jan 2017 19:55:53 +0100	[thread overview]
Message-ID: <CAMuHMdWxvsKgGfuX3LXFvNoDoD7XYHARkOsXK0t5hhdP+wpkFg@mail.gmail.com> (raw)
In-Reply-To: <1534890.LugBLSd3dc@avalon>

Hi Laurent,

On Mon, Jan 30, 2017 at 7:17 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote:
>> On 1/25/2017 9:09 PM, Jacopo Mondi wrote:
>> > +&pinctrl {
>> > +   pinctrl-names = "default";
>> > +   pinctrl-0 = <&scif2_pins>;
>> > +
>> > +   scif2_pins: serial2 {
>> > +           /* P3_0 as TxD2; P3_2 as RxD2 */
>> > +           renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>,
>>
>> The comma should be after the vendor prefix ("renesas").
>
> And the "-rz" suffix isn't needed, "renesas,pins" will do.

Then it can just become "pins"? Or not?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds