From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A33C48BF8 for ; Mon, 19 Feb 2024 14:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YV7hYdMxIn2WY5WXnDrJPZ23lH433ZzXE/25hs9EZ3k=; b=cYqZjy2Kd+rSlX LNnm5YCNxGaPBXN/VOFshwTZrbf2fqjHvshjk6frLT2N5nPouYDIDyogsVuffC1d7md4HZG12TsWh HTNEbBmYb40vyTa6rnPPE8Hkke++dKQH3Aam5CrniapSDes//j87D4la849fJOK1hc8Ri6y7U9pU2 lhJoYEM70cb8liGM9IfvqqZ4Ygiovl3MDuyumKAxYDxZBZI+47hqLIVn/Jz74PeGEggoeh9Pmv4Kz ljNqCvxlYFdD+JnJN1gCfe1DRUvOGlO0KtoSuN1n2VebYFVHM0hhRPLHUAJAY8NpaeZ4Xmr1p3CWs Nx5R4C96WONRx18GovMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4rK-0000000Ats2-3B6d; Mon, 19 Feb 2024 14:43:06 +0000 Received: from mail-yb1-f173.google.com ([209.85.219.173]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc4rG-0000000AtqS-3opi for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 14:43:04 +0000 Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dbed179f0faso3772409276.1 for ; Mon, 19 Feb 2024 06:43:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708353781; x=1708958581; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UiRAs6xXCSmrDwwJyZxglQDdKkrV0mexeOrnsuvFlYU=; b=cAG0i8rEIP01b1QqFSjsZHAvJsnaA+OesqabEv4uWOsmrQvFLNXH3A9+cHhCFi74Xa sM/BQtEXiAZ7Okswa+i9j/EX250/7q+Bl9nmLFmCO0h53Wrd209JVYz4W09p2zeJrVrZ j0mT5STcfzddprRJvXpkLaBhBIKluCKAAZZj7+wAF5bLcUSOwSUqEDozI3YHaNRPA88w HABXBID4RD5CzInOnPvBKcUmEVuokZVnjvn4KxFA+81TZoj8ddq5fcpdeYIZGy1MjR/Y K3pjXHyRhAF1GdI9s8hyZ1ZwXNP4l2Q96ZgeRVYc76NclubrrdPTyzJ7z9hz/SKGUmz7 Q8bA== X-Forwarded-Encrypted: i=1; AJvYcCUjjETBeho6uIpELKzjecnE2T89CmEJ8nFBe4UwDIQcQSQ5Bs2eiquE3RINhFaAeoxPNbQspbkPgEumWW1CSheOTVzDAJuMwMsB/TtmM/Wjq2R6JjI= X-Gm-Message-State: AOJu0YxW7b5gRgHO/mmff565TgJxzsvpqwNZ07Ohh70Rx19QMUy71FLZ dJUCg3cpRvtLpm4+uMiMeDaldqkJDQs7At1rChxC/GblxQMfMS7d0VaERMLbly0= X-Google-Smtp-Source: AGHT+IGcxIrV5Pz3nG6Uuct5b9f1EaPPtnFvwQozykoCibWF10yIgIeZqOQPwZVCc6o0EC1e2i2mhg== X-Received: by 2002:a05:6902:1b81:b0:dcb:df38:1c20 with SMTP id ei1-20020a0569021b8100b00dcbdf381c20mr9534514ybb.24.1708353781127; Mon, 19 Feb 2024 06:43:01 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id v14-20020a25fc0e000000b00dc254858399sm1504329ybd.2.2024.02.19.06.43.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 06:43:00 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-6084e809788so3086797b3.1 for ; Mon, 19 Feb 2024 06:43:00 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUVjYS+X8GOKsv4HY5HKnewFB4H8tPLes9ZfuuHLpFwtysYY5K5ZmeQmi+p06wzzdJx6my0wtFC63/X61FwP4lGuMa+Kmo+OdTHP1xPIhrYpICsa/A= X-Received: by 2002:a05:690c:16:b0:608:b86:7c9f with SMTP id bc22-20020a05690c001600b006080b867c9fmr4682001ywb.7.1708353780740; Mon, 19 Feb 2024 06:43:00 -0800 (PST) MIME-Version: 1.0 References: <20240206074552.541154-1-maskray@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 19 Feb 2024 15:42:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" To: Ard Biesheuvel Cc: Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_064302_973491_64F64014 X-CRM114-Status: GOOD ( 33.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJkLAoKT24gTW9uLCBGZWIgMTksIDIwMjQgYXQgMTE6NTfigK9BTSBBcmQgQmllc2hldXZl bCA8YXJkYkBrZXJuZWwub3JnPiB3cm90ZToKPiBPbiBNb24sIDE5IEZlYiAyMDI0IGF0IDExOjU2 LCBBcmQgQmllc2hldXZlbCA8YXJkYkBrZXJuZWwub3JnPiB3cm90ZToKPiA+IE9uIE1vbiwgMTkg RmViIDIwMjQgYXQgMTE6MDMsIEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnRAbGludXgtbTY4ay5v cmc+IHdyb3RlOgo+ID4gPiBPbiBUdWUsIEZlYiA2LCAyMDI0IGF0IDg6NDbigK9BTSBGYW5ncnVp IFNvbmcgPG1hc2tyYXlAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+ID4gVGhlIGdlbmVyaWMgY29u c3RyYWludCAiaSIgc2VlbXMgdG8gYmUgY29waWVkIGZyb20geDg2IG9yIGFybSAoYW5kIHdpdGgK PiA+ID4gPiBhIHJlZHVuZGFudCBnZW5lcmljIG9wZXJhbmQgbW9kaWZpZXIgImMiKS4gSXQgd29y a3Mgd2l0aCAtZm5vLVBJRSBidXQKPiA+ID4gPiBub3Qgd2l0aCAtZlBJRS8tZlBJQyBpbiBHQ0Mn cyBhYXJjaDY0IHBvcnQuCj4gPiA+Cj4gPiA+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCwgd2hpY2gg aXMgbm93IGNvbW1pdCBmOWRhYWIwYWQwMWNmOWQxICgiYXJtNjQ6Cj4gPiA+IGp1bXBfbGFiZWw6 IHVzZSBjb25zdHJhaW50cyAiU2kiIGluc3RlYWQgb2YgImkiIikgaW4gdjYuOC1yYzUuCj4gPiA+ Cj4gPiA+ID4gVGhlIG1hY2hpbmUgY29uc3RyYWludCAiUyIsIHdoaWNoIGRlbm90ZXMgYSBzeW1i b2wgb3IgbGFiZWwgcmVmZXJlbmNlCj4gPiA+ID4gd2l0aCBhIGNvbnN0YW50IG9mZnNldCwgc3Vw cG9ydHMgUElDIGFuZCBoYXMgYmVlbiBhdmFpbGFibGUgaW4gR0NDIHNpbmNlCj4gPiA+ID4gMjAx MiBhbmQgaW4gQ2xhbmcgc2luY2UgNy4wLiBIb3dldmVyLCBDbGFuZyBiZWZvcmUgMTkgZG9lcyBu b3Qgc3VwcG9ydAo+ID4gPiA+ICJTIiBvbiBhIHN5bWJvbCB3aXRoIGEgY29uc3RhbnQgb2Zmc2V0 IFsxXSAoZS5nLgo+ID4gPiA+IGBzdGF0aWNfa2V5X2ZhbHNlKCZuZl9ob29rc19uZWVkZWRbcGZd W2hvb2tdKWAgaW4KPiA+ID4gPiBpbmNsdWRlL2xpbnV4L25ldGZpbHRlci5oKSwgc28gd2UgdXNl ICJpIiBhcyBhIGZhbGxiYWNrLgo+ID4gPgo+ID4gPiBodHRwczovL2djYy5nbnUub3JnL3JlbGVh c2VzLmh0bWwgc2F5cyBnY2MtNSB3YXMgcmVsZWFzZWQgaW4gMjAxNSwKPiA+ID4gaS5lLiBhZnRl ciAyMDEyIC4uLgo+ID4gPgo+ID4gPiA+IFN1Z2dlc3RlZC1ieTogQXJkIEJpZXNoZXV2ZWwgPGFy ZGJAa2VybmVsLm9yZz4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBGYW5ncnVpIFNvbmcgPG1hc2ty YXlAZ29vZ2xlLmNvbT4KPiA+ID4gPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vbGx2bS9sbHZt LXByb2plY3QvcHVsbC84MDI1NSBbMV0KPiA+ID4gPgo+ID4gPiA+IC0tLQo+ID4gPiA+IENoYW5n ZXMgZnJvbQo+ID4gPiA+IGFybTY0OiBqdW1wX2xhYmVsOiB1c2UgY29uc3RyYWludCAiUyIgaW5z dGVhZCBvZiAiaSIgKGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDI0MDEzMTA2NTMyMi4x MTI2ODMxLTEtbWFza3JheUBnb29nbGUuY29tLykKPiA+ID4gPgo+ID4gPiA+ICogVXNlICJTaSIg YXMgQXJkIHN1Z2dlc3RlZCB0byBzdXBwb3J0IENsYW5nPDE5Cj4gPiA+ID4gKiBNYWtlIGJyYW5j aCBhIHNlcGFyYXRlIG9wZXJhbmQKPiA+ID4gPgo+ID4gPiA+IENoYW5nZXMgZnJvbSB2MToKPiA+ ID4gPgo+ID4gPiA+ICogVXNlIGFzbVN5bWJvbGljTmFtZSBmb3IgcmVhZGFiaWxpdHkKPiA+ID4K PiA+ID4gQnV0IGl0IHN0aWxsIGZhaWxzIG9uIGdjYy01Ogo+ID4gPgo+ID4gPiAgICAgYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9qdW1wX2xhYmVsLmg6MjU6MjogZXJyb3I6IGludmFsaWQgJ2FzbSc6 Cj4gPiA+IGludmFsaWQgb3BlcmFuZAo+ID4gPiAgICAgICBhc20gZ290bygKPiA+ID4gICAgICAg Xgo+ID4gPgo+ID4gPiBodHRwOi8va2lzc2tiLmVsbGVybWFuLmlkLmF1L2tpc3NrYi9idWlsZHJl c3VsdC8xNTEyOTI4MS8KPiA+ID4KPiA+Cj4gPiBIb3cgb2RkLiBnb2Rib2x0Lm9yZyBoYXMgNS40 IGFuZCBpdCBzZWVtcyBwZXJmZWN0bHkgaGFwcHkgd2l0aCBpdC4KCj4gaHR0cHM6Ly9nb2Rib2x0 Lm9yZy96L0dUbmYzdlBhVAoKSSBjb3VsZCByZXByb2R1Y2UgdGhlIGlzc3VlIG9uIHY2LjgtcmM1 IHVzaW5nIGFybTY0IGRlZmNvbmZpZwphbmQgeDg2XzY0LWdjYy01LjUuMC1ub2xpYmMtYWFyY2g2 NC1saW51eC50YXIueHogZnJvbQpodHRwczovL2Nkbi5rZXJuZWwub3JnL3B1Yi90b29scy9jcm9z c3Rvb2wvZmlsZXMvYmluL3g4Nl82NC81LjUuMC86CgogICAgSW4gZmlsZSBpbmNsdWRlZCBmcm9t IC4vaW5jbHVkZS9saW51eC9qdW1wX2xhYmVsLmg6MTEyOjAsCiAgICAgICAgICAgICAgICAgICAg IGZyb20gLi9pbmNsdWRlL2xpbnV4L3N0YXRpY19rZXkuaDoxLAogICAgICAgICAgICAgICAgICAg ICBmcm9tIC4vaW5jbHVkZS9saW51eC9rYXNhbi1lbmFibGVkLmg6NSwKICAgICAgICAgICAgICAg ICAgICAgZnJvbSAuL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaDo0MSwKICAgICAgICAg ICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvbGludXgvY2FjaGUuaDo2LAogICAgICAgICAgICAg ICAgICAgICBmcm9tIC4vaW5jbHVkZS9saW51eC9zbGFiLmg6MTUsCiAgICAgICAgICAgICAgICAg ICAgIGZyb20gLi9pbmNsdWRlL2xpbnV4L3Jlc291cmNlX2V4dC5oOjExLAogICAgICAgICAgICAg ICAgICAgICBmcm9tIC4vaW5jbHVkZS9saW51eC9hY3BpLmg6MTMsCiAgICAgICAgICAgICAgICAg ICAgIGZyb20gYXJjaC9hcm02NC9tbS9mYXVsdC5jOjEwOgogICAgYXJjaC9hcm02NC9tbS9mYXVs dC5jOiBJbiBmdW5jdGlvbiAnZG9fcGFnZV9mYXVsdCc6CiAgICAuL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20vanVtcF9sYWJlbC5oOjI1OjI6IGVycm9yOiBpbnZhbGlkICdhc20nOgppbnZhbGlkIG9w ZXJhbmQKICAgICAgYXNtIGdvdG8oCiAgICAgIF4KICAgIC4vYXJjaC9hcm02NC9pbmNsdWRlL2Fz bS9qdW1wX2xhYmVsLmg6MjU6MjogZXJyb3I6IGludmFsaWQgJ2FzbSc6CmludmFsaWQgb3BlcmFu ZAoKVGhlcmUgYXJlIGFsc28gYSBmZXcgd2FybmluZ3MgZHVlIHRvIHVucmVjb2duaXplZCBvcHRp b25zOgoKICAgIGFyY2gvYXJtNjQvbW0vZmF1bHQuYzogQXQgdG9wIGxldmVsOgogICAgY2MxOiB3 YXJuaW5nOiB1bnJlY29nbml6ZWQgY29tbWFuZCBsaW5lIG9wdGlvbiAnLVduby1zaGlmdC1uZWdh dGl2ZS12YWx1ZScKICAgIGNjMTogd2FybmluZzogdW5yZWNvZ25pemVkIGNvbW1hbmQgbGluZSBv cHRpb24gJy1Xbm8tc3RyaW5nb3Atb3ZlcmZsb3cnCgpUaGFua3MhCgpHcntvZXRqZSxlZXRpbmd9 cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLSAKR2VlcnQgVXl0dGVyaG9ldmVu IC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVydEBsaW51eC1tNjhr Lm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNhbCBwZW9wbGUsIEkg Y2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVuIEknbSB0YWxraW5nIHRvIGpvdXJuYWxpc3Rz IEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQuCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B2D25614 for ; Mon, 19 Feb 2024 14:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708353786; cv=none; b=XIrUJIte+DouA1UFUq5z/SdzGVA0NU68RVQ8g6IASil4b45J3DuaIjLGUC9f3iviyJ4BSRjVTtHIlvMtyF/qo/Q1ETi+74ke4e5Md1LBc157Caue1V00UNbs96fD1VEfA3YyyoHo1RBWTlq/ZXZ0S1QVOm6zXh+HzDnPZ/O2n0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708353786; c=relaxed/simple; bh=i7OIpG5Lwqe1/605B4rc6ae/IYBYtY7+WMLTv6YkkX4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Zr4O2M6M8WbW/yoq3C7vA5WVmfSMx6b3w8lEXMM6pfXpom2vRUkyhgKc+001+WGmAUDZ5lSJBBqIFnNuaBCoxpHvZnbc3sbz0Mv7JiFOsPAItVqb+FFFHCb1tyw7WOf6Z/DJYu5Hgef9hN8t5jNatqgoMqMJQT1reLASeuvkMXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-607eefeea90so30074627b3.1 for ; Mon, 19 Feb 2024 06:43:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708353782; x=1708958582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UiRAs6xXCSmrDwwJyZxglQDdKkrV0mexeOrnsuvFlYU=; b=KLou/4zeZHm3GMYhhwp4Z+oEhVaK591HXCi561ATmHKFa4Sd4JR6kng3OX7Z6ef+Fh ykxe9dqTrW+j7i0lcdoZNpr5MBwX4x7yd/qPgx6E6fMSo6sAw9ZmevNLzBvtJZFyns28 Nz5z/KYTvtVxMu+XLAIJBd0s5pNqGW2UKdu4p9rzyU//fI3MPc6Vfp9lTgIexEAV/M8u yIPvNMZlqsxSkRRcQijmj1p0bQb+Rl21LBqb5ZETfejMdv6Hl0fQxrYrDyGLR6D9iRrv NudCeOy5vbjFRSdc8iOIo4X/Ro+zBc7ILpzuC7y4Lb5myh6qcilKi9iCl+tYrXj/CYVr 1aiQ== X-Forwarded-Encrypted: i=1; AJvYcCVBUe+9eaCfXVN/9GatmMSSBLo6d1sMw9LUEj/MOQDmqGMWeAi48wv8gqLkyvfXtf3ZGL2lSFdONZB2b3nVVmVELW0E5Q== X-Gm-Message-State: AOJu0YwHRQbSBqmLD24ies/VC4SgrT1N+4XWwLPV3gIOMrpYkhaFVjTD o3Ld3zhWRhe2xnSQ26eFwB0rPL98aFpSW2zr7cIR/FFEPprclfwyDj9MlQz1Hyg= X-Google-Smtp-Source: AGHT+IH9OxmGKWJk5IY25hq/x53z3OfiYIInejlUJ8KynyAecRQ0z9wGjflQHS7cJKQH3vi5hphIIg== X-Received: by 2002:a05:690c:470d:b0:608:2b1:d6c with SMTP id gz13-20020a05690c470d00b0060802b10d6cmr4498713ywb.19.1708353781832; Mon, 19 Feb 2024 06:43:01 -0800 (PST) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id e185-20020a0dc2c2000000b00607e72b478csm1668629ywd.133.2024.02.19.06.43.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 06:43:01 -0800 (PST) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6084e809788so3086817b3.1 for ; Mon, 19 Feb 2024 06:43:01 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVl+lhmsA0fmD6TNjto/YbWkXVau6AmK52/gt6rEHeuYvByv3juH2GyEDPvG3JftPC9zyRKW/+jcKx6h/EFUF2oO7KPug== X-Received: by 2002:a05:690c:16:b0:608:b86:7c9f with SMTP id bc22-20020a05690c001600b006080b867c9fmr4682001ywb.7.1708353780740; Mon, 19 Feb 2024 06:43:00 -0800 (PST) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240206074552.541154-1-maskray@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 19 Feb 2024 15:42:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" To: Ard Biesheuvel Cc: Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, On Mon, Feb 19, 2024 at 11:57=E2=80=AFAM Ard Biesheuvel w= rote: > On Mon, 19 Feb 2024 at 11:56, Ard Biesheuvel wrote: > > On Mon, 19 Feb 2024 at 11:03, Geert Uytterhoeven = wrote: > > > On Tue, Feb 6, 2024 at 8:46=E2=80=AFAM Fangrui Song wrote: > > > > The generic constraint "i" seems to be copied from x86 or arm (and = with > > > > a redundant generic operand modifier "c"). It works with -fno-PIE b= ut > > > > not with -fPIE/-fPIC in GCC's aarch64 port. > > > > > > Thanks for your patch, which is now commit f9daab0ad01cf9d1 ("arm64: > > > jump_label: use constraints "Si" instead of "i"") in v6.8-rc5. > > > > > > > The machine constraint "S", which denotes a symbol or label referen= ce > > > > with a constant offset, supports PIC and has been available in GCC = since > > > > 2012 and in Clang since 7.0. However, Clang before 19 does not supp= ort > > > > "S" on a symbol with a constant offset [1] (e.g. > > > > `static_key_false(&nf_hooks_needed[pf][hook])` in > > > > include/linux/netfilter.h), so we use "i" as a fallback. > > > > > > https://gcc.gnu.org/releases.html says gcc-5 was released in 2015, > > > i.e. after 2012 ... > > > > > > > Suggested-by: Ard Biesheuvel > > > > Signed-off-by: Fangrui Song > > > > Link: https://github.com/llvm/llvm-project/pull/80255 [1] > > > > > > > > --- > > > > Changes from > > > > arm64: jump_label: use constraint "S" instead of "i" (https://lore.= kernel.org/all/20240131065322.1126831-1-maskray@google.com/) > > > > > > > > * Use "Si" as Ard suggested to support Clang<19 > > > > * Make branch a separate operand > > > > > > > > Changes from v1: > > > > > > > > * Use asmSymbolicName for readability > > > > > > But it still fails on gcc-5: > > > > > > arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': > > > invalid operand > > > asm goto( > > > ^ > > > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/15129281/ > > > > > > > How odd. godbolt.org has 5.4 and it seems perfectly happy with it. > https://godbolt.org/z/GTnf3vPaT I could reproduce the issue on v6.8-rc5 using arm64 defconfig and x86_64-gcc-5.5.0-nolibc-aarch64-linux.tar.xz from https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/5.5.0/: In file included from ./include/linux/jump_label.h:112:0, from ./include/linux/static_key.h:1, from ./include/linux/kasan-enabled.h:5, from ./arch/arm64/include/asm/cache.h:41, from ./include/linux/cache.h:6, from ./include/linux/slab.h:15, from ./include/linux/resource_ext.h:11, from ./include/linux/acpi.h:13, from arch/arm64/mm/fault.c:10: arch/arm64/mm/fault.c: In function 'do_page_fault': ./arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': invalid operand asm goto( ^ ./arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': invalid operand There are also a few warnings due to unrecognized options: arch/arm64/mm/fault.c: At top level: cc1: warning: unrecognized command line option '-Wno-shift-negative-val= ue' cc1: warning: unrecognized command line option '-Wno-stringop-overflow' Thanks! Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds