From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756672AbaDWHUr (ORCPT ); Wed, 23 Apr 2014 03:20:47 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:65470 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbaDWHUo (ORCPT ); Wed, 23 Apr 2014 03:20:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397824031-4892-4-git-send-email-lftan@altera.com> <201404221433.17861.arnd@arndb.de> Date: Wed, 23 Apr 2014 09:20:42 +0200 X-Google-Sender-Auth: 6t0ZRzzsEIcAyzEGxqISsSFJDTs Message-ID: Subject: Re: [PATCH 04/28] nios2: Exception handling From: Geert Uytterhoeven To: Ley Foon Tan Cc: Arnd Bergmann , Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , cltang@codesourcery.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ley, On Wed, Apr 23, 2014 at 4:47 AM, Ley Foon Tan wrote: > On Tue, Apr 22, 2014 at 8:33 PM, Arnd Bergmann wrote: >> On Friday 18 April 2014, Ley Foon Tan wrote: >>> +static const struct file_operations misalign_fops = { >>> + .open = proc_misaligned_open, >>> + .read = seq_read, >>> + .llseek = seq_lseek, >>> + .release = single_release, >>> + .write = proc_misaligned_write, >>> +}; >>> +#endif /* CONFIG_PROC_FS */ >> >> We really shouldn't be doing new architecture specific procfs files >> any more. I suggest you drop this one for now, and add back the >> functionality using perf or ftrace at a later point. > > Okay, will remove this. MIPS and powerpc handle this through debugfs, cfr. arch/mips/kernel/unaligned.c and arch/powerpc/kernel/traps.c. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds