From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 2/2] include: warn for inconsistent endian config definition Date: Fri, 9 Jun 2017 09:05:57 +0200 Message-ID: References: <1496960243-196898-1-git-send-email-babu.moger@oracle.com> <1496960243-196898-3-git-send-email-babu.moger@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Yoshinori Sato , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Al Viro , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Max Filippov , "linux-kernel@vger.kernel.org" , uclinux-h8-devel@lists.sourceforge.jp, "Linux/m68k" , openrisc@lists.librecores.org, Parisc List , sparclinux To: Babu Moger Return-path: In-Reply-To: <1496960243-196898-3-git-send-email-babu.moger@oracle.com> List-ID: List-Id: linux-parisc.vger.kernel.org On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger wrote: > Display warning if CPU_BIG_ENDIAN is not defined on big endian > architecture and also warn if it defined on little endian architectures. > > We have seen some generic code(for example code include/asm-generic/qrwlock.h) > uses CONFIG_CPU_BIG_ENDIAN to decide the endianess. That example is IMHO the least harmful, as qrwlock must be selected explicitly by the architecture. The uses in drivers/of/base.c drivers/of/fdt.c drivers/tty/serial/earlycon.c drivers/tty/serial/serial_core.c are more dangerous, and may have bitten people already. In addition, people may have worked around them in DT, so this series may actually introduce regressions. > Here is the original discussion > http://www.spinics.net/lists/devicetree/msg178101.html > > Signed-off-by: Babu Moger > Suggested-by: Arnd Bergmann Hmm, the link above refers to a mail from me? ;-) Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 09 Jun 2017 07:05:57 +0000 Subject: Re: [PATCH 2/2] include: warn for inconsistent endian config definition Message-Id: List-Id: References: <1496960243-196898-1-git-send-email-babu.moger@oracle.com> <1496960243-196898-3-git-send-email-babu.moger@oracle.com> In-Reply-To: <1496960243-196898-3-git-send-email-babu.moger@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Babu Moger Cc: Yoshinori Sato , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Al Viro , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Max Filippov , "linux-kernel@vger.kernel.org" , uclinux-h8-devel@lists.sourceforge.jp, Linux/m68k , openrisc@lists.librecores.org, Parisc List , sparclinux On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger wrote: > Display warning if CPU_BIG_ENDIAN is not defined on big endian > architecture and also warn if it defined on little endian architectures. > > We have seen some generic code(for example code include/asm-generic/qrwlock.h) > uses CONFIG_CPU_BIG_ENDIAN to decide the endianess. That example is IMHO the least harmful, as qrwlock must be selected explicitly by the architecture. The uses in drivers/of/base.c drivers/of/fdt.c drivers/tty/serial/earlycon.c drivers/tty/serial/serial_core.c are more dangerous, and may have bitten people already. In addition, people may have worked around them in DT, so this series may actually introduce regressions. > Here is the original discussion > http://www.spinics.net/lists/devicetree/msg178101.html > > Signed-off-by: Babu Moger > Suggested-by: Arnd Bergmann Hmm, the link above refers to a mail from me? ;-) Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds