From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81ADC433FE for ; Mon, 13 Sep 2021 08:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A07C6603E9 for ; Mon, 13 Sep 2021 08:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237846AbhIMIGk (ORCPT ); Mon, 13 Sep 2021 04:06:40 -0400 Received: from mail-vs1-f47.google.com ([209.85.217.47]:37610 "EHLO mail-vs1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237797AbhIMIGi (ORCPT ); Mon, 13 Sep 2021 04:06:38 -0400 Received: by mail-vs1-f47.google.com with SMTP id i23so7629360vsj.4; Mon, 13 Sep 2021 01:05:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hIy/WF41WnhInRxQvOeLA91NgtT/ad5oPS0o2VKCwNg=; b=H1wPdid9exSg992pPXhiMALn/wP/WluGxrpodaX1dXaLk5agS9mbY2yNT/LkDIvVP/ UZq0eLqXKW7eiJTLtNyHs2ag19/bQH+yVAxbR29EcWipIPoPzZG9ElYun+7fXCnXnwX5 IGPlyOI1hteTd1Pdfrzj0zi1d8CVrpkEIIcydKhybo/8re/g1YBa1SZegn9cDo3pcGb6 AVzZZFG749rmuw0sgd3vELdS7+mOoNgCQA0dPXnvsC6y1CtZEhCnYgi235Wka8tiOG7a VEgvxC3ecjIHdzth723jUqYenqYkfyv1FM9ow6wP+cSm5Yn66Sb0ZpZfy1gQyjdErZxb Rsqg== X-Gm-Message-State: AOAM530VG9N7DxeRHM1vO5J8LwqJ9TG+eb6JgvYQbfSapGTk4gsb3BEi pWWWWr86mWYNoTuhl4l6qTo2eWsii/w249BGYUiJYdoi7/w= X-Google-Smtp-Source: ABdhPJy5qS7cAHC3Wj9WuuKOmYXH4sq8/3ktX7gWNSl8zk/qKzaCAAZqM9h3ouNfCut0fUdqY/dAAiCGCBBDbPtKIvo= X-Received: by 2002:a05:6102:3112:: with SMTP id e18mr2487715vsh.50.1631520322815; Mon, 13 Sep 2021 01:05:22 -0700 (PDT) MIME-Version: 1.0 References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-8-maz@kernel.org> <875yv8d91b.wl-maz@kernel.org> <874kaqdi2z.wl-maz@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 13 Sep 2021 10:05:11 +0200 Message-ID: Subject: Re: [PATCH v2 07/17] irqchip/gic: Atomically update affinity To: Magnus Damm Cc: Marc Zyngier , Russell King , Linux ARM , Linux Kernel Mailing List , Will Deacon , Catalin Marinas , Thomas Gleixner , Jason Cooper , Sumit Garg , Valentin Schneider , Florian Fainelli , Gregory Clement , Andrew Lunn , Android Kernel Team , stable , Magnus Damm , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Magnus, On Sun, Sep 12, 2021 at 7:40 AM Magnus Damm wrote: > On Sun, Sep 12, 2021 at 4:32 AM Marc Zyngier wrote: > > On Sat, 11 Sep 2021 03:49:20 +0100, > > Magnus Damm wrote: > > > On Fri, Sep 10, 2021 at 10:19 PM Geert Uytterhoeven > > > wrote: > > > > On Fri, Sep 10, 2021 at 12:23 PM Marc Zyngier wrote: > > > > > On Thu, 09 Sep 2021 16:22:01 +0100, > > > > > Geert Uytterhoeven wrote: > > > > GIC: enabling workaround for broken byte access > > > > > > Indeed, byte access is unsupported according to the EMEV2 documentation. > > > > > > The EMEV2 documentation R19UH0036EJ0600 Chapter 7 Interrupt Control on > > > page 97 says: > > > "Interrupt registers can be accessed via the APB bus, in 32-bit units" > > > "For details about register functions, see ARM Generic Interrupt > > > Controller Architecture Specification Architecture version 1.0" > > > The file "R19UH0036EJ0600_1Chip.pdf" is the 6th edition version > > > published in 2010 and is not marked as confidential. > > > > This is as bad as it gets. Do you know if any other Renesas platform > > is affected by the same issue? > > Next time we have a beer together I would be happy to show you some > legacy interrupt controller code. =) > > EMEV2 and the Emma Mobile product line came from the NEC Electronics > side that got merged into Renesas Electronics in 2010. Historically > NEC Electronics mainly used MIPS I've been told, and the Emma Mobile > SoCs were one of the earlier Cortex-A9 adopters. That might have > something to do with the rather loose interpretation of the spec. Indeed. I used to work on products using EMMA1 and EMMA2, and they were MIPS-based (vr4120A for EMMA2, IIRC). Later variants (EMMA2H and EMMA3?) did include a small ARM core for standby control. > Renesas SoCs from a similar era: > AP4 (sh7372) AP4EVB (Cortex-A8 + INTCA/INTCS) This is no longer supported upstream (and not affected, as no GIC). > R-Mobile A1 (r8a7740) Armadillo-800-EVA (Cortex-A9 + INTCA/INTCS) R-Mobile A1 has GIC (PL390), too, and is not affected. > R-Car M1A (r8a7778) Bock-W (Cortex-A9 + GIC) > R-Car H1 (r8a7779) Marzen (4 x Cortex-A9 + GIC) > Emma Mobile EMEV2 KZM9D (2 x Cortex-A9 + GIC) > SH-Mobile AG5 (sh73a0) KZM9G (2 x Cortex-A9 + GIC) All of these (except for EMEV2) are fine, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FA9C433EF for ; Mon, 13 Sep 2021 08:07:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FE3160FBF for ; Mon, 13 Sep 2021 08:07:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0FE3160FBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d8K2nCP047L3IvBHITM00ulkEtKoI23SXv0xqACO31k=; b=Vgfjc+gSIo9p3b csP1DqU6f2/4PqlQlbrscr1Z00pYati/0HRvCq87nnCX/AhJcmflq0ZUXMlW1Th41RJk3GNs3ypQ0 PtZpjv39m6Wn1uDZk/eKe2jqUQbi5RBc8cpeNl72dMGvg0Bgvht+UrKnmi4l9ICgwjAiZ7Y3SQgyi hW4QFdM9UQChJL6LHKprtmmEpFTKJMNznOjPEyoDgvFi/CG1LnQo52MiBQbRR54RwGdx5DeHZQuGB uKWw1DbbTZ8g5rT3RKqvet1t8KGwSN3L+2Il7nhq8/QUnjXEvNvG5D8oXnKakowfZ4F5hSoKfR7iv iLrKQw9k78S0MQZnf56A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPgy0-000d4o-MK; Mon, 13 Sep 2021 08:05:28 +0000 Received: from mail-vs1-f49.google.com ([209.85.217.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPgxw-000d3i-Ba for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 08:05:25 +0000 Received: by mail-vs1-f49.google.com with SMTP id s15so7597259vst.13 for ; Mon, 13 Sep 2021 01:05:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hIy/WF41WnhInRxQvOeLA91NgtT/ad5oPS0o2VKCwNg=; b=j3MAj7y0D1Vhy6PW8MhBv4mofXZ+c++y4iHma2oP0rAg7TJAF1Yhg29v6UKa4qAPqo 4ZaWyo4kZg1PAN1l3qW1iPul0inEOpBzYIzbFqNbXeF9Timc0uQRCAGc1fkOgHVU6NeF zKThZTGs6Z6//Y7MlllXXLsgnWxz6jbAAgFW+YO4HEpL9kS9TeL+/lTTzyEpMp+AQibM s8fu/0oUEXfxyHFHv5H3JghmUowDN17va12Ih1WOMJUNc16P4Phs2XzBe1P4hPPgSvdC ePNe8yTGTgSd0dMY4hlg+z/suaYA9+MSddZg6aJdiJlTC2HFPmhJ0p5al0dSAPu9R0JO 2CRQ== X-Gm-Message-State: AOAM5312dpojs34VgsYSnPuTvAjxDNeU9jj1tDEnJdSt37o49YPJGIjW paY+TfaEZXr8OFb9HhiXQfxQ7nXU6a9ivKDOnqU= X-Google-Smtp-Source: ABdhPJy5qS7cAHC3Wj9WuuKOmYXH4sq8/3ktX7gWNSl8zk/qKzaCAAZqM9h3ouNfCut0fUdqY/dAAiCGCBBDbPtKIvo= X-Received: by 2002:a05:6102:3112:: with SMTP id e18mr2487715vsh.50.1631520322815; Mon, 13 Sep 2021 01:05:22 -0700 (PDT) MIME-Version: 1.0 References: <20200624195811.435857-1-maz@kernel.org> <20200624195811.435857-8-maz@kernel.org> <875yv8d91b.wl-maz@kernel.org> <874kaqdi2z.wl-maz@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 13 Sep 2021 10:05:11 +0200 Message-ID: Subject: Re: [PATCH v2 07/17] irqchip/gic: Atomically update affinity To: Magnus Damm Cc: Marc Zyngier , Russell King , Linux ARM , Linux Kernel Mailing List , Will Deacon , Catalin Marinas , Thomas Gleixner , Jason Cooper , Sumit Garg , Valentin Schneider , Florian Fainelli , Gregory Clement , Andrew Lunn , Android Kernel Team , stable , Magnus Damm , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Linux-Renesas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_010524_455733_21EC0C85 X-CRM114-Status: GOOD ( 34.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Magnus, On Sun, Sep 12, 2021 at 7:40 AM Magnus Damm wrote: > On Sun, Sep 12, 2021 at 4:32 AM Marc Zyngier wrote: > > On Sat, 11 Sep 2021 03:49:20 +0100, > > Magnus Damm wrote: > > > On Fri, Sep 10, 2021 at 10:19 PM Geert Uytterhoeven > > > wrote: > > > > On Fri, Sep 10, 2021 at 12:23 PM Marc Zyngier wrote: > > > > > On Thu, 09 Sep 2021 16:22:01 +0100, > > > > > Geert Uytterhoeven wrote: > > > > GIC: enabling workaround for broken byte access > > > > > > Indeed, byte access is unsupported according to the EMEV2 documentation. > > > > > > The EMEV2 documentation R19UH0036EJ0600 Chapter 7 Interrupt Control on > > > page 97 says: > > > "Interrupt registers can be accessed via the APB bus, in 32-bit units" > > > "For details about register functions, see ARM Generic Interrupt > > > Controller Architecture Specification Architecture version 1.0" > > > The file "R19UH0036EJ0600_1Chip.pdf" is the 6th edition version > > > published in 2010 and is not marked as confidential. > > > > This is as bad as it gets. Do you know if any other Renesas platform > > is affected by the same issue? > > Next time we have a beer together I would be happy to show you some > legacy interrupt controller code. =) > > EMEV2 and the Emma Mobile product line came from the NEC Electronics > side that got merged into Renesas Electronics in 2010. Historically > NEC Electronics mainly used MIPS I've been told, and the Emma Mobile > SoCs were one of the earlier Cortex-A9 adopters. That might have > something to do with the rather loose interpretation of the spec. Indeed. I used to work on products using EMMA1 and EMMA2, and they were MIPS-based (vr4120A for EMMA2, IIRC). Later variants (EMMA2H and EMMA3?) did include a small ARM core for standby control. > Renesas SoCs from a similar era: > AP4 (sh7372) AP4EVB (Cortex-A8 + INTCA/INTCS) This is no longer supported upstream (and not affected, as no GIC). > R-Mobile A1 (r8a7740) Armadillo-800-EVA (Cortex-A9 + INTCA/INTCS) R-Mobile A1 has GIC (PL390), too, and is not affected. > R-Car M1A (r8a7778) Bock-W (Cortex-A9 + GIC) > R-Car H1 (r8a7779) Marzen (4 x Cortex-A9 + GIC) > Emma Mobile EMEV2 KZM9D (2 x Cortex-A9 + GIC) > SH-Mobile AG5 (sh73a0) KZM9G (2 x Cortex-A9 + GIC) All of these (except for EMEV2) are fine, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel