* [v3,1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma
@ 2018-06-12 17:28 Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-06-12 17:28 UTC (permalink / raw)
To: Angelo Dureghello; +Cc: dmaengine, vkoul, Linux/m68k
Hi Angelo,
On Tue, Jun 12, 2018 at 6:35 PM Angelo Dureghello <angelo@sysam.it> wrote:
> This patch adds Kconfig and makefile changes to add ColdFire
> mcf5441x family edma support.
> A new fsl-edma-common module has been added, to collect common
> code to fsl-edma.
>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
> Changes for v2:
> - patch splitted into 4
> - add fsl-edma-common
>
> Changes for v3:
> - remove Kconfig FSL_EDMA_COMMON and set fsl-edma-common.o as
> additional object entry where needed.
Thanks for the update!
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -220,6 +220,7 @@ config FSL_EDMA
> depends on OF
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> + select FSL_EDMA_COMMON
Not needed (FSL_EDMA_COMMON is gone).
> help
> Support the Freescale eDMA engine with programmable channel
> multiplexing capability for DMA request sources(slot).
> @@ -327,6 +328,18 @@ config LPC18XX_DMAMUX
> Enable support for DMA on NXP LPC18xx/43xx platforms
> with PL080 and multiplexed DMA request lines.
>
> +config MCF_EDMA
> + tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
> + depends on M5441x
> + select DMA_ENGINE
> + select DMA_VIRTUAL_CHANNELS
> + select FSL_EDMA_COMMON
Not needed (FSL_EDMA_COMMON is gone).
> + help
> + Support the Freescale ColdFire eDMA engine, 64-channel
> + implementation that performs complex data transfers with
> + minimal intervention from a host processor.
> + This module can be found on Freescale ColdFire mcf5441x SoCs.
> +
> config MMP_PDMA
> bool "MMP PDMA support"
> depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
Gr{oetje,eeting}s,
Geert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v3,1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma
@ 2018-06-14 8:36 Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2018-06-14 8:36 UTC (permalink / raw)
To: Angelo Dureghello; +Cc: dmaengine, linux-m68k
On 12-06-18, 18:34, Angelo Dureghello wrote:
> This patch adds Kconfig and makefile changes to add ColdFire
> mcf5441x family edma support.
> A new fsl-edma-common module has been added, to collect common
> code to fsl-edma.
I think the way you send patch series has some issue and threading is
broken, so the patches are all over my inbox.
Can you please repost with threading fixed
>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
> Changes for v2:
> - patch splitted into 4
> - add fsl-edma-common
>
> Changes for v3:
> - remove Kconfig FSL_EDMA_COMMON and set fsl-edma-common.o as
> additional object entry where needed.
> ---
> drivers/dma/Kconfig | 13 +++++++++++++
> drivers/dma/Makefile | 3 ++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 6d61cd023633..c7d45e69f021 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -220,6 +220,7 @@ config FSL_EDMA
> depends on OF
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> + select FSL_EDMA_COMMON
> help
> Support the Freescale eDMA engine with programmable channel
> multiplexing capability for DMA request sources(slot).
> @@ -327,6 +328,18 @@ config LPC18XX_DMAMUX
> Enable support for DMA on NXP LPC18xx/43xx platforms
> with PL080 and multiplexed DMA request lines.
>
> +config MCF_EDMA
> + tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
> + depends on M5441x
> + select DMA_ENGINE
> + select DMA_VIRTUAL_CHANNELS
> + select FSL_EDMA_COMMON
> + help
> + Support the Freescale ColdFire eDMA engine, 64-channel
> + implementation that performs complex data transfers with
> + minimal intervention from a host processor.
> + This module can be found on Freescale ColdFire mcf5441x SoCs.
> +
> config MMP_PDMA
> bool "MMP PDMA support"
> depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index 0f62a4d49aab..cce5e3400580 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -32,7 +32,8 @@ obj-$(CONFIG_DW_AXI_DMAC) += dw-axi-dmac/
> obj-$(CONFIG_DW_DMAC_CORE) += dw/
> obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
> obj-$(CONFIG_FSL_DMA) += fsldma.o
> -obj-$(CONFIG_FSL_EDMA) += fsl-edma.o
> +obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
> +obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o
> obj-$(CONFIG_FSL_RAID) += fsl_raid.o
> obj-$(CONFIG_HSU_DMA) += hsu/
> obj-$(CONFIG_IMG_MDC_DMA) += img-mdc-dma.o
> --
> 2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v3,1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma
@ 2018-06-12 17:30 Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-06-12 17:30 UTC (permalink / raw)
To: Angelo Dureghello; +Cc: dmaengine, vkoul, Linux/m68k
Hi Angelo,
On Tue, Jun 12, 2018 at 6:35 PM Angelo Dureghello <angelo@sysam.it> wrote:
> This patch adds Kconfig and makefile changes to add ColdFire
> mcf5441x family edma support.
> A new fsl-edma-common module has been added, to collect common
> code to fsl-edma.
>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
> Changes for v2:
> - patch splitted into 4
> - add fsl-edma-common
>
> Changes for v3:
> - remove Kconfig FSL_EDMA_COMMON and set fsl-edma-common.o as
> additional object entry where needed.
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -327,6 +328,18 @@ config LPC18XX_DMAMUX
> Enable support for DMA on NXP LPC18xx/43xx platforms
> with PL080 and multiplexed DMA request lines.
>
> +config MCF_EDMA
> + tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
> + depends on M5441x
> + select DMA_ENGINE
> + select DMA_VIRTUAL_CHANNELS
> + select FSL_EDMA_COMMON
> + help
> + Support the Freescale ColdFire eDMA engine, 64-channel
> + implementation that performs complex data transfers with
> + minimal intervention from a host processor.
> + This module can be found on Freescale ColdFire mcf5441x SoCs.
I think MCF_EDMA should be added in patch 4/4 only.
> +
> config MMP_PDMA
> bool "MMP PDMA support"
> depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index 0f62a4d49aab..cce5e3400580 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -32,7 +32,8 @@ obj-$(CONFIG_DW_AXI_DMAC) += dw-axi-dmac/
> obj-$(CONFIG_DW_DMAC_CORE) += dw/
> obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
> obj-$(CONFIG_FSL_DMA) += fsldma.o
> -obj-$(CONFIG_FSL_EDMA) += fsl-edma.o
> +obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
> +obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o
Same for the line above: without patch 4/4, it won't build.
Gr{oetje,eeting}s,
Geert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v3,1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma
@ 2018-06-12 16:34 Angelo Dureghello
0 siblings, 0 replies; 4+ messages in thread
From: Angelo Dureghello @ 2018-06-12 16:34 UTC (permalink / raw)
To: dmaengine, vkoul; +Cc: linux-m68k
This patch adds Kconfig and makefile changes to add ColdFire
mcf5441x family edma support.
A new fsl-edma-common module has been added, to collect common
code to fsl-edma.
Signed-off-by: Angelo Dureghello <angelo@sysam.it>
---
Changes for v2:
- patch splitted into 4
- add fsl-edma-common
Changes for v3:
- remove Kconfig FSL_EDMA_COMMON and set fsl-edma-common.o as
additional object entry where needed.
---
drivers/dma/Kconfig | 13 +++++++++++++
drivers/dma/Makefile | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 6d61cd023633..c7d45e69f021 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -220,6 +220,7 @@ config FSL_EDMA
depends on OF
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
+ select FSL_EDMA_COMMON
help
Support the Freescale eDMA engine with programmable channel
multiplexing capability for DMA request sources(slot).
@@ -327,6 +328,18 @@ config LPC18XX_DMAMUX
Enable support for DMA on NXP LPC18xx/43xx platforms
with PL080 and multiplexed DMA request lines.
+config MCF_EDMA
+ tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
+ depends on M5441x
+ select DMA_ENGINE
+ select DMA_VIRTUAL_CHANNELS
+ select FSL_EDMA_COMMON
+ help
+ Support the Freescale ColdFire eDMA engine, 64-channel
+ implementation that performs complex data transfers with
+ minimal intervention from a host processor.
+ This module can be found on Freescale ColdFire mcf5441x SoCs.
+
config MMP_PDMA
bool "MMP PDMA support"
depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index 0f62a4d49aab..cce5e3400580 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -32,7 +32,8 @@ obj-$(CONFIG_DW_AXI_DMAC) += dw-axi-dmac/
obj-$(CONFIG_DW_DMAC_CORE) += dw/
obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
obj-$(CONFIG_FSL_DMA) += fsldma.o
-obj-$(CONFIG_FSL_EDMA) += fsl-edma.o
+obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
+obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o
obj-$(CONFIG_FSL_RAID) += fsl_raid.o
obj-$(CONFIG_HSU_DMA) += hsu/
obj-$(CONFIG_IMG_MDC_DMA) += img-mdc-dma.o
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-14 8:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 17:28 [v3,1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 8:36 Vinod Koul
2018-06-12 17:30 Geert Uytterhoeven
2018-06-12 16:34 Angelo Dureghello
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.