From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 793D6C6FA8E for ; Thu, 2 Mar 2023 19:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dTyoJq9ReOB6vcWI12JMWpEA8BRGWHT79IgX2ijrnGo=; b=ox30eImHZ3okmb kNYvgYLx7iCsRvOPt2pjnuM1SQ616uMXwGm4QPAGrcHpncdwQtbTwEhxoXguLwL08FJRnlXFwFBKE 8Y/eRzRroUKmSkfEWzy2Viv5+q9Ms/nprbUdzfCQSMPzwQu4Nu90SXi1Kar8Pju+XBDzYzmJiSins S+x2XhYODakUYYtPtrhsPoPTmWkVlKgSWp13aF0aYHhN2pKYmYTevwOOUxHQhBXBIw1gDDegx9Eke fDnrjj5Lz7g90FncMpgbudD8Oi5s0f4vsFCj/1moRzta7SqbveuIEBuQ0lBgfNiuJxu9MO8Uy47yr JVovQMUx9kUQyI7SCclQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXou7-003Bhl-47; Thu, 02 Mar 2023 19:47:51 +0000 Received: from mail-qt1-f180.google.com ([209.85.160.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXou3-003BgJ-3p for linux-um@lists.infradead.org; Thu, 02 Mar 2023 19:47:49 +0000 Received: by mail-qt1-f180.google.com with SMTP id h19so498520qtk.7 for ; Thu, 02 Mar 2023 11:47:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f95O1774ZoBykD/usZaosY+efoKseNjJy4cpA8XSzCQ=; b=C9D2qc1ccD0RS0CiKxS4lJX6YKfEgASXuXwuhY0anhyTwN+QPpr5QMlBRcrC6G13ip TRSIbBIJvnW+b6tmRzmvvU/B2mOHPz30L4PNW/bqYT4F4KXRUG0vsKftrDdL83+gWRfT 59InLviqDKYYCPWQFUVDfLvfeH7LILjWXEfPh8Z314PEpwW3FtGGqYGLG0d7L10jVt3B +zNLfOxu6kI00xBfaI8W0CG3HApUc9Ty1ukG1hhUQzOME6pqsdJLWuzYEDn/0eMr95tz 0uIaJL5owotOQxYPLhQyGuVnI1u+bQY0okr+wlytWF3CbMrSOlmIFlLesUKqut9NKUOq KuVg== X-Gm-Message-State: AO0yUKWLeHCBwp5/mo8vVUkGejv/+hfovUEjyX3rcXrx34HGTJYZnzKS 76i9SC6vISrSfrQFOCeRi7ZXbY4842KuiA== X-Google-Smtp-Source: AK7set+0MgShyrSZdki4WHjLlsOEY36MtEIQqkr2bveMOHG/BS8BCsb01fEoODCDMKUjLTg5X4hYNg== X-Received: by 2002:ac8:4e4a:0:b0:3b8:6c4d:488a with SMTP id e10-20020ac84e4a000000b003b86c4d488amr17560435qtw.37.1677786464758; Thu, 02 Mar 2023 11:47:44 -0800 (PST) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com. [209.85.128.182]) by smtp.gmail.com with ESMTPSA id x13-20020ac8120d000000b003bffe7fdc38sm323853qti.9.2023.03.02.11.47.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 11:47:44 -0800 (PST) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-53852143afcso2179627b3.3 for ; Thu, 02 Mar 2023 11:47:43 -0800 (PST) X-Received: by 2002:a81:ad1b:0:b0:52f:1c23:ef1 with SMTP id l27-20020a81ad1b000000b0052f1c230ef1mr7066170ywh.5.1677786463634; Thu, 02 Mar 2023 11:47:43 -0800 (PST) MIME-Version: 1.0 References: <20230302013822.1808711-1-sboyd@kernel.org> <3759b28cca7ab751296d4dd83f2dcc51.sboyd@kernel.org> In-Reply-To: <3759b28cca7ab751296d4dd83f2dcc51.sboyd@kernel.org> From: Geert Uytterhoeven Date: Thu, 2 Mar 2023 20:47:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data To: Stephen Boyd Cc: David Gow , Rob Herring , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Brendan Higgins , Greg Kroah-Hartman , "Rafael J . Wysocki" , Richard Weinberger , Anton Ivanov , Johannes Berg , Vincent Whitchurch , Frank Rowand , Christian Marangi , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-um@lists.infradead.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230302_114747_202557_26FC1DCF X-CRM114-Status: GOOD ( 56.58 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org SGkgU3RlcGhlbiwKCk9uIFRodSwgTWFyIDIsIDIwMjMgYXQgODoyOOKAr1BNIFN0ZXBoZW4gQm95 ZCA8c2JveWRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gUXVvdGluZyBSb2IgSGVycmluZyAoMjAyMy0w My0wMiAwOTozMjowOSkKPiA+IE9uIFRodSwgTWFyIDIsIDIwMjMgYXQgMjoxNOKAr0FNIERhdmlk IEdvdyA8ZGF2aWRnb3dAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+IE9uIFRodSwgMiBNYXIgMjAy MyBhdCAwOTozOCwgU3RlcGhlbiBCb3lkIDxzYm95ZEBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4g PiBUaGlzIHBhdGNoIHNlcmllcyBhZGRzIHVuaXQgdGVzdHMgZm9yIHRoZSBjbGsgZml4ZWQgcmF0 ZSBiYXNpYyB0eXBlIGFuZAo+ID4gPiA+IHRoZSBjbGsgcmVnaXN0cmF0aW9uIGZ1bmN0aW9ucyB0 aGF0IHVzZSBzdHJ1Y3QgY2xrX3BhcmVudF9kYXRhLiBUbyBnZXQKPiA+ID4gPiB0aGVyZSwgd2Ug YWRkIHN1cHBvcnQgZm9yIGxvYWRpbmcgYSBEVEIgaW50byB0aGUgVU1MIGtlcm5lbCB0aGF0J3MK PiA+ID4gPiBydW5uaW5nIHRoZSB1bml0IHRlc3RzIGFsb25nIHdpdGggcHJvYmluZyBwbGF0Zm9y bSBkcml2ZXJzIHRvIGJpbmQgdG8KPiA+ID4gPiBkZXZpY2Ugbm9kZXMgc3BlY2lmaWVkIGluIERU Lgo+ID4gPiA+Cj4gPiA+ID4gV2l0aCB0aGlzIHNlcmllcywgd2UncmUgYWJsZSB0byBleGVyY2lz ZSBzb21lIG9mIHRoZSBjb2RlIGluIHRoZSBjb21tb24KPiA+ID4gPiBjbGsgZnJhbWV3b3JrIHRo YXQgdXNlcyBkZXZpY2V0cmVlIGxvb2t1cHMgdG8gZmluZCBwYXJlbnRzIGFuZCB0aGUgZml4ZWQK PiA+ID4gPiByYXRlIGNsayBjb2RlIHRoYXQgc2NhbnMgZGV2aWNldHJlZSBkaXJlY3RseSBhbmQg Y3JlYXRlcyBjbGtzLiBQbGVhc2UKPiA+ID4gPiByZXZpZXcuCj4gPiA+ID4KPiA+ID4KPiA+ID4g VGhhbmtzIFN0ZXBoZW4gLS0gdGhpcyBpcyByZWFsbHkgbmVhdCEKPiA+ID4KPiA+ID4gVGhpcyB3 b3JrcyB3ZWxsIGhlcmUsIGFuZCBJIGxvdmUgYWxsIG9mIHRoZSB0ZXN0cyBmb3IgdGhlCj4gPiA+ IEtVbml0L2RldmljZS10cmVlIGludGVncmF0aW9uIGFzIHdlbGwuCj4gPiA+Cj4gPiA+IEknbSBz dGlsbCBsb29raW5nIHRocm91Z2ggdGhlIGRldGFpbHMgb2YgaXQgKGFsYXMsIEkndmUgbW9zdGx5 IGxpdmVkCj4gPiA+IGluIHg4Ni1sYW5kLCBzbyBteSBkZXZpY2UtdHJlZSBrbm93bGVkZ2UgaXMs IHVoLCBzcG90dHkgdG8gc2F5IHRoZQo+ID4gPiBsZWFzdCksIGJ1dCBhcGFydCBmcm9tIHBvc3Np Ymx5IHJlbmFtaW5nIHNvbWUgdGhpbmdzIG9yIHNpbWlsYXJseQo+ID4gPiBtaW5vciB0d2Vha3Ms IEkndmUgbm90IGdvdCBhbnkgcmVhbCBzdWdnZXN0aW9ucyB0aHVzIGZhci4KPiA+ID4KPiA+ID4g SSBkbyB3b25kZXIgd2hldGhlciB3ZSdsbCB3YW50LCBvbiB0aGUgS1VuaXQgc2lkZSwgdG8gaGF2 ZSBzb21lIHdheSBvZgo+ID4gPiBzdXBwb3J0aW5nIEtVbml0IGRldmljZSB0cmVlcyBvbiBub24t VU1MIGFyY2hpdGVjY3R1cmVzIChlLmcuLCBpZiB3ZQo+ID4gPiBuZWVkIHRvIHRlc3Qgc29tZXRo aW5nIGFyY2hpdGVjdHVyZS1zcGVjaWZpYywgb3Igb24gYSBiaWctZW5kaWFuCj4gPiA+IHBsYXRm b3JtLCBldGMpLCBidXQgSSB0aGluayB0aGF0J3MgYSBxdWVzdGlvbiBmb3IgdGhlIGZ1dHVyZSwg cmF0aGVyCj4gPiA+IHRoYW4gc29tZXRoaW5nIHRoYXQgYWZmZWN0cyB0aGlzIHNlcmllcy4KPiA+ Cj4gPiBJJ2xsIHNheSB0aGF0J3MgYSByZXF1aXJlbWVudC4gV2Ugc2hvdWxkIGJlIGFibGUgdG8g c3RydWN0dXJlIHRoZQo+ID4gdGVzdHMgdG8gbm90IGludGVyZmVyZSB3aXRoIHRoZSBydW5uaW5n IHN5c3RlbSdzIERULiBUaGUgRFQgdW5pdHRlc3QKPiA+IGRvZXMgdGhhdC4KPgo+IFRoYXQgY291 bGQgYmUgYW5vdGhlciBjaG9pY2UgaW4gdGhlIHVuaXQgdGVzdCBjaG9pY2UgbWVudS4KPiBDT05G SUdfT0ZfS1VOSVRfTk9UX1VNTCB0aGF0IGluamVjdHMgc29tZSBidWlsdC1pbiBEVEIgb3Zlcmxh eSBvbiBhbgo+IGFyY2hpdGVjdHVyZSB0aGF0IHdhbnRzIHRvIHJ1biB0ZXN0cy4KCkFzIGxvbmcg YXMgeW91IHVzZSBjb21wYXRpYmxlIHZhbHVlcyB0aGF0IGRvbid0IGV4aXN0IGVsc2V3aGVyZSwK YW5kIGRvbid0IG92ZXJ3cml0ZSBhbnl0aGluZywgeW91IGNhbiBsb2FkIHlvdXIga3VuaXQgdGVz dCBvdmVybGF5cwpvbiBhbnkgcnVubmluZyBzeXN0ZW0gdGhhdCBoYXMgRFQgc3VwcG9ydC4KCj4g PiBBcyBhIHNpZGUgdG9waWMsIElzIGFueW9uZSBsb29raW5nIGF0IGdldHRpbmcgVU1MIHRvIHdv cmsgb24gYXJtNjQ/Cj4gPiBJdCdzIHN1cnByaXNpbmcgaG93IG11Y2ggeDg2IHN0dWZmIHRoZXJl IGlzIHdoaWNoIGlzIEkgZ3Vlc3Mgb25lCj4gPiByZWFzb24gaXQgaGFzbid0IGhhcHBlbmVkLgo+ Cj4gSSd2ZSBubyBpZGVhIGJ1dCBpdCB3b3VsZCBiZSBuaWNlIGluZGVlZC4KCkkgYmVsaWV2ZSB0 aGF0J3Mgbm9uLXRyaXZpYWwuIEF0IGxlYXN0IGZvciBhcm0zMiAoSSBkaWRuJ3QgaGF2ZSBhbnkg YXJtNjQKc3lzdGVtcyBsYXN0IHRpbWUgSSBhc2tlZCB0aGUgZXhwZXJ0cykuCgo+ID4gPiBTaW1p bGFybHksIEkgd29uZGVyIGlmIHRoZXJlJ3Mgc29tZXRoaW5nIHdlIGNvdWxkIGRvIHdpdGggZGV2 aWNlIHRyZWUKPiA+ID4gb3ZlcmxheXMsIGluIG9yZGVyIHRvIG1ha2UgaXQgcG9zc2libGUgZm9y IHRlc3RzIHRvIHN3YXAgbm9kZXMgaW4gYW5kCj4gPiA+IG91dCBmb3IgdGVzdGluZy4KPiA+Cj4g PiBZZXMsIHRoYXQncyBob3cgdGhlIERUIHVuaXR0ZXN0IHdvcmtzLiBCdXQgaXQgaXMgcHJldHR5 IG11Y2ggb25lIGJpZwo+ID4gb3ZlcmxheSAoaWdub3JpbmcgdGhlIG92ZXJsYXkgdGVzdHMpLiBJ dCBjb3VsZCBwcm9iYWJseSBiZSBtb3JlCj4gPiBtb2R1bGFyIHdoZXJlIGl0IGlzIGFwcGx5IG92 ZXJsYXksIHRlc3QsIHJlbW92ZSBvdmVybGF5LCByZXBlYXQuCj4KPiBJIGRpZG4ndCB3YW50IHRv IHJlbHkgb24gdGhlIG92ZXJsYXkgY29kZSB0byBpbmplY3QgRFQgbm9kZXMuIEhhdmluZwo+IHRl c3RzIHdyaXR0ZW4gZm9yIHRoZSBmYWtlIEtVbml0IG1hY2hpbmUgaXMgc2ltcGxlLiBJdCBjbG9z ZWx5IG1hdGNoZXMKPiBob3cgY2xrIGNvZGUgcHJvYmVzIHRoZSBEVEIgYW5kIGhvdyBub2RlcyBh cmUgY3JlYXRlZCBhbmQgcG9wdWxhdGVkIG9uCj4gdGhlIHBsYXRmb3JtIGJ1cyBhcyBkZXZpY2Vz LiBDTEtfT0ZfREVDTEFSRSgpIHdvdWxkIG5lZWQgdGhlIG92ZXJsYXkgdG8KPiBiZSBhcHBsaWVk IGVhcmx5IHRvbywgd2hpY2ggZG9lc24ndCBoYXBwZW4gb3RoZXJ3aXNlIGFzIGZhciBhcyBJIGtu b3cuCgpEb24ndCBhbGwgZ2VuZXJpYyBjbG9jayBkcml2ZXJzIGFsc28gY3JlYXRlIGEgcGxhdGZv cm0gZHJpdmVyPwpBdCBsZWFzdCBkcml2ZXJzL2Nsay9jbGstZml4ZWQtZmFjdG9yLmMgZG9lcy4K Cj4gQnV0IHBlcmhhcHMgdGhpcyBkZXNpZ24gaXMgdG9vIG11Y2ggb2YgYW4gZW5kLXRvLWVuZCB0 ZXN0IGFuZCBub3QgYSB1bml0Cj4gdGVzdD8gSW4gdGhlIHNwaXJpdCBvZiB1bml0IHRlc3Rpbmcg d2Ugc2hvdWxkbid0IGNhcmUgYWJvdXQgaG93IHRoZSBub2RlCj4gaXMgYWRkZWQgdG8gdGhlIGxp dmUgZGV2aWNldHJlZSwganVzdCB0aGF0IHRoZXJlIGlzIGEgZGV2aWNldHJlZSBhdCBhbGwuCj4K PiBTdXBwb3J0aW5nIG92ZXJsYXlzIHRvIG1vcmUgZWFzaWx5IHRlc3QgY29tYmluYXRpb25zIHNv dW5kcyBsaWtlIGEgZ29vZAo+IGlkZWEuIFByb2JhYmx5IHNvbWUga3VuaXRfKigpIHByZWZpeGVk IGZ1bmN0aW9ucyBjb3VsZCBiZSB1c2VkIHRvCj4gYXBwbHkgYSB0ZXN0IG1hbmFnZWQgb3Zlcmxh eSBhbmQgYXV0b21hdGljYWxseSByZW1vdmUgaXQgd2hlbiB0aGUgdGVzdAo+IGlzIG92ZXIgd291 bGQgd29yay4gVGhlIGNsayByZWdpc3RyYXRpb24gdGVzdHMgY291bGQgdXNlIHRoaXMgQVBJIHRv Cj4gaW5qZWN0IGFuIG92ZXJsYXkgYW5kIHRoZW4gbWFudWFsbHkgY2FsbCB0aGUgb2ZfcGxhdGZv cm1fcG9wdWxhdGUoKQo+IGZ1bmN0aW9uIHRvIGNyZWF0ZSB0aGUgcGxhdGZvcm0gZGV2aWNlKHMp LiBUaGUgb3ZlcmxheSBjb3VsZCBiZSBidWlsdCBpbgo+IGRyaXZlcnMvY2xrLyB0b28gYW5kIHRo ZW4gcHJvYmFibHkgc29tZSBtYWNyb2lzaCBmdW5jdGlvbiBjYW4gZmluZCB0aGUKPiBibG9iIGFu ZCBhcHBseSBpdC4KCk5vIG5lZWQgdG8gbWFudWFsbHkgY2FsbCBvZl9wbGF0Zm9ybV9wb3B1bGF0 ZSgpIHRvIGNyZWF0ZSB0aGUKcGxhdGZvcm0gZGV2aWNlcy4gVGhhdCBpcyB0YWtlbiBjYXJlIG9m IGF1dG9tYXRpY2FsbHkgd2hlbiBhcHBseWluZwphbiBvdmVybGF5LgoKPiBJcyB0aGVyZSBzb21l IHdheSB0byBkZWxldGUgdGhlIHBsYXRmb3JtIGRldmljZXMgdGhhdCB3ZSBwb3B1bGF0ZSBmcm9t Cj4gdGhlIG92ZXJsYXk/IEknZCBsaWtlIHRoZSB0ZXN0cyB0byBiZSBoZXJtZXRpYy4KClJlbW92 aW5nIHRoZSBvdmVybGF5IHdpbGwgZGVsZXRlIHRoZSBwbGF0Zm9ybSBkZXZpY2VzLgoKQWxsIG9m IHRoYXQgd29ya3MgaWYgeW91IGhhdmUgeW91ciBvd24gY29kZSB0byBhcHBseSBhIERUIG92ZXJs YXkuClRoZSByZWNlbnQgZndfZGV2bGlua3MgcGF0Y2hlcyBkaWQgY2F1c2Ugc29tZSByZWdyZXNz aW9ucywgY2ZyLgpodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvQ0FNdUhNZFhFblNENHJSSi1v OTB4NE9wclVhY05fckpneW84eDY9OUY5clorLUt6ak9nQG1haWwuZ21haWwuY29tCgpQLlMuIFNo YW1lbGVzcyBwbHVnOiBmb3IgbG9hZGluZyBvdmVybGF5cyBmcm9tIHVzZXJzcGFjZSwgdGhlcmUg YXJlCiAgICAgbXkgb3ZlcmxheSBicmFuY2hlcywgY2ZyLiBodHRwczovL2VsaW51eC5vcmcvUi1D YXIvRFQtT3ZlcmxheXMKCkdye29ldGplLGVldGluZ31zLAoKICAgICAgICAgICAgICAgICAgICAg ICAgR2VlcnQKCgotLQpHZWVydCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4 IGJleW9uZCBpYTMyIC0tIGdlZXJ0QGxpbnV4LW02OGsub3JnCgpJbiBwZXJzb25hbCBjb252ZXJz YXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0 CndoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIg b3Igc29tZXRoaW5nIGxpa2UgdGhhdC4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAt LSBMaW51cyBUb3J2YWxkcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81B210FA for ; Thu, 2 Mar 2023 19:53:27 +0000 (UTC) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-1720433ba75so637006fac.5 for ; Thu, 02 Mar 2023 11:53:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f95O1774ZoBykD/usZaosY+efoKseNjJy4cpA8XSzCQ=; b=R4hqN0g0GE8Tbgy7f6JX/1kh3786XwE0oH7sRql2WaS6xgsl+Tef7tK2HMSKhcbN4i AeENneQ12ZKTSV/2tjicbm8GaoSawJjciMuaxdP/T1b35AIeLw9ItnZZP8F+5jKxdP5C w8oJ7g4A1G3aMgv+Zv4FUFP8cdsWkz44HS3UDPVPkImZ2F9YRKfDaInZNbGftSLluPmc UOWx4UZDK/VsUPLbxmfGe4oIepBiF5O1pYIGOpHh36rUxNBa6IQUEkdLMtX/3FbWOa6a IoHeFEGQVxqXppHzkeuy59G7F48jkD2monsN+1CySgHoPgLVyeSEcIoBe/YSu+ko5nDe s+Tw== X-Gm-Message-State: AO0yUKU7c0X9bwt+MyRNXcICO8j8d+CRlNvqu39teDM3K+7GwiFl/q+J TIAU2GlyCO5H35ZGQDuHBJB/R8nbh6ihEA== X-Google-Smtp-Source: AK7set8X20OhtL4WcIzo1V181NAtqZX72IK5quJBx4AOwHEcOnrneezyp9xtewok9g5ml4v2VpF5Pg== X-Received: by 2002:a05:6870:3486:b0:176:308b:5398 with SMTP id n6-20020a056870348600b00176308b5398mr3096492oah.51.1677786806649; Thu, 02 Mar 2023 11:53:26 -0800 (PST) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com. [209.85.161.41]) by smtp.gmail.com with ESMTPSA id i17-20020a056870d41100b001723f29f6e2sm237119oag.37.2023.03.02.11.53.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 11:53:26 -0800 (PST) Received: by mail-oo1-f41.google.com with SMTP id c184-20020a4a4fc1000000b005250b2dc0easo102386oob.2 for ; Thu, 02 Mar 2023 11:53:26 -0800 (PST) X-Received: by 2002:a81:ad1b:0:b0:52f:1c23:ef1 with SMTP id l27-20020a81ad1b000000b0052f1c230ef1mr7066170ywh.5.1677786463634; Thu, 02 Mar 2023 11:47:43 -0800 (PST) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230302013822.1808711-1-sboyd@kernel.org> <3759b28cca7ab751296d4dd83f2dcc51.sboyd@kernel.org> In-Reply-To: <3759b28cca7ab751296d4dd83f2dcc51.sboyd@kernel.org> From: Geert Uytterhoeven Date: Thu, 2 Mar 2023 20:47:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data To: Stephen Boyd Cc: David Gow , Rob Herring , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Brendan Higgins , Greg Kroah-Hartman , "Rafael J . Wysocki" , Richard Weinberger , Anton Ivanov , Johannes Berg , Vincent Whitchurch , Frank Rowand , Christian Marangi , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-um@lists.infradead.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stephen, On Thu, Mar 2, 2023 at 8:28=E2=80=AFPM Stephen Boyd wrot= e: > Quoting Rob Herring (2023-03-02 09:32:09) > > On Thu, Mar 2, 2023 at 2:14=E2=80=AFAM David Gow = wrote: > > > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > This patch series adds unit tests for the clk fixed rate basic type= and > > > > the clk registration functions that use struct clk_parent_data. To = get > > > > there, we add support for loading a DTB into the UML kernel that's > > > > running the unit tests along with probing platform drivers to bind = to > > > > device nodes specified in DT. > > > > > > > > With this series, we're able to exercise some of the code in the co= mmon > > > > clk framework that uses devicetree lookups to find parents and the = fixed > > > > rate clk code that scans devicetree directly and creates clks. Plea= se > > > > review. > > > > > > > > > > Thanks Stephen -- this is really neat! > > > > > > This works well here, and I love all of the tests for the > > > KUnit/device-tree integration as well. > > > > > > I'm still looking through the details of it (alas, I've mostly lived > > > in x86-land, so my device-tree knowledge is, uh, spotty to say the > > > least), but apart from possibly renaming some things or similarly > > > minor tweaks, I've not got any real suggestions thus far. > > > > > > I do wonder whether we'll want, on the KUnit side, to have some way o= f > > > supporting KUnit device trees on non-UML architecctures (e.g., if we > > > need to test something architecture-specific, or on a big-endian > > > platform, etc), but I think that's a question for the future, rather > > > than something that affects this series. > > > > I'll say that's a requirement. We should be able to structure the > > tests to not interfere with the running system's DT. The DT unittest > > does that. > > That could be another choice in the unit test choice menu. > CONFIG_OF_KUNIT_NOT_UML that injects some built-in DTB overlay on an > architecture that wants to run tests. As long as you use compatible values that don't exist elsewhere, and don't overwrite anything, you can load your kunit test overlays on any running system that has DT support. > > As a side topic, Is anyone looking at getting UML to work on arm64? > > It's surprising how much x86 stuff there is which is I guess one > > reason it hasn't happened. > > I've no idea but it would be nice indeed. I believe that's non-trivial. At least for arm32 (I didn't have any arm64 systems last time I asked the experts). > > > Similarly, I wonder if there's something we could do with device tree > > > overlays, in order to make it possible for tests to swap nodes in and > > > out for testing. > > > > Yes, that's how the DT unittest works. But it is pretty much one big > > overlay (ignoring the overlay tests). It could probably be more > > modular where it is apply overlay, test, remove overlay, repeat. > > I didn't want to rely on the overlay code to inject DT nodes. Having > tests written for the fake KUnit machine is simple. It closely matches > how clk code probes the DTB and how nodes are created and populated on > the platform bus as devices. CLK_OF_DECLARE() would need the overlay to > be applied early too, which doesn't happen otherwise as far as I know. Don't all generic clock drivers also create a platform driver? At least drivers/clk/clk-fixed-factor.c does. > But perhaps this design is too much of an end-to-end test and not a unit > test? In the spirit of unit testing we shouldn't care about how the node > is added to the live devicetree, just that there is a devicetree at all. > > Supporting overlays to more easily test combinations sounds like a good > idea. Probably some kunit_*() prefixed functions could be used to > apply a test managed overlay and automatically remove it when the test > is over would work. The clk registration tests could use this API to > inject an overlay and then manually call the of_platform_populate() > function to create the platform device(s). The overlay could be built in > drivers/clk/ too and then probably some macroish function can find the > blob and apply it. No need to manually call of_platform_populate() to create the platform devices. That is taken care of automatically when applying an overlay. > Is there some way to delete the platform devices that we populate from > the overlay? I'd like the tests to be hermetic. Removing the overlay will delete the platform devices. All of that works if you have your own code to apply a DT overlay. The recent fw_devlinks patches did cause some regressions, cfr. https://lore.kernel.org/all/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=3D9F9rZ+= -KzjOg@mail.gmail.com P.S. Shameless plug: for loading overlays from userspace, there are my overlay branches, cfr. https://elinux.org/R-Car/DT-Overlays Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds