All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Herring <robh+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 04/14] dt-bindings: clock: Add r9a09g011 CPG Clock Definitions
Date: Wed, 23 Mar 2022 15:29:23 +0100	[thread overview]
Message-ID: <CAMuHMdXFOjuvWiORs_CNt+xgm4QWgDaHvzb0Q0OPibmKP7uhRA@mail.gmail.com> (raw)
In-Reply-To: <b00a4cc8-c8b8-60ab-9891-e6cb44c8bf75@kernel.org>

Hi Krzysztof,

On Wed, Mar 23, 2022 at 11:44 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 21/03/2022 16:42, Phil Edworthy wrote:
> > Define RZ/V2M (R9A09G011) Clock Pulse Generator core clocks, module clock
> > outputs (CPG_CLK_ON* registers), and reset definitions (CPG_RST_*
> > registers) in Section 48.5 ("Register Description") of the RZ/V2M Hardware
> > User's Manual (Rev. 1.10, Sep. 2021).
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

> > --- /dev/null
> > +++ b/include/dt-bindings/clock/r9a09g011-cpg.h
> > @@ -0,0 +1,337 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > + *
> > + * Copyright (C) 2022 Renesas Electronics Corp.
> > + */
> > +#ifndef __DT_BINDINGS_CLOCK_R9A09G011_CPG_H__
> > +#define __DT_BINDINGS_CLOCK_R9A09G011_CPG_H__
> > +
> > +#include <dt-bindings/clock/renesas-cpg-mssr.h>
>
> Include only headers which you use here. Do you use it directly here?

Technically, it is part of the clock bindings for the SoC.
That's why it's included here, and in several other *-cpg-mssr.h files.

So I prefer to keep it that way.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2022-03-23 14:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 15:42 [PATCH 00/14] Add new Renesas RZ/V2M SoC and Renesas RZ/V2M EVK support Phil Edworthy
2022-03-21 15:42 ` [PATCH 01/14] dt-bindings: arm: renesas: Document Renesas RZ/V2M SoC and EVK board Phil Edworthy
2022-03-23 10:29   ` Krzysztof Kozlowski
2022-03-21 15:42 ` [PATCH 02/14] dt-bindings: arm: renesas: Document Renesas RZ/V2M System Configuration Phil Edworthy
2022-03-23 10:41   ` Krzysztof Kozlowski
2022-03-23 14:44     ` Phil Edworthy
2022-03-23 14:54       ` Krzysztof Kozlowski
2022-03-29  1:03         ` Rob Herring
2022-04-26 14:10           ` Geert Uytterhoeven
2022-03-21 15:42 ` [PATCH 03/14] dt-bindings: serial: renesas,em-uart: Document r9a09g011 bindings Phil Edworthy
2022-03-23 10:42   ` Krzysztof Kozlowski
2022-03-23 14:49     ` Phil Edworthy
2022-03-21 15:42 ` [PATCH 04/14] dt-bindings: clock: Add r9a09g011 CPG Clock Definitions Phil Edworthy
2022-03-23 10:44   ` Krzysztof Kozlowski
2022-03-23 14:07     ` Phil Edworthy
2022-03-23 14:29     ` Geert Uytterhoeven [this message]
2022-03-23 14:36       ` Krzysztof Kozlowski
2022-03-21 15:42 ` [PATCH 05/14] dt-bindings: clock: renesas,rzg2l: Document RZ/V2M SoC Phil Edworthy
2022-03-23 10:44   ` Krzysztof Kozlowski
2022-03-21 15:42 ` [PATCH 06/14] serial: 8250: Make SERIAL_8250_EM available for arm64 systems Phil Edworthy
2022-03-21 16:14   ` Andy Shevchenko
2022-03-21 15:42 ` [PATCH 07/14] soc: renesas: Identify RZ/V2M SoC Phil Edworthy
2022-04-26 14:16   ` Geert Uytterhoeven
2022-03-21 15:42 ` [PATCH 08/14] clk: renesas: rzg2l: Set HIWORD mask for all mux and dividers Phil Edworthy
2022-03-21 15:42 ` [PATCH 09/14] clk: renesas: rzg2l: Make use of CLK_MON registers optional Phil Edworthy
2022-03-21 15:42 ` [PATCH 10/14] clk: renesas: rzg2l: Add support for RZ/V2M reset monitor reg Phil Edworthy
2022-03-21 15:42 ` [PATCH 11/14] clk: renesas: Add RZ/V2M support using the rzg2l driver Phil Edworthy
2022-03-21 15:42 ` [PATCH 12/14] arm64: defconfig: Enable Renesas RZ/V2M SoC Phil Edworthy
2022-03-21 15:42   ` Phil Edworthy
2022-03-21 15:57   ` Marcel Ziswiler
2022-03-21 15:57     ` Marcel Ziswiler
2022-03-21 15:42 ` [PATCH 13/14] arm64: dts: renesas: Add initial DTSI for " Phil Edworthy
2022-03-21 15:42 ` [PATCH 14/14] arm64: dts: renesas: Add initial device tree for RZ/V2M EVK Phil Edworthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdXFOjuvWiORs_CNt+xgm4QWgDaHvzb0Q0OPibmKP7uhRA@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.