From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAB4C4743C for ; Wed, 23 Jun 2021 13:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5228A60FD8 for ; Wed, 23 Jun 2021 13:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbhFWNLk (ORCPT ); Wed, 23 Jun 2021 09:11:40 -0400 Received: from mail-ua1-f45.google.com ([209.85.222.45]:40545 "EHLO mail-ua1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbhFWNLg (ORCPT ); Wed, 23 Jun 2021 09:11:36 -0400 Received: by mail-ua1-f45.google.com with SMTP id r9so828025ual.7; Wed, 23 Jun 2021 06:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2GyvRMqzd0j7dU3QjG5cKA3SND3uzGcIE5fba+nRyaE=; b=VSmcRh4MftvCjl9E1F1HLcutSXjgX9Vt474J0i55jARkgepTWyfhCb4LDCikvqS9uG VX0DbKBXly9p2BfiWzCDsSYNO7BFSDyQmhoEHWMyT1CcrgFkDj183O8qrhnUZCoJr9du IhD7hId0I2qZMD+0NgKQO/JS6WkVAH9EAjHYvlAWfSZ69aP/xndgx7wr4XEax+8Jeoi+ oDZ9/nt3q9FAuE4qxxtxQ6ms/KNb67+zkpvye02ZRQrnZ2Z57asV3xfkXlItorYuB4qr 7zW3GS9XbExwT6DnSQqcGTybtxmz4wIGIZb0eRSTQAtioTkSUB/R0eCErPZJR6Phtk6C YZjg== X-Gm-Message-State: AOAM533ng+XxvaNb0bBgtD9tRMM8GTKv0ZomdnQohh2Ds5DR0S1uuOMy Qhp/SQdhXkjM7UFTjdtGMzxyOjl5cM4CJpchA2E= X-Google-Smtp-Source: ABdhPJy7fEj+42hR8loz80KZeBpk8m6cSVSkPMGaM+vOPsqzJ7EuBgra5HjzbA2XO5FoOuNmfwqhB3mqOHbBdX7nzSE= X-Received: by 2002:ab0:1e4c:: with SMTP id n12mr4441015uak.58.1624453757600; Wed, 23 Jun 2021 06:09:17 -0700 (PDT) MIME-Version: 1.0 References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 23 Jun 2021 15:09:06 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 To: Laurent Pinchart Cc: Kieran Bingham , Kieran Bingham , David Airlie , Daniel Vetter , Rob Herring , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On Wed, Jun 23, 2021 at 2:58 PM Laurent Pinchart wrote: > On Wed, Jun 23, 2021 at 02:53:33PM +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > > > From: Kieran Bingham > > > > > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > > > > > Signed-off-by: Kieran Bingham > > > > Thanks for your patch! > > > > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > > @@ -39,6 +39,7 @@ properties: > > > - renesas,du-r8a77980 # for R-Car V3H compatible DU > > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > > > > > reg: > > > maxItems: 1 > > > @@ -774,6 +775,57 @@ allOf: > > > - reset-names > > > - renesas,vsps > > > > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - renesas,du-r8a779a0 > > > + then: > > > + properties: > > > + clocks: > > > + items: > > > + - description: Functional clock for DU0 > > > + - description: Functional clock for DU1 > > > + > > > + clock-names: > > > + items: > > > + - const: du.0 > > > + - const: du.1 > > > > The hardware block has only a single function clock for both channels, > > like on R-Car H1. > > > > And what about DU_DOTCLKIN? > > As far as I can tell, there's no DU_DOTCLKIN in V3U. See Table 6.13 of the Hardware User's Manual, pin IPC_CLKIN. Note that the register bits to configure it are present in drivers/pinctrl/renesas/pfc-r8a779a0.c, but the actual pin group is missing. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9602FC4743C for ; Wed, 23 Jun 2021 13:09:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B726108E for ; Wed, 23 Jun 2021 13:09:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21B726108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 848696E8D9; Wed, 23 Jun 2021 13:09:19 +0000 (UTC) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 596326E8D9 for ; Wed, 23 Jun 2021 13:09:18 +0000 (UTC) Received: by mail-ua1-f54.google.com with SMTP id r4so827466uap.8 for ; Wed, 23 Jun 2021 06:09:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2GyvRMqzd0j7dU3QjG5cKA3SND3uzGcIE5fba+nRyaE=; b=fncO9XKGAZpf77AxDPDoUrWBAhKzoX/l6kApkXHFL5LwJq0Tnv1+nJDKVF9nOcva9n +iMmgUgIP2HvW0bGOTjVMELrr/gMvccBwGDO7bYOKfIBsmPgKIWyqkAwNwOsV0Bhyeoz iW3MPI6Tbd0hmjnnbHFDwgWn5BEWamhKYamh5bigPd+8QCL5rXNstrl2jF2WR8WOsndd 30zMlqKmSvM9tnwT0a43Je4ecJHP1kRdcq/aMqxbB6DwKJX/JxnnKn0kLa2f0vVzS0nm NBq7P6Tts6OXonk4fyt4qc/evATWD1JWPn7Co44eUE/2D3K/ZyMEnvbC4Mga/GPwvk2e BEHg== X-Gm-Message-State: AOAM531Wsgct4ebRiSCuEnCp3N/NTv0l/xsvm7Lu16rWe+UbMi61iieI 6UvD4ips4Q5cQ18Paferp+8vTe7cAp5XknSx1Xo= X-Google-Smtp-Source: ABdhPJy7fEj+42hR8loz80KZeBpk8m6cSVSkPMGaM+vOPsqzJ7EuBgra5HjzbA2XO5FoOuNmfwqhB3mqOHbBdX7nzSE= X-Received: by 2002:ab0:1e4c:: with SMTP id n12mr4441015uak.58.1624453757600; Wed, 23 Jun 2021 06:09:17 -0700 (PDT) MIME-Version: 1.0 References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 23 Jun 2021 15:09:06 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: display: renesas, du: Provide bindings for r8a779a0 To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , Kieran Bingham , Kieran Bingham , "open list:DRM DRIVERS FOR RENESAS" , open list , "open list:DRM DRIVERS FOR RENESAS" , Rob Herring Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Wed, Jun 23, 2021 at 2:58 PM Laurent Pinchart wrote: > On Wed, Jun 23, 2021 at 02:53:33PM +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > > > From: Kieran Bingham > > > > > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > > > > > Signed-off-by: Kieran Bingham > > > > Thanks for your patch! > > > > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > > @@ -39,6 +39,7 @@ properties: > > > - renesas,du-r8a77980 # for R-Car V3H compatible DU > > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > > > > > reg: > > > maxItems: 1 > > > @@ -774,6 +775,57 @@ allOf: > > > - reset-names > > > - renesas,vsps > > > > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - renesas,du-r8a779a0 > > > + then: > > > + properties: > > > + clocks: > > > + items: > > > + - description: Functional clock for DU0 > > > + - description: Functional clock for DU1 > > > + > > > + clock-names: > > > + items: > > > + - const: du.0 > > > + - const: du.1 > > > > The hardware block has only a single function clock for both channels, > > like on R-Car H1. > > > > And what about DU_DOTCLKIN? > > As far as I can tell, there's no DU_DOTCLKIN in V3U. See Table 6.13 of the Hardware User's Manual, pin IPC_CLKIN. Note that the register bits to configure it are present in drivers/pinctrl/renesas/pfc-r8a779a0.c, but the actual pin group is missing. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds