From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f180.google.com ([209.85.223.180]:36354 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933202AbdDZMgA (ORCPT ); Wed, 26 Apr 2017 08:36:00 -0400 MIME-Version: 1.0 In-Reply-To: <20170426073418.GE25517@verge.net.au> References: <1493141785-29117-1-git-send-email-geert+renesas@glider.be> <20170426071305.GC25517@verge.net.au> <20170426073418.GE25517@verge.net.au> From: Geert Uytterhoeven Date: Wed, 26 Apr 2017 14:35:58 +0200 Message-ID: Subject: Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing To: Simon Horman Cc: Geert Uytterhoeven , Magnus Damm , Linux-Renesas , linux-clk Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Simon, On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman wrote: > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote: >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote: >> > If the R-Car RST driver is not included, compile-testing R-Car clock >> > drivers fails with a link error: >> > >> > undefined reference to `rcar_rst_read_mode_pins' >> > >> > To fix this, provide a dummy version. Use the exact same test logic as >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to >> > control compilation of the R-Car RST driver. >> >> Adding a Kconfig symbol would be a bit cleaner IMHO. > > I now see you are doing so in other patches :) Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have a Kconfig file yet, and introducing a Kconfig symbol would thus be more intrusive. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds