From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF34C433B4 for ; Thu, 29 Apr 2021 08:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3967C61446 for ; Thu, 29 Apr 2021 08:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239672AbhD2IFp (ORCPT ); Thu, 29 Apr 2021 04:05:45 -0400 Received: from mail-vs1-f52.google.com ([209.85.217.52]:42943 "EHLO mail-vs1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239520AbhD2IFo (ORCPT ); Thu, 29 Apr 2021 04:05:44 -0400 Received: by mail-vs1-f52.google.com with SMTP id 66so33248308vsk.9; Thu, 29 Apr 2021 01:04:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEaWsqveglqKutwIfCWg/c1k8Pjc9F7AASjTBk3kAB0=; b=qRxS7DrgjtfP6uNKjGJyeysH31OCYcAOJHbFS000i/hrznxEAdXpWvtEOseiZJLjUw p5QF60hahfKSUW6eQSTmv9LOZeEaprPtoBEU0Uaz5xcMsQMwnolI36j5Bjl2dEjQCTib IqzGn9kVzSMAo1vkBdBHfMxQQnL75EyOETJLDwkDrequvJ+r/LUTMJlnw2l6xLTxHIw8 ZuTa0T5SLJ1Grfr+3bBigKcekZFZd9dOq1rVOPzpiuuQ/QbQ4VkcMjsRgBz/6d9I4R3o 6EVPfxDyUKYNaAluWyz3GQW2pFvGb3brqxk+49yJKTppqpJGtlPs+0QlgJD/hsdl/6eE QdJg== X-Gm-Message-State: AOAM532dpOwsliZ3fm645/WBICC65toI0bKKrKXCBfYSYZR6GQfqVZSn V9mCK7DEnfaGX/gzTI3uLx6ywul2G9I+RwsOqqY= X-Google-Smtp-Source: ABdhPJyOQfCSFL6ivPQSvopdsprRnA2n+Ja7fwwMwXAF5cOL+2KKLY+oOwM93GwYMJWOqvFowThQ0q/7iQPRdk2pFdw= X-Received: by 2002:a67:fc57:: with SMTP id p23mr29422049vsq.40.1619683497839; Thu, 29 Apr 2021 01:04:57 -0700 (PDT) MIME-Version: 1.0 References: <161918446704.3145707.14418606303992174310.stgit@warthog.procyon.org.uk> <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> In-Reply-To: <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> From: Geert Uytterhoeven Date: Thu, 29 Apr 2021 10:04:46 +0200 Message-ID: Subject: Re: [PATCH v7 07/31] netfs: Make a netfs helper module To: David Howells Cc: Linux FS Devel , Marc Dionne , Linux MM , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, "open list:NFS, SUNRPC, AND..." , linux-cifs@vger.kernel.org, ceph-devel , V9FS Developers , Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , David Wysochanski , "Matthew Wilcox (Oracle)" , Alexander Viro , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Hi David, On Fri, Apr 23, 2021 at 3:31 PM David Howells wrote: > Make a netfs helper module to manage read request segmentation, caching > support and transparent huge page support on behalf of a network > filesystem. > > Signed-off-by: David Howells Thanks for your patch, which is now commit 3ca236440126f75c ("mm: Implement readahead_control pageset expansion") upstream. > --- /dev/null > +++ b/fs/netfs/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config NETFS_SUPPORT > + tristate "Support for network filesystem high-level I/O" > + help > + This option enables support for network filesystems, including > + helpers for high-level buffered I/O, abstracting out read > + segmentation, local caching and transparent huge page support. TBH, this help text didn't give me any clue on whether I want to enable this config option or not. Do I need it for e.g. NFS, which is a network filesystem? I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this is just a library of functions, to be selected by its users, then please make the symbol invisible. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74977C43461 for ; Thu, 29 Apr 2021 08:05:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBF3E61453 for ; Thu, 29 Apr 2021 08:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBF3E61453 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98BA86B006C; Thu, 29 Apr 2021 04:04:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90ACA6B0070; Thu, 29 Apr 2021 04:04:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6AD6B0071; Thu, 29 Apr 2021 04:04:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 1E9AE6B006C for ; Thu, 29 Apr 2021 04:04:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D08788248D51 for ; Thu, 29 Apr 2021 08:04:58 +0000 (UTC) X-FDA: 78084668676.11.3D3227E Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 17B0780192F6 for ; Thu, 29 Apr 2021 08:04:34 +0000 (UTC) Received: by mail-vs1-f53.google.com with SMTP id k19so20171758vsg.0 for ; Thu, 29 Apr 2021 01:04:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEaWsqveglqKutwIfCWg/c1k8Pjc9F7AASjTBk3kAB0=; b=fmNOCZk6M+fGBpl+i0CkfMkSCh1wTwhdzbMtZ+lGIYc1VDUPi+Fbl2BAG/x/189IbP TrvZ9rrLFWH+MtDxGOZmoPIr2xwy2id1cVMWPdIyOIvwpLftoN98aP/frkC2I3pOvBd6 d6ylsip31aQ1nOn8wmKOrSx4TNl2gOf1N4TSNltuYXiwR33bKTdEN9Kdbu5xAw9dT+bJ FOfriAwPNvRoEl7UfDwxwXle3jT2Gxy3GohBiJ9nv6tIyBY5bj7eqHCuW6QkNH922ShG Al0uuDjfCXt+YGP62MyD8zzPE3Z01A9kg01gaMNc/Ng0lXxxwKZFnAEtK9eoOTykE+Dz O6sQ== X-Gm-Message-State: AOAM533qcgKr9JATbU2NHEGumKPxg1R7KgjqhQmxOuSQVSC3256pB6HB gQq58mJVrazoAXY07ncba3PEsGDQl4Ej9hY2xq0= X-Google-Smtp-Source: ABdhPJyOQfCSFL6ivPQSvopdsprRnA2n+Ja7fwwMwXAF5cOL+2KKLY+oOwM93GwYMJWOqvFowThQ0q/7iQPRdk2pFdw= X-Received: by 2002:a67:fc57:: with SMTP id p23mr29422049vsq.40.1619683497839; Thu, 29 Apr 2021 01:04:57 -0700 (PDT) MIME-Version: 1.0 References: <161918446704.3145707.14418606303992174310.stgit@warthog.procyon.org.uk> <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> In-Reply-To: <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> From: Geert Uytterhoeven Date: Thu, 29 Apr 2021 10:04:46 +0200 Message-ID: Subject: Re: [PATCH v7 07/31] netfs: Make a netfs helper module To: David Howells Cc: Linux FS Devel , Marc Dionne , Linux MM , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, "open list:NFS, SUNRPC, AND..." , linux-cifs@vger.kernel.org, ceph-devel , V9FS Developers , Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , David Wysochanski , "Matthew Wilcox (Oracle)" , Alexander Viro , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 17B0780192F6 X-Stat-Signature: 796nqad45u38g73dapzbbziyz9sa6d8y Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-vs1-f53.google.com; client-ip=209.85.217.53 X-HE-DKIM-Result: none/none X-HE-Tag: 1619683474-292984 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David, On Fri, Apr 23, 2021 at 3:31 PM David Howells wrote: > Make a netfs helper module to manage read request segmentation, caching > support and transparent huge page support on behalf of a network > filesystem. > > Signed-off-by: David Howells Thanks for your patch, which is now commit 3ca236440126f75c ("mm: Implement readahead_control pageset expansion") upstream. > --- /dev/null > +++ b/fs/netfs/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config NETFS_SUPPORT > + tristate "Support for network filesystem high-level I/O" > + help > + This option enables support for network filesystems, including > + helpers for high-level buffered I/O, abstracting out read > + segmentation, local caching and transparent huge page support. TBH, this help text didn't give me any clue on whether I want to enable this config option or not. Do I need it for e.g. NFS, which is a network filesystem? I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this is just a library of functions, to be selected by its users, then please make the symbol invisible. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds