From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v4 1/3] watchdog: add rza_wdt driver Date: Fri, 3 Mar 2017 11:16:19 +0100 Message-ID: References: <20170302135746.30550-1-chris.brandt@renesas.com> <20170302135746.30550-2-chris.brandt@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Brandt Cc: Guenter Roeck , Wim Van Sebroeck , Sebastian Reichel , Rob Herring , Mark Rutland , Simon Horman , "linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Chris, On Thu, Mar 2, 2017 at 4:38 PM, Chris Brandt wrote: >> > + /* >> > + * Since the max possible timeout of our 8-bit count register is >> less >> > + * than a second, we must use max_hw_heartbeat_ms. >> > + */ >> > + priv->wdev.max_hw_heartbeat_ms = (1000 * U8_MAX)/rate; >> >> space before and after / > > OK. > #Funny because checkpatch.pl said it didn't like a space on one side but > not the other, so I choose no spaces and it was happy. I'm way below 80 > characters for that line so it doesn't matter to me. Just drop the parentheses? Standard C operator precedence is fine here. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:32985 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbdCCKRF (ORCPT ); Fri, 3 Mar 2017 05:17:05 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170302135746.30550-1-chris.brandt@renesas.com> <20170302135746.30550-2-chris.brandt@renesas.com> From: Geert Uytterhoeven Date: Fri, 3 Mar 2017 11:16:19 +0100 Message-ID: Subject: Re: [PATCH v4 1/3] watchdog: add rza_wdt driver To: Chris Brandt Cc: Guenter Roeck , Wim Van Sebroeck , Sebastian Reichel , Rob Herring , Mark Rutland , Simon Horman , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Chris, On Thu, Mar 2, 2017 at 4:38 PM, Chris Brandt wrote: >> > + /* >> > + * Since the max possible timeout of our 8-bit count register is >> less >> > + * than a second, we must use max_hw_heartbeat_ms. >> > + */ >> > + priv->wdev.max_hw_heartbeat_ms = (1000 * U8_MAX)/rate; >> >> space before and after / > > OK. > #Funny because checkpatch.pl said it didn't like a space on one side but > not the other, so I choose no spaces and it was happy. I'm way below 80 > characters for that line so it doesn't matter to me. Just drop the parentheses? Standard C operator precedence is fine here. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds