From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663A0C4338F for ; Tue, 24 Aug 2021 13:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 515FA60231 for ; Tue, 24 Aug 2021 13:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234695AbhHXN4m (ORCPT ); Tue, 24 Aug 2021 09:56:42 -0400 Received: from mail-vk1-f179.google.com ([209.85.221.179]:44693 "EHLO mail-vk1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237535AbhHXN4j (ORCPT ); Tue, 24 Aug 2021 09:56:39 -0400 Received: by mail-vk1-f179.google.com with SMTP id n200so5532970vke.11 for ; Tue, 24 Aug 2021 06:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8hP4pVddrWImbh6fCLaXB99hmcWtMRQBThCoTN0H6s=; b=pKajhB6kjNSSnPWrgfrEekKYXrC9r5IkXYWZKTaG3LjK6FOBog7VNRluI5b2/jsFV/ iHyBtU7Wlz4/Nn4rLSd0VxAFOvMwJQMWJt8eQ9Vq3xiO508fkZMq61j8Suo4CncPwm1a Vn+uy/nmw+1aXUGhfFB1g0E0CP+jq8xS+vcvbqF+o6f6LricvXkUmUQq5A4L/xBpBe0G K0is/4tMNt88O+GJBcMPXTzS7NMcWtihMNtlvnwBZVjoFY6TbdRItCk4VBp0yhdgZOvk k44h7m9qj5LNYVe9A9g/5oAbxBocDj5pYrZqpkovKuqM3DzM5E9HAekB6vIdQ3FVfAVN ewaw== X-Gm-Message-State: AOAM532LbSFNz6qjcJSlNWna5imaSPs0PjOGgyDJNyKEKfecNdBJ5ja4 iJaCQ/fFzOL78Hd6rpIJ9JPVMC19tWYqCSYtlTc= X-Google-Smtp-Source: ABdhPJwOAVxPzgJVnsFrTLNfWZ/oMMEIpSzQrTS/Wb0ggwHzX527BJKiGPZFrjZHNpbcPeMgxnT0ww/YoTKznMwX8xk= X-Received: by 2002:ac5:c85c:: with SMTP id g28mr25592892vkm.5.1629813354638; Tue, 24 Aug 2021 06:55:54 -0700 (PDT) MIME-Version: 1.0 References: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> In-Reply-To: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> From: Geert Uytterhoeven Date: Tue, 24 Aug 2021 15:55:43 +0200 Message-ID: Subject: Re: [PATCH] iommu/io-pgtable: Abstract iommu_iotlb_gather access To: Robin Murphy Cc: Will Deacon , Joerg Roedel , Linux IOMMU , Linux ARM , kernel test robot , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Robin, On Fri, Aug 20, 2021 at 3:22 PM Robin Murphy wrote: > Previously io-pgtable merely passed the iommu_iotlb_gather pointer > through to helpers, but now it has grown its own direct dereference. > This turns out to break the build for !IOMMU_API configs where the > structure only has a dummy definition. It will probably also crash > drivers who don't use the gather mechanism and simply pass in NULL. > > Wrap this dereference in a suitable helper which can both be stubbed > out for !IOMMU_API and encapsulate a NULL check otherwise. > > Fixes: 7a7c5badf858 ("iommu: Indicate queued flushes via gather data") Is this the right Fixes tag? The build issue was introduced by: Fixes: a8e5f04458c4e496 ("iommu/io-pgtable: Remove non-strict quirk") > Reported-by: kernel test robot > Signed-off-by: Robin Murphy Thanks, this fixes the build issues I was seeing. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E0CC432BE for ; Tue, 24 Aug 2021 13:56:04 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D1BF610CD for ; Tue, 24 Aug 2021 13:56:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D1BF610CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1BA7460681; Tue, 24 Aug 2021 13:56:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p6_BwVdIlw-J; Tue, 24 Aug 2021 13:56:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id E7C5F606C8; Tue, 24 Aug 2021 13:55:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BC8D4C0010; Tue, 24 Aug 2021 13:55:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 93241C000E for ; Tue, 24 Aug 2021 13:55:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 75E78606C8 for ; Tue, 24 Aug 2021 13:55:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dUkSxN_ppgCi for ; Tue, 24 Aug 2021 13:55:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by smtp3.osuosl.org (Postfix) with ESMTPS id C9DCC60681 for ; Tue, 24 Aug 2021 13:55:55 +0000 (UTC) Received: by mail-vk1-f171.google.com with SMTP id bb10so5528768vkb.9 for ; Tue, 24 Aug 2021 06:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8hP4pVddrWImbh6fCLaXB99hmcWtMRQBThCoTN0H6s=; b=CfVSKgVczCylLBy5TqKS/XrCB712GXP8szZzwa50NcU1BaazhOx10Yr2WGi1BFzw1x tSmBKFPWk3xPmvFr62IXZR67LlsE34TER+l7Fmlvf7LbaLsEVkTrLnzKzlHbNB9EYIOM LztCma8semPmKG1zjMgwhs9Bc/n156km5P2OyDA4oL6LW3wY5KB1qnrBBZ+raexl18iO D9oBfh4BQ5P5Xz0NfXpsLl1Q0xHJinTlF8GxYr857UPItp0Eh1ez7xa7nldUvKN8nhPK r4YvBPrzB+8AWZJVmAEWRC9p8ttheDlmGqcuFw5lFZDtqmJ9OCMUvMDqoo7QzOsJg0Uh 5+FQ== X-Gm-Message-State: AOAM532THJSbBEYjUdgrDC30aUwAhlQjc7a5LnxqkBcOdhFF52QX0cs1 hdOaqXRrlBWKUNEsh3K8OZxVqgqUj46XLWR/nEA= X-Google-Smtp-Source: ABdhPJwOAVxPzgJVnsFrTLNfWZ/oMMEIpSzQrTS/Wb0ggwHzX527BJKiGPZFrjZHNpbcPeMgxnT0ww/YoTKznMwX8xk= X-Received: by 2002:ac5:c85c:: with SMTP id g28mr25592892vkm.5.1629813354638; Tue, 24 Aug 2021 06:55:54 -0700 (PDT) MIME-Version: 1.0 References: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> In-Reply-To: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> From: Geert Uytterhoeven Date: Tue, 24 Aug 2021 15:55:43 +0200 Message-ID: Subject: Re: [PATCH] iommu/io-pgtable: Abstract iommu_iotlb_gather access To: Robin Murphy Cc: kernel test robot , Linux-Renesas , Linux IOMMU , Will Deacon , Linux ARM X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Robin, On Fri, Aug 20, 2021 at 3:22 PM Robin Murphy wrote: > Previously io-pgtable merely passed the iommu_iotlb_gather pointer > through to helpers, but now it has grown its own direct dereference. > This turns out to break the build for !IOMMU_API configs where the > structure only has a dummy definition. It will probably also crash > drivers who don't use the gather mechanism and simply pass in NULL. > > Wrap this dereference in a suitable helper which can both be stubbed > out for !IOMMU_API and encapsulate a NULL check otherwise. > > Fixes: 7a7c5badf858 ("iommu: Indicate queued flushes via gather data") Is this the right Fixes tag? The build issue was introduced by: Fixes: a8e5f04458c4e496 ("iommu/io-pgtable: Remove non-strict quirk") > Reported-by: kernel test robot > Signed-off-by: Robin Murphy Thanks, this fixes the build issues I was seeing. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C94C4338F for ; Tue, 24 Aug 2021 13:58:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9C1261176 for ; Tue, 24 Aug 2021 13:58:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B9C1261176 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nWKAtjUmWy/zHv7BNhv+wc6FE6R51HLOsUnXnQeiYV4=; b=C7Mb3dlgOrBN4W qPAtygbopcbv3n5I2yhQLZTAM61OMtbEF3bMJuxp3H6a2MWZ+1p7ppIaHwxjdp/qpN01vQa/YoMqj 9emJNizrG/SAIBAxlPmCzOINFsUgj7/l+EvKthGFCNfzP3mWuLQ2eEv5mMX0JeKnYekvoH+Msldfs xUeEcCCxnNOZuoTfeJjkN0zdZ0Mnc+6S4c4dGDeGrrPV1c/19A/OYBMvo9pIcMlW7q5SB1jAJkq+L xqrUYLLrRB6ln7tUy0Es51nKg23uEk+x8q+b9erM7MkUCdJaI/S/mTpBJvZTtRvdnIS1AbNKrqB9/ /RyeXITtGE2jhJdUD27g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIWuG-003LfD-TE; Tue, 24 Aug 2021 13:56:01 +0000 Received: from mail-vk1-f178.google.com ([209.85.221.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIWuC-003LdO-4C for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 13:55:57 +0000 Received: by mail-vk1-f178.google.com with SMTP id j26so5487878vkn.4 for ; Tue, 24 Aug 2021 06:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8hP4pVddrWImbh6fCLaXB99hmcWtMRQBThCoTN0H6s=; b=ZJYA1asziG/t9+S4DmOe9lMErYcyhsLYgfeW1udSZD3AnUuEUD1XoHhix/TFAdRep1 9em0GBGknr5IIl5uUghvw8PBNCmhbbNO7khsppCP/sq60eFRki4qX6Hsb6d4AGJDWSby Kx9gO4RoGEHsn0ymVlxQOkXyXGBik4rEoCDRgy+k9QgP5QiMXvrt5NuKBmW5GV0PaE9S 6Va+Dyb5GEj01n/xlfOZyrJjexCZmsaRyYpXgpPW8bnE8dbEwRAszUSlODqSXOs/W5MP P4YIKnaOWmniTM/MXw6bmNmv3ih8WUGk1ww7Dsr+KbxwihEQxWnwthzgC/UquEcwJmgW VGAQ== X-Gm-Message-State: AOAM532D961QbfcCVz1QsVTnzvKQs8Z48uI4OcaZrFJWk4P1WqQ8Db0U QEnvHs1+gNZ1irPlATOy53da8LRgVL1X8r29FDE= X-Google-Smtp-Source: ABdhPJwOAVxPzgJVnsFrTLNfWZ/oMMEIpSzQrTS/Wb0ggwHzX527BJKiGPZFrjZHNpbcPeMgxnT0ww/YoTKznMwX8xk= X-Received: by 2002:ac5:c85c:: with SMTP id g28mr25592892vkm.5.1629813354638; Tue, 24 Aug 2021 06:55:54 -0700 (PDT) MIME-Version: 1.0 References: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> In-Reply-To: <83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com> From: Geert Uytterhoeven Date: Tue, 24 Aug 2021 15:55:43 +0200 Message-ID: Subject: Re: [PATCH] iommu/io-pgtable: Abstract iommu_iotlb_gather access To: Robin Murphy Cc: Will Deacon , Joerg Roedel , Linux IOMMU , Linux ARM , kernel test robot , Linux-Renesas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_065556_226598_06EBCAF8 X-CRM114-Status: GOOD ( 21.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, On Fri, Aug 20, 2021 at 3:22 PM Robin Murphy wrote: > Previously io-pgtable merely passed the iommu_iotlb_gather pointer > through to helpers, but now it has grown its own direct dereference. > This turns out to break the build for !IOMMU_API configs where the > structure only has a dummy definition. It will probably also crash > drivers who don't use the gather mechanism and simply pass in NULL. > > Wrap this dereference in a suitable helper which can both be stubbed > out for !IOMMU_API and encapsulate a NULL check otherwise. > > Fixes: 7a7c5badf858 ("iommu: Indicate queued flushes via gather data") Is this the right Fixes tag? The build issue was introduced by: Fixes: a8e5f04458c4e496 ("iommu/io-pgtable: Remove non-strict quirk") > Reported-by: kernel test robot > Signed-off-by: Robin Murphy Thanks, this fixes the build issues I was seeing. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel