From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC65ECA9EBB for ; Thu, 24 Oct 2019 11:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB8C221655 for ; Thu, 24 Oct 2019 11:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbfJXLp5 (ORCPT ); Thu, 24 Oct 2019 07:45:57 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:34745 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438939AbfJXLp5 (ORCPT ); Thu, 24 Oct 2019 07:45:57 -0400 Received: by mail-oi1-f193.google.com with SMTP id 83so20341217oii.1; Thu, 24 Oct 2019 04:45:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xapP1tQVHBFB4u5IRo6bt1XmdgDLSW79Eo21jhd+1ys=; b=nKKitKBFfQliYORkF6LbkqaGtHQ1U88yd8yLJUYHhm4OdFsk9ukOyOukGSuSNP7fB+ y5Y/be9GePk+mKJd0x7APc+NAK0hjuxJOsL9sz3a0s4/Fy6rxFTRn1LhsGSFayfVEJiy 3h4TUBARcNmJNMuCp6aU2zCYU2Zn0Jlj9f7NQyNyo98GP0S0oJ3m5B6tVY0IVWyic6Nw xT7MIl9a9A9o8oUJhPkqHv0uBSyHJXsFdCDKRjUL2KLv52kQaq/vvmuzg4UrQ/nzQDZ5 ggIEfzoSG4cPEBWP8wp7dFPQf+WAedDfIbmkRmOWvFCu39HBWa3DD5e2gvSg5bcPe/Fc 7N4w== X-Gm-Message-State: APjAAAUAl9GPHSXOa+jkj7yafy4N33OGWxHrAOry2HT2xC5QbJHVcT+r So9Ak4qvFYAphLZEWZ/OZT+0nLB98gef+w34aDM= X-Google-Smtp-Source: APXvYqyYrTTKmO7hOqrCTJfyf96D1kruRxrWcBoOiIEfJhdm5CfrfxUVO0e52Qb0mTkw6VqHzQVre7gs5e1H2KbWLpI= X-Received: by 2002:aca:882:: with SMTP id 124mr4319026oii.54.1571917556040; Thu, 24 Oct 2019 04:45:56 -0700 (PDT) MIME-Version: 1.0 References: <1571915821-1620-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1571915821-1620-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1571915821-1620-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Geert Uytterhoeven Date: Thu, 24 Oct 2019 13:45:45 +0200 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix clock[-name]s properties To: Yoshihiro Shimoda Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Geert Uytterhoeven , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Shimoda-san, On Thu, Oct 24, 2019 at 1:17 PM Yoshihiro Shimoda wrote: > Since the hardware requires to enable both USB 2.0 host and peripheral > functional clock, this patch fixes the documentation. > Fortunately, no one has this device node for now, so that we don't > need to think of backward compatibility. > > Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY") > Signed-off-by: Yoshihiro Shimoda Thanks four your patch! Looks good to me, so Reviewed-by: Geert Uytterhoeven I'm just wondering about the inconsistent use of "_" and "-" in clock names, but I don't have a better suggestion ("hs-usb-if", "usb_extal", and "usb_xtal" do match the datasheet), so let's ignore my OCD ;-) > --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > @@ -38,7 +38,8 @@ Required properties: > - reg: offset and length of the USB 2.0 clock selector register block. > - clocks: A list of phandles and specifier pairs. > - clock-names: Name of the clocks. > - - The functional clock must be "ehci_ohci" > + - The functional clock of USB 2.0 host side must be "ehci_ohci" "_" means "and". > + - The functional clock of HS-USB side must be "hs-usb-if" "-" means concatenation of terms. > - The USB_EXTAL clock pin must be "usb_extal" > - The USB_XTAL clock pin must be "usb_xtal" "_" means concatenation of terms. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds