From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, netdev <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH/RFC] dt-bindings: net: renesas,etheravb: Convert to json-schema
Date: Mon, 22 Jun 2020 22:09:43 +0200 [thread overview]
Message-ID: <CAMuHMdXN1o9iG+CM-S5DaikkD_W7zyYAwRpZbEE39EY8PjWHLw@mail.gmail.com> (raw)
In-Reply-To: <8d90ef9a-32d3-659f-f808-5d62d1d7ac6d@cogentembedded.com>
Hi Sergei,
On Mon, Jun 22, 2020 at 10:04 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 06/21/2020 11:17 AM, Geert Uytterhoeven wrote:
> > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding
> > documentation to json-schema.
> >
> > Add missing properties.
> > Update the example to match reality.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> As I'm only seeing the formatting issues, here's my:
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thank you!
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> > @@ -0,0 +1,269 @@
> [...]
> > +maintainers:
> > + - Sergei Shtylyov <sergei.shtylyov@gmail.com>
>
> Thank you! :-)
You're (very) welcome ;-)
>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - renesas,etheravb-r8a7742 # RZ/G1H
> > + - renesas,etheravb-r8a7743 # RZ/G1M
> > + - renesas,etheravb-r8a7744 # RZ/G1N
> > + - renesas,etheravb-r8a7745 # RZ/G1E
> > + - renesas,etheravb-r8a77470 # RZ/G1C
> > + - renesas,etheravb-r8a7790 # R-Car H2
> > + - renesas,etheravb-r8a7791 # R-Car M2-W
> > + - renesas,etheravb-r8a7792 # R-Car V2H
> > + - renesas,etheravb-r8a7793 # R-Car M2-N
> > + - renesas,etheravb-r8a7794 # R-Car E2
>
> Hm, overindented starting with "- items:"?
I believe this is consistent with e.g. commit 9f60a65bc5e6cd88
("dt-bindings: Clean-up schema indentation formatting").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2020-06-22 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 8:17 [PATCH/RFC] dt-bindings: net: renesas,etheravb: Convert to json-schema Geert Uytterhoeven
2020-06-22 20:04 ` Sergei Shtylyov
2020-06-22 20:09 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXN1o9iG+CM-S5DaikkD_W7zyYAwRpZbEE39EY8PjWHLw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.