From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B56E5C433DF for ; Mon, 22 Jun 2020 20:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98FE020767 for ; Mon, 22 Jun 2020 20:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730820AbgFVUKC (ORCPT ); Mon, 22 Jun 2020 16:10:02 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:43516 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730802AbgFVUJz (ORCPT ); Mon, 22 Jun 2020 16:09:55 -0400 Received: by mail-oi1-f194.google.com with SMTP id j189so16756559oih.10; Mon, 22 Jun 2020 13:09:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OiePC4i/uqD+1c3W+5eApnEHXPxElxi4Y3ejQe4iWbM=; b=SOcV7Ek+XJl/Z5MySWcz+Gj4FJ4CjEth1z+Y0TMrw7vjGuYTBqQwcplHBnyF87avJR OfclI33KAc+s8FcncurRU61LFwPiwQw/PNApMExA7FMDpwEqAXYEZP0rR9+whHH9wyz5 vQCTgH+H6z+i9los66XxsC7URxfvwXtbN07FCMWSENuU9D9Z819t2UZ+WAYFUfYSEKXz DogsY4ayz1DE2rbWmpJmR3miatx2JqncNJUt03ypP8OSFreKueTPOZXE5mJjDLq7JPrU m9d8jw5G6UGeyZoZ03GIGdVLUyx2j8k4mU0e9Ezl+BBPtm+L5TlvPzAZC6Vvaz9zyImt Vs+g== X-Gm-Message-State: AOAM533r80KqgqVw/21t7oNCbdoCo7EKIax9LEPSRsWb9IQ8OtjRRNel +drmHRSAE3/lhpCQLpIFoLTKbEiCorrfKyqGHEm46onF X-Google-Smtp-Source: ABdhPJwm8jCWTZ8wTPreeBQUXPLsl6F4YxPDq2wFJCIfu8r7ux3hmF4g5TPzSR2txESMgnjTGIt4VHqMIsRVL+CEsfw= X-Received: by 2002:aca:1a19:: with SMTP id a25mr13968777oia.54.1592856594434; Mon, 22 Jun 2020 13:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20200621081710.10245-1-geert+renesas@glider.be> <8d90ef9a-32d3-659f-f808-5d62d1d7ac6d@cogentembedded.com> In-Reply-To: <8d90ef9a-32d3-659f-f808-5d62d1d7ac6d@cogentembedded.com> From: Geert Uytterhoeven Date: Mon, 22 Jun 2020 22:09:43 +0200 Message-ID: Subject: Re: [PATCH/RFC] dt-bindings: net: renesas,etheravb: Convert to json-schema To: Sergei Shtylyov Cc: "David S . Miller" , Jakub Kicinski , Rob Herring , netdev , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Sergei, On Mon, Jun 22, 2020 at 10:04 PM Sergei Shtylyov wrote: > On 06/21/2020 11:17 AM, Geert Uytterhoeven wrote: > > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding > > documentation to json-schema. > > > > Add missing properties. > > Update the example to match reality. > > > > Signed-off-by: Geert Uytterhoeven > > As I'm only seeing the formatting issues, here's my: > > Reviewed-by: Sergei Shtylyov Thank you! > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > > @@ -0,0 +1,269 @@ > [...] > > +maintainers: > > + - Sergei Shtylyov > > Thank you! :-) You're (very) welcome ;-) > > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - renesas,etheravb-r8a7742 # RZ/G1H > > + - renesas,etheravb-r8a7743 # RZ/G1M > > + - renesas,etheravb-r8a7744 # RZ/G1N > > + - renesas,etheravb-r8a7745 # RZ/G1E > > + - renesas,etheravb-r8a77470 # RZ/G1C > > + - renesas,etheravb-r8a7790 # R-Car H2 > > + - renesas,etheravb-r8a7791 # R-Car M2-W > > + - renesas,etheravb-r8a7792 # R-Car V2H > > + - renesas,etheravb-r8a7793 # R-Car M2-N > > + - renesas,etheravb-r8a7794 # R-Car E2 > > Hm, overindented starting with "- items:"? I believe this is consistent with e.g. commit 9f60a65bc5e6cd88 ("dt-bindings: Clean-up schema indentation formatting"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds