From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BC9C3A589 for ; Tue, 20 Aug 2019 07:53:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3CAC23980 for ; Tue, 20 Aug 2019 07:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729327AbfHTHx4 (ORCPT ); Tue, 20 Aug 2019 03:53:56 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:38264 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfHTHx4 (ORCPT ); Tue, 20 Aug 2019 03:53:56 -0400 Received: by mail-ot1-f65.google.com with SMTP id r20so4205421ota.5; Tue, 20 Aug 2019 00:53:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UeZCihW1/iCQp+6FgwvqZaN1t+fpmStZoau36fwpTT8=; b=ZcVGvaSAGQrN4uT3ztogRXOfPbA6d1SWR+qB08WUrdwOn2HhI9CFmEQBI1gsqrp/aB fEX3QWhoORcSJm5DpGulntyWw4zEBJvBEt+YkYYp2hNOODup5S9uVvwOSLqtKVZUYZec /3U2rUVl31+D8fOf5p16UKiy8lUO5+O5gjdfvcCJEQMbQDlrD8RRr55wnZc/uk/BY2GO e8/OsibTisFzBvM+2yIawKAOXKQFJpx2hXcDTlZiuAcemBxLo3ELcGsysoEPZSHRnGCs VOWy8DNZEhbjoNHBxisQLQUo0XaTz5OOSvXsF67l5E+PzOiiCl6ySZXwowFdU/+uoOVG uYmQ== X-Gm-Message-State: APjAAAUckgRkovPiFkq25Mu5mtg0ZB6MUxjPlXpctSZy+ouPa53yWOSa WtmAXKVxMwC+tWqYnweScq8/E2HAYHZm/wWNPgM= X-Google-Smtp-Source: APXvYqxi285mUlLiZy1iYv/ah5Dqi221sPkvqG1lYm/S6M3NNg6Amld+nigmYA87ocdOf24hemH7ijB43JtXkfCd1Yc= X-Received: by 2002:a9d:68c5:: with SMTP id i5mr21320045oto.250.1566287635275; Tue, 20 Aug 2019 00:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-2-jacopo+renesas@jmondi.org> <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> In-Reply-To: <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> From: Geert Uytterhoeven Date: Tue, 20 Aug 2019 09:53:44 +0200 Message-ID: Subject: Re: [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation To: Jacopo Mondi Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tue, Aug 20, 2019 at 9:47 AM Jacopo Mondi wrote: > On Mon, Aug 19, 2019 at 03:45:54PM +0200, Geert Uytterhoeven wrote: > > On Mon, Jul 8, 2019 at 9:58 AM Geert Uytterhoeven wrote: > > > On Sat, Jul 6, 2019 at 4:07 PM Jacopo Mondi wrote: > > > > Add device tree bindings documentation for the Renesas R-Car Display > > > > Unit Color Management Module. > > > > > > > > CMM is the image enhancement module available on each R-Car DU video > > > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > > > > > Signed-off-by: Jacopo Mondi > > > > Reviewed-by: Laurent Pinchart > > > > > > Thanks for your patch! > > > > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > > > @@ -0,0 +1,25 @@ > > > > +* Renesas R-Car Color Management Module (CMM) > > > > + > > > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > > > + > > > > +Required properties: > > > > + - compatible: shall be one of: > > > > + - "renesas,rcar-gen3-cmm" > > > > + - "renesas,rcar-gen2-cmm" > > > > > > Why do you think you do not need SoC-specific compatible values? > > > What if you discover a different across the R-Car Gen3 line tomorrow? > > > Does the IP block have a version register? > > > > Do you have an answer to these questions? > > It does not seem to me that CMM has any version register, nor there > are differences between the different Gen3 SoCs.. > > However, even if we now define a single compatible property for > gen3/gen2 and we later find out one of the SoC needs a soc-specific > property we can safely add it and keep the generic gen3/gen2 one as > fallback.. Does it work for you? Unfortunately that won't work, as the existing DTBs won't have the soc-specific compatible value. You could still resort to soc_device_match(), but it is better to avoid that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds