From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C8BC433FE for ; Sat, 5 Dec 2020 18:56:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F5EF23110 for ; Sat, 5 Dec 2020 18:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726126AbgLES4w (ORCPT ); Sat, 5 Dec 2020 13:56:52 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:44710 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgLES4u (ORCPT ); Sat, 5 Dec 2020 13:56:50 -0500 Received: by mail-oi1-f195.google.com with SMTP id y74so10352050oia.11; Sat, 05 Dec 2020 10:56:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQtR4knxF9KByD/iY44zLsA9by1I5dlTuq9qeppHzvY=; b=iVxwVIxKld1QCWGWkC2ZVDV4C7QNrkgiU38xmPnpme8pnBUHiqbmLf1hDAiwmas7Gh 0qtZFdpTwXiQgcSk+xqc8DOUzEUWzCD6GyEX61FvgB6E+2VH3+4EbJZrxqsVq3vGsbCe +lRLESJAf9fQz2Oazbze97F/ADnLTay3fncdT1Mw22ddRIN/QJdeGAvOVwU7Yzh+h+XL 1D1kBXcEENOyzDY1e3UZ85NUyPQ2pa3zPNJQ/1juDyFrr1I8JSFMrsfQm1Iq5dXgwqQQ dZaQm7k5M4gXStozxblyE5u/xIhtWhDxaM0sIUml4H7Ubuf89FBxbyYwlvum//d9XDCl 4pJQ== X-Gm-Message-State: AOAM533xReTVfBRPjBD/bs8a2k8kwCpd1GCJyjPdCZ7ayXtnYbF2UOBq kLHpeb0h+M0VEd5ZFUqySsbciY7LKXM45g/7WwM= X-Google-Smtp-Source: ABdhPJzdYo86jSPqFfWWPZ+5RBOxy73Z1igjnd4bfIsRT2BWRV1LO6NsOIadR4OC07uZKTBKNm5m95Kc4MdxoBsSoUw= X-Received: by 2002:aca:ec09:: with SMTP id k9mr7227622oih.153.1607194569232; Sat, 05 Dec 2020 10:56:09 -0800 (PST) MIME-Version: 1.0 References: <20201205183355.6488-1-michael.srba@seznam.cz> <20201205183355.6488-3-michael.srba@seznam.cz> In-Reply-To: <20201205183355.6488-3-michael.srba@seznam.cz> From: Geert Uytterhoeven Date: Sat, 5 Dec 2020 19:55:58 +0100 Message-ID: Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node To: michael.srba@seznam.cz Cc: Dave Stevenson , Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , Linux Media Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, On Sat, Dec 5, 2020 at 7:36 PM wrote: > From: Michael Srba > > This patch adds the clock-frequency property to all device trees that use > the imx219 binding, with the value of exactly 24Mhz which was previously > implicitly assumed. > > Signed-off-by: Michael Srba Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > @@ -82,6 +82,7 @@ imx219: imx219@10 { > compatible = "sony,imx219"; > reg = <0x10>; > clocks = <&osc25250_clk>; > + clock-frequency = <24000000>; > VANA-supply = <&imx219_vana_2v8>; > VDIG-supply = <&imx219_vdig_1v8>; > VDDL-supply = <&imx219_vddl_1v2>; > diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > index f0829e905506..db4b801b17b5 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > @@ -59,6 +59,7 @@ &imx219 { > port { > imx219_ep: endpoint { > clock-lanes = <0>; > + clock-frequency = <24000000>; Why is this change needed? This is not the imx219 node, but its endpoint subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi). > data-lanes = <1 2>; > link-frequencies = /bits/ 64 <456000000>; > /* uncomment remote-endpoint property to tie imx219 to - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33F6C4361A for ; Sat, 5 Dec 2020 18:57:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B82F2310B for ; Sat, 5 Dec 2020 18:57:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B82F2310B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hkz7IbV+vtS5ZaZL1Y6rvoodK1asYCd4KNN+hMse1Hk=; b=2GfEwE7mJH4MkOrIoQQeCrqEO VLS9O74JP5+kHAkCQas7kMydvlZvSJNJS0opQ5XkgeVwODy48rXf3hd+jt103TlWJI3R9MMgGgM7V W1A9AG2EWGu0Ai+y4SPZIlYmxO9RYWRhISdZIGKQxyt6/HL2TWL4g0y9WFHC+soRfW2EkWNxJK4z2 ehrwCchUmZ/AFzD6i9VRbK/UMEwVI9d4+b+UQf9PfyW8yKih0j8SWzNXb3Po+lHuuuaoYS2btkTuJ IQ9R5MDp3mB3wpEACEn37ROC6QvXS5Ya+RsVojjyt608DvNW50aNCGlSGE7UoZdQ/ejG0/CDJe05J 6XRzfOuhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klcj6-0002ha-9p; Sat, 05 Dec 2020 18:56:12 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klcj4-0002gt-66 for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 18:56:10 +0000 Received: by mail-oi1-f196.google.com with SMTP id k2so10363629oic.13 for ; Sat, 05 Dec 2020 10:56:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQtR4knxF9KByD/iY44zLsA9by1I5dlTuq9qeppHzvY=; b=YsGjRXOuT6vyusSdhpCakQ637q+1Dy0jo7m4V82YbigG/EzLiaFpxtJoKFfIWkgTjF 8AVb2VHFF8Y/Ybq+GBDcKZ2MK0Ry1eP9yEcvC/pVO1S+kZ/av2+e6JeU+EH3U35nEtZK A905xhdgtw25bqS4oFrhTjDET899m9iAxoCSFGjRUJkDOoqnqsmQlqEAkSImjNUL33pC 2VKkLk+aAvr8GiCe9cR1Eekuw4tkqeWplWRCZ336kfp4Iw2Tz1O7bdLING0eRQjmsAyo HrMTitILkooUtNSJl6HAZZ/EWH5L6tIV7LtrewSTI4FCP6n6oR8WvOl7eiwo6b+hv05a YRtA== X-Gm-Message-State: AOAM530eV3Ia8zEZbaoEMQidMlIlx2wVOjRUwAH1n7W2Bn+xvXBYcMrS 9a9YOb9a2rwKetgXpkuutr7IEdnHQzBlLj30iYc= X-Google-Smtp-Source: ABdhPJzdYo86jSPqFfWWPZ+5RBOxy73Z1igjnd4bfIsRT2BWRV1LO6NsOIadR4OC07uZKTBKNm5m95Kc4MdxoBsSoUw= X-Received: by 2002:aca:ec09:: with SMTP id k9mr7227622oih.153.1607194569232; Sat, 05 Dec 2020 10:56:09 -0800 (PST) MIME-Version: 1.0 References: <20201205183355.6488-1-michael.srba@seznam.cz> <20201205183355.6488-3-michael.srba@seznam.cz> In-Reply-To: <20201205183355.6488-3-michael.srba@seznam.cz> From: Geert Uytterhoeven Date: Sat, 5 Dec 2020 19:55:58 +0100 Message-ID: Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node To: michael.srba@seznam.cz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_135610_237732_3B63A8FC X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Dave Stevenson , Fabio Estevam , Sascha Hauer , Magnus Damm , Linux-Renesas , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Linux ARM , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, On Sat, Dec 5, 2020 at 7:36 PM wrote: > From: Michael Srba > > This patch adds the clock-frequency property to all device trees that use > the imx219 binding, with the value of exactly 24Mhz which was previously > implicitly assumed. > > Signed-off-by: Michael Srba Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi > @@ -82,6 +82,7 @@ imx219: imx219@10 { > compatible = "sony,imx219"; > reg = <0x10>; > clocks = <&osc25250_clk>; > + clock-frequency = <24000000>; > VANA-supply = <&imx219_vana_2v8>; > VDIG-supply = <&imx219_vdig_1v8>; > VDDL-supply = <&imx219_vddl_1v2>; > diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > index f0829e905506..db4b801b17b5 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts > @@ -59,6 +59,7 @@ &imx219 { > port { > imx219_ep: endpoint { > clock-lanes = <0>; > + clock-frequency = <24000000>; Why is this change needed? This is not the imx219 node, but its endpoint subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi). > data-lanes = <1 2>; > link-frequencies = /bits/ 64 <456000000>; > /* uncomment remote-endpoint property to tie imx219 to - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel