From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Date: Mon, 5 Dec 2011 19:15:46 +0100 Message-ID: References: <20111110162859.GA7088@oksana.dev.rtsoft.ru> <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:49422 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756427Ab1LESPs convert rfc822-to-8bit (ORCPT ); Mon, 5 Dec 2011 13:15:48 -0500 In-Reply-To: <20111205180253.GB29812@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Dave Martin Cc: Nicolas Pitre , Russell King - ARM Linux , Benjamin Herrenschmidt , Linus Torvalds , Anton Vorontsov , Alan Cox , Stephen Rothwell , Andrew Morton , devicetree-discuss@lists.ozlabs.org, LKML , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, Ingo Molnar , Jeff Garzik , Pawel Moll , linux-arm-kernel@lists.infradead.org On Mon, Dec 5, 2011 at 19:02, Dave Martin wrot= e: > Unfortunately, NO_IRQ is often not spelled "NO_IRQ". =C2=A0It looks l= ike the assumption > "irq < 0 =3D=3D=3D no irq" may be quite a lot more widespread than "N= O_IRQ =3D=3D=3D no irq". Can we make irq unsigned, and hope the compiler catches all of them (comparison always false blah blah blah)? Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Mon, 5 Dec 2011 19:15:46 +0100 Subject: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver In-Reply-To: <20111205180253.GB29812@localhost.localdomain> References: <20111110162859.GA7088@oksana.dev.rtsoft.ru> <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 5, 2011 at 19:02, Dave Martin wrote: > Unfortunately, NO_IRQ is often not spelled "NO_IRQ". ?It looks like the assumption > "irq < 0 === no irq" may be quite a lot more widespread than "NO_IRQ === no irq". Can we make irq unsigned, and hope the compiler catches all of them (comparison always false blah blah blah)? Gr{oetje,eeting}s, ? ? ? ? ? ? ? ? ? ? ? ? Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. ? ? ? ? ? ? ? ? ? ? ? ? ? ?? ?? -- Linus Torvalds