From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 04 Dec 2017 09:46:22 +0000 Subject: Re: [PATCH/RFC 5/5] ARM: shmobile: defconfig: Disable CONFIG_EMBEDDED Message-Id: List-Id: References: <1512047522-16312-1-git-send-email-geert+renesas@glider.be> <1512047522-16312-6-git-send-email-geert+renesas@glider.be> <20171201083305.5vhvr6dfrbzemqgc@verge.net.au> In-Reply-To: <20171201083305.5vhvr6dfrbzemqgc@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Magnus Damm , Yoshinori Sato , Rich Felker , Jiri Slaby , "linux-serial@vger.kernel.org" , Linux-Renesas , "moderated list:H8/300 ARCHITECTURE" , Linux-sh list Hi Simon, On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman wrote: > On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: >> CONFIG_EXPERT exposes too many config options that do not matter for >> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it >> cannot be disabled. >> >> Hence disable CONFIG_EMBEDDED, and compensate for the loss of >> CONFIG_DEBUG_KERNEL by enabling the latter. >> >> Actual impact: >> - CONFIG_NAMESPACES=y, >> - CONFIG_SYSCTL_SYSCALL=n, >> - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, >> - CONFIG_SERIAL_SH_SCI_EARLYCON=y, >> - Some HID support became enabled, >> - CONFIG_DEBUG_MEMORY_INIT=y, >> >> Refresh the result. > > I'm sorry but I don't understand the motivation for this change. > I understand that it might make the image smaller or build times faster. > But it seems to be a risky change for those benefits. My main motivation is to start using the default values for the various SH_SCI options from the first 4 patches, but that requires disabling CONFIG_EXPERT. Sorry for not making that clearer. > What are the side-effects of the changes you describe above? Enabling CONFIG_NAMESPACES shouldn't hurt (isn't that also needed for systemd anyway?), just like the HID devices, or CONFIG_DEBUG_MEMORY_INIT (it does a few more checks, and defaults to yes). Disabling CONFIG_SYSCTL_SYSCALL also shouldn't hurt (it defaults to no), except for very old userland not yet using /proc/sys, which might have been broken along the way by changed binary paths anyway. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f181.google.com ([209.85.216.181]:37309 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbdLDJqY (ORCPT ); Mon, 4 Dec 2017 04:46:24 -0500 MIME-Version: 1.0 In-Reply-To: <20171201083305.5vhvr6dfrbzemqgc@verge.net.au> References: <1512047522-16312-1-git-send-email-geert+renesas@glider.be> <1512047522-16312-6-git-send-email-geert+renesas@glider.be> <20171201083305.5vhvr6dfrbzemqgc@verge.net.au> From: Geert Uytterhoeven Date: Mon, 4 Dec 2017 10:46:22 +0100 Message-ID: Subject: Re: [PATCH/RFC 5/5] ARM: shmobile: defconfig: Disable CONFIG_EMBEDDED To: Simon Horman Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Magnus Damm , Yoshinori Sato , Rich Felker , Jiri Slaby , "linux-serial@vger.kernel.org" , Linux-Renesas , "moderated list:H8/300 ARCHITECTURE" , Linux-sh list Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Simon, On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman wrote: > On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: >> CONFIG_EXPERT exposes too many config options that do not matter for >> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it >> cannot be disabled. >> >> Hence disable CONFIG_EMBEDDED, and compensate for the loss of >> CONFIG_DEBUG_KERNEL by enabling the latter. >> >> Actual impact: >> - CONFIG_NAMESPACES=y, >> - CONFIG_SYSCTL_SYSCALL=n, >> - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, >> - CONFIG_SERIAL_SH_SCI_EARLYCON=y, >> - Some HID support became enabled, >> - CONFIG_DEBUG_MEMORY_INIT=y, >> >> Refresh the result. > > I'm sorry but I don't understand the motivation for this change. > I understand that it might make the image smaller or build times faster. > But it seems to be a risky change for those benefits. My main motivation is to start using the default values for the various SH_SCI options from the first 4 patches, but that requires disabling CONFIG_EXPERT. Sorry for not making that clearer. > What are the side-effects of the changes you describe above? Enabling CONFIG_NAMESPACES shouldn't hurt (isn't that also needed for systemd anyway?), just like the HID devices, or CONFIG_DEBUG_MEMORY_INIT (it does a few more checks, and defaults to yes). Disabling CONFIG_SYSCTL_SYSCALL also shouldn't hurt (it defaults to no), except for very old userland not yet using /proc/sys, which might have been broken along the way by changed binary paths anyway. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds