From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <1528984088-24801-1-git-send-email-geert+renesas@glider.be> <1528984088-24801-3-git-send-email-geert+renesas@glider.be> <20180626195747.GB30143@rob-hp-laptop> <20180627151030.o2peqxdnesni3wfi@verge.net.au> In-Reply-To: <20180627151030.o2peqxdnesni3wfi@verge.net.au> From: Geert Uytterhoeven Date: Wed, 27 Jun 2018 18:40:51 +0200 Message-ID: Subject: Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses Content-Type: text/plain; charset="UTF-8" To: Simon Horman Cc: Rob Herring , Geert Uytterhoeven , Mark Rutland , Kieran Bingham , Laurent Pinchart , Mauro Carvalho Chehab , Magnus Damm , Shawn Guo , Sascha Hauer , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Media Mailing List , Linux-Renesas List-ID: Hi Simon, On Wed, Jun 27, 2018 at 5:10 PM Simon Horman wrote: > On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote: > > On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote: > > > With recent dtc and W=1: > > > > > > ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a" > > > ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b" > > > > > > Unit addresses are always hexadecimal (without prefix), while the bases > > > of reg property values depend on their prefixes. > > > > > > Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support") > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Rob Herring > > Geert, shall I apply this? I'd say yes. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds