From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 14 Dec 2015 09:39:47 +0000 Subject: Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree Message-Id: List-Id: References: <1449802376-11301-1-git-send-email-horms+renesas@verge.net.au> <1449802376-11301-4-git-send-email-horms+renesas@verge.net.au> <566AB2A5.4090105@cogentembedded.com> <20151214021110.GD13945@verge.net.au> <20151214071103.GC1516@katana> In-Reply-To: <20151214071103.GC1516@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon, Dec 14, 2015 at 8:11 AM, Wolfram Sang wrote: >> > >+ eeprom@50 { >> > >+ compatible = "renesas,24c02"; >> > >> > This is not a valid value -- the Renesas chip model is different from 24c02. >> >> I copied this value from r8a7791.dtsi. >> >> Looking at the schematic for gose (v100), koelsch (rev024) and porter (v300) >> I see the following "R1EX24002ATAS0G#U0". Shall we update r8a7791 and >> this patch to "renesas,24002" or leave things as is? > > I wouldn't like to update the at24 driver with all namings from all > vendors for chips which in large cases are simple 24c02 devices. > > So, if Sergei insists on the change, I'd propose > > compatible = "renesas,24002", "24c02"; "renesas,r1ex24002"? I don't think the "A" is relevant (<= 64 is A, >= 128 is B). http://www.renesas.com/products/memory/eeprom/product_selector.jsp Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Mon, 14 Dec 2015 10:39:47 +0100 Subject: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree In-Reply-To: <20151214071103.GC1516@katana> References: <1449802376-11301-1-git-send-email-horms+renesas@verge.net.au> <1449802376-11301-4-git-send-email-horms+renesas@verge.net.au> <566AB2A5.4090105@cogentembedded.com> <20151214021110.GD13945@verge.net.au> <20151214071103.GC1516@katana> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 14, 2015 at 8:11 AM, Wolfram Sang wrote: >> > >+ eeprom at 50 { >> > >+ compatible = "renesas,24c02"; >> > >> > This is not a valid value -- the Renesas chip model is different from 24c02. >> >> I copied this value from r8a7791.dtsi. >> >> Looking at the schematic for gose (v100), koelsch (rev024) and porter (v300) >> I see the following "R1EX24002ATAS0G#U0". Shall we update r8a7791 and >> this patch to "renesas,24002" or leave things as is? > > I wouldn't like to update the at24 driver with all namings from all > vendors for chips which in large cases are simple 24c02 devices. > > So, if Sergei insists on the change, I'd propose > > compatible = "renesas,24002", "24c02"; "renesas,r1ex24002"? I don't think the "A" is relevant (<= 64 is A, >= 128 is B). http://www.renesas.com/products/memory/eeprom/product_selector.jsp Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds