All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats
Date: Sun, 10 Jul 2022 14:15:01 +0200	[thread overview]
Message-ID: <CAMuHMdXa=Qkq_vp_FhNCa9jY7XrfCbtFf8wBEqkYGTUEO=SWjg@mail.gmail.com> (raw)
In-Reply-To: <Ysqsm6l9z09n0PRq@ravnborg.org>

Hi Sam,

On Sun, Jul 10, 2022 at 12:40 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Fri, Jul 08, 2022 at 08:21:30PM +0200, Geert Uytterhoeven wrote:
> > A long outstanding issue with the DRM subsystem has been the lack of
> > support for low-color displays, as used typically on older desktop
> > systems, and on small embedded displays.
> >
> > This patch series adds support for color-indexed frame buffer formats
> > with 2, 4, and 16 colors.  It has been tested on ARAnyM using a
> > work-in-progress Atari DRM driver.
> >
> > Changes compared to v1:
> >   - SMPTE color LUT accuracy,
> >   - Factor out smpte color LUT,
> >   - Restructure patches,
> >   - Improve descriptions.
> >   - Store number of colors for indexed formats,
> >   - Add SMPTE pattern support for the C1 and C2 formats.
> >
> > Please refer to [2] for related Linux DRM patches and background
> > information.
> >
> > Thanks for your comments!
> >
> > [1] "[PATCH libdrm 0/3] Add support for low-color frame buffer formats"
> >     https://lore.kernel.org/r/cover.1646683737.git.geert@linux-m68k.org
> > [2] "[PATCH v3 00/10] drm: Add support for low-color frame buffer formats"
> >     https://lore.kernel.org/r/cover.1657294931.git.geert@linux-m68k.org
> >
> > Geert Uytterhoeven (10):
> >   util: Improve SMPTE color LUT accuracy
> >   util: Factor out and optimize C8 SMPTE color LUT
> >   [RFC] drm_fourcc: Add DRM_FORMAT_C[124]
> >   util: Add support for DRM_FORMAT_C[124]
> >   util: Store number of colors for indexed formats
> >   util: Add SMPTE pattern support for C4 format
> >   util: Add SMPTE pattern support for C1 format
> >   util: Add SMPTE pattern support for C2 format
> >   modetest: Add support for DRM_FORMAT_C[124]
> >   modetest: Add SMPTE pattern support for C4 format
>
> I have browsed the patches - everything looked good.
> The parts with Floyd-Steinberg dithering did get less
> attention as I do not know it.

As a picture says more than 10000 words, I shared screenshots of
modetest showing the SMPTE pattern in C1 (monochrome FS-dithered
[1]), C2 (PenTile RG-GB FS-dithered [2]), and C4 ([3]).
And Wikipedia[4] is your friend for the algorithm ;-)

> But everything looked good and the series is:
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks!

[1] https://drive.google.com/file/d/1waJczErrIaEKRhBCCU1ynxRG8agpo0Xx/view?usp=sharing
[2] https://drive.google.com/file/d/1g5O8XeacrjrC8rgaVENvR65YeI6QvmtO/view?usp=sharing
[3] https://drive.google.com/file/d/1VIMqz_OkjJbbFS2OCX1O8GBm4bag6y2n/view?usp=sharing
[4] https://en.wikipedia.org/wiki/Floyd%E2%80%93Steinberg_dithering

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2022-07-10 12:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 18:21 [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy Geert Uytterhoeven
2022-07-10 10:31   ` Sam Ravnborg
2022-07-10 11:04     ` Geert Uytterhoeven
2022-07-10 11:55       ` Sam Ravnborg
2022-07-12  9:05         ` Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 02/10] util: Factor out and optimize C8 SMPTE color LUT Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH/RFC libdrm v2 03/10] drm_fourcc: Add DRM_FORMAT_C[124] Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 04/10] util: Add support for DRM_FORMAT_C[124] Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 05/10] util: Store number of colors for indexed formats Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 06/10] util: Add SMPTE pattern support for C4 format Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 07/10] util: Add SMPTE pattern support for C1 format Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 08/10] util: Add SMPTE pattern support for C2 format Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 09/10] modetest: Add support for DRM_FORMAT_C[124] Geert Uytterhoeven
2022-07-08 18:21 ` [PATCH libdrm v2 10/10] modetest: Add SMPTE pattern support for C4 format Geert Uytterhoeven
2022-07-10 10:40 ` [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats Sam Ravnborg
2022-07-10 12:15   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXa=Qkq_vp_FhNCa9jY7XrfCbtFf8wBEqkYGTUEO=SWjg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.