Re: [PATCH v3 6/6] can: rcar_canfd: Add has_gerfl_eef to struct rcar_canfd_hw_info

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: biju.das.jz@bp.renesas.com
Cc: "Wolfgang Grandegger" <wg@grandegger.com>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
	"Stefan Mätje" <stefan.maetje@esd.eu>,
	"Ulrich Hecht" <uli+renesas@fpond.eu>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Chris Paterson" <Chris.Paterson2@renesas.com>,
	"Biju Das" <biju.das@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 6/6] can: rcar_canfd: Add has_gerfl_eef to struct rcar_canfd_hw_info
Date: Fri, 28 Oct 2022 12:12:22 +0200	[thread overview]
Message-ID: <CAMuHMdXayck0o9=Oc2+X7pDSx=Y+SHHdi3QtmYz+U-rumpc92Q@mail.gmail.com> (raw)
In-Reply-To: <20221027082158.95895-7-biju.das.jz@bp.renesas.com>

Hi Biju,

On Thu, Oct 27, 2022 at 10:22 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> R-Car has ECC error flags in global error interrupts whereas it is
> not available on RZ/G2L.
>
> Add has_gerfl_eef to struct rcar_canfd_hw_info so that rcar_canfd_
> global_error() will process ECC errors only for R-Car.
>
> whilst, this patch fixes the below checkpatch warnings
>   CHECK: Unnecessary parentheses around 'ch == 0'
>   CHECK: Unnecessary parentheses around 'ch == 1'
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -955,13 +958,15 @@ static void rcar_canfd_global_error(struct net_device *ndev)
>         u32 ridx = ch + RCANFD_RFFIFO_IDX;
>
>         gerfl = rcar_canfd_read(priv->base, RCANFD_GERFL);
> -       if ((gerfl & RCANFD_GERFL_EEF0) && (ch == 0)) {
> -               netdev_dbg(ndev, "Ch0: ECC Error flag\n");
> -               stats->tx_dropped++;
> -       }
> -       if ((gerfl & RCANFD_GERFL_EEF1) && (ch == 1)) {
> -               netdev_dbg(ndev, "Ch1: ECC Error flag\n");
> -               stats->tx_dropped++;
> +       if (gpriv->info->has_gerfl_eef) {
> +               if ((gerfl & RCANFD_GERFL_EEF0) && ch == 0) {
> +                       netdev_dbg(ndev, "Ch0: ECC Error flag\n");
> +                       stats->tx_dropped++;
> +               }
> +               if ((gerfl & RCANFD_GERFL_EEF1) && ch == 1) {
> +                       netdev_dbg(ndev, "Ch1: ECC Error flag\n");
> +                       stats->tx_dropped++;
> +               }

BTW, this fails to check the ECC error flags for channels 2-7 on R-Car
V3U, which is a pre-existing problem.  As that is a bug, I have sent
a fix[1], which unfortunately conflicts with your patch. Sorry for that.

>         }
>         if (gerfl & RCANFD_GERFL_MES) {
>                 sts = rcar_canfd_read(priv->base,

[1] "[PATCH] can: rcar_canfd: Add missing ECC error checks for channels 2-7"
    https://lore.kernel.org/r/4edb2ea46cc64d0532a08a924179827481e14b4f.1666951503.git.geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds