From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5300C43217 for ; Tue, 28 Dec 2021 10:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234073AbhL1KWO (ORCPT ); Tue, 28 Dec 2021 05:22:14 -0500 Received: from mail-ua1-f52.google.com ([209.85.222.52]:36532 "EHLO mail-ua1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbhL1KWM (ORCPT ); Tue, 28 Dec 2021 05:22:12 -0500 Received: by mail-ua1-f52.google.com with SMTP id r15so31300120uao.3; Tue, 28 Dec 2021 02:22:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XlHqM3s89iXtoWPBbjZMgYeJo6DHmFUlBr+aZlxVLoA=; b=q1YdajygjkQHu5ABSonWIWLBmV6Kx/qvtXSmNrMoyy7FCc6f8uOMNzF/TD06hW3gVn gX2zb/J+TnTD5kzUuSqpBzA4Pop476NaBjmu1UebI3l7NK3OvU7KXKCYfPBA4LHfZCAt GHf/42p0AWTkZ6iEgniQkBeZg/n5WCNj7y95pcILOd8bmQAebWQM2UVUrAE755faa12J lOCc0K5XjXeQx3ZFP1W70G9947nu6l8e7T1pnpEoBpP1lvAig+5uJQm6hsHhffv+imPW 9o0G7obDwaF8+/7fsCZOO6jlt9epbKlHCDAXcHVmMMH+n46viS3MQKw8Sis1AY+Gm44r 7lMQ== X-Gm-Message-State: AOAM532Hc+ArOpFoQ1Jrd6seU9Gf7I9Idm7XG7N3gRLbOnUwo3Pr3t4S 1OnU2jthlIoL2HPAAumQH3qZAqBDDerfFQ== X-Google-Smtp-Source: ABdhPJxGeg4vABh1qSkMFju3Lr7SrVkB7xRQvvi3AUXFhVALjgiZVrIXi4syUQKPtuzRu8GQRxiy+w== X-Received: by 2002:a05:6102:e8b:: with SMTP id l11mr5977878vst.37.1640686931130; Tue, 28 Dec 2021 02:22:11 -0800 (PST) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id l28sm3947514vkn.45.2021.12.28.02.22.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 02:22:10 -0800 (PST) Received: by mail-ua1-f43.google.com with SMTP id c36so5672737uae.13; Tue, 28 Dec 2021 02:22:10 -0800 (PST) X-Received: by 2002:a67:c81c:: with SMTP id u28mr5694404vsk.38.1640686930392; Tue, 28 Dec 2021 02:22:10 -0800 (PST) MIME-Version: 1.0 References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-11-schnelle@linux.ibm.com> In-Reply-To: <20211227164317.4146918-11-schnelle@linux.ibm.com> From: Geert Uytterhoeven Date: Tue, 28 Dec 2021 11:21:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 10/32] i2c: Kconfig: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, Linux I2C Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On Mon, Dec 27, 2021 at 5:49 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Thanks for your patch! > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -828,6 +828,7 @@ config I2C_NPCM7XX > > config I2C_OCORES > tristate "OpenCores I2C Controller" > + depends on HAS_IOPORT While drivers/i2c/busses/i2c-ocores.c does use {in,out}(), I doubt this is used to access legacy I/O space. > help > If you say yes to this option, support will be included for the > OpenCores I2C controller. For details see > @@ -1227,6 +1228,7 @@ config I2C_CP2615 > config I2C_PARPORT > tristate "Parallel port adapter" > depends on PARPORT > + depends on HAS_IOPORT Same as PRINTER: shouldn't this work with all parport drivers? > select I2C_ALGOBIT > select I2C_SMBUS > help Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CE76C433EF for ; Tue, 28 Dec 2021 10:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0XriftxlpHlqAFiKgbrH206nCokvSJONb6j5fQ1EVTU=; b=ntcvbWkJwMUHFy 4hTTDmjoAmepVnLy/T55oxILdlHwcK6+gYytYinA/+z6ALawNXC7CVmH5y28iHl0pPbw4QnU2Tj39 +ghbk5wXK3dysryPAMOWqPr4xXz+hUgm2GXVucCmbU3tLK2rXpK//Dhf/t5IfQdC8UasvXbYXc+SD pyEW98jnRYOJlRr91hrikN/1B6Xrkt/ionPXBi6UMPyFZ9bx3d9rFIZgE8G4VjEWHN/mpbfcE9rEh FQm898IjGvbajolPrvQfqC1tgjwoNvQGziznkZN/xDx6OhpbO6JBM2bbQgONErlhvQ1J6ibxSwm95 EpaYubd5ECUv12slFKAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29cY-000fIO-AN; Tue, 28 Dec 2021 10:22:18 +0000 Received: from mail-ua1-f49.google.com ([209.85.222.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29cV-000fHG-Bc for linux-riscv@lists.infradead.org; Tue, 28 Dec 2021 10:22:16 +0000 Received: by mail-ua1-f49.google.com with SMTP id c36so5672836uae.13 for ; Tue, 28 Dec 2021 02:22:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XlHqM3s89iXtoWPBbjZMgYeJo6DHmFUlBr+aZlxVLoA=; b=Xfch5SAUW3ZMlYHxr5ymxH1iaNr/DFbb4GSX1nke8niSG8+PBRfQKCC3c8YRCDvZPU e7/xt0XTpvvpIP2qKrU0s+fuBBcMnTglzd+WjPAVKuSUkIk1co32JqKdCwMGi/+xh1HV 86yTw762oHeR6acyh8tIIjLNgoeeCoRIl8HWQbgt2YX2GyppuwPwQku3b/kf2rHWcTMM yy1RmV7ly4SJJM/Cf+ILd7V7QBVo6LIIMnHmWyRPt7L5i/NyaKw70l6A52UYpAb5WyZK x/KgEBfLdkKwtPg36Zmn1qD42M6/j8y2Ipaz9j1/wPzHXtfiB4kXSEw429Jxvc2LewuA UDNA== X-Gm-Message-State: AOAM533RFSNMWof9x8R670fI9gHUgpJZl+rqkQ7GO2vXQ+7LQbEkW0pS W1vSNuLbBfQqD6Ed3KnxLhuED4Djf5HPQw== X-Google-Smtp-Source: ABdhPJwKDnFksVFK6rnHjGyXlsMRk7wVkDX67HHP7PwcuKArO4elWCBUub5CcKaHguzIYkrX6vXvSA== X-Received: by 2002:ab0:7a4f:: with SMTP id a15mr2662979uat.73.1640686931318; Tue, 28 Dec 2021 02:22:11 -0800 (PST) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com. [209.85.222.51]) by smtp.gmail.com with ESMTPSA id a65sm3744296vkg.27.2021.12.28.02.22.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 02:22:10 -0800 (PST) Received: by mail-ua1-f51.google.com with SMTP id p2so31033879uad.11 for ; Tue, 28 Dec 2021 02:22:10 -0800 (PST) X-Received: by 2002:a67:c81c:: with SMTP id u28mr5694404vsk.38.1640686930392; Tue, 28 Dec 2021 02:22:10 -0800 (PST) MIME-Version: 1.0 References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-11-schnelle@linux.ibm.com> In-Reply-To: <20211227164317.4146918-11-schnelle@linux.ibm.com> From: Geert Uytterhoeven Date: Tue, 28 Dec 2021 11:21:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 10/32] i2c: Kconfig: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, Linux I2C X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_022215_432354_78D602A0 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Niklas, On Mon, Dec 27, 2021 at 5:49 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Thanks for your patch! > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -828,6 +828,7 @@ config I2C_NPCM7XX > > config I2C_OCORES > tristate "OpenCores I2C Controller" > + depends on HAS_IOPORT While drivers/i2c/busses/i2c-ocores.c does use {in,out}(), I doubt this is used to access legacy I/O space. > help > If you say yes to this option, support will be included for the > OpenCores I2C controller. For details see > @@ -1227,6 +1228,7 @@ config I2C_CP2615 > config I2C_PARPORT > tristate "Parallel port adapter" > depends on PARPORT > + depends on HAS_IOPORT Same as PRINTER: shouldn't this work with all parport drivers? > select I2C_ALGOBIT > select I2C_SMBUS > help Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv