From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 783BAC4167D for ; Thu, 9 Nov 2023 07:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbjKIH5N convert rfc822-to-8bit (ORCPT ); Thu, 9 Nov 2023 02:57:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232778AbjKIH5N (ORCPT ); Thu, 9 Nov 2023 02:57:13 -0500 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7DDF2712; Wed, 8 Nov 2023 23:57:10 -0800 (PST) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5a84204e7aeso7438897b3.0; Wed, 08 Nov 2023 23:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699516630; x=1700121430; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b28VPbp8gB3rXtgafI6M110iwvDhv/DLhKESOoHQijM=; b=cUnYD72c3LSlq7aKD1CSqx4Vgvx3BFpJscLvXCIR72srdTpsrYQq71l05Ct2yjd6sp PEU4uDkmdbNJN6MSEdewyLTIJPKaExRlTYc1Iii/47OnF/xzgWeQm6Bo+zO42PHA6Y1d wgMqWZ+w3rva4CXSlPc/JHD0Yc2Pq8swPg5DdVd9s0Y+IG8xkPHTzeK3UqRzegkkRV+e n2+hXqAiBbgBCBp+VniALFXolC3SjnBbB5i9tqlqtmo4q/4WEmkOqiuBZa8JtctS6H/b XKoNeVACjIIJFkXAImjuhmxn2OnemC70UGWXxndgPpKcUACS7A6ZiLvqJ9qRMtfjNbyN uGBg== X-Gm-Message-State: AOJu0Yx2O28EFLlLaGxdwvEhQ1odg0cZ6I4HZqv26Yt5+lWrgjoQvhPV huV5YD04GhSX2rygvnB6BB9vwEUCqYPWZQ== X-Google-Smtp-Source: AGHT+IEDko6/mRdN7OR+50u/xnE67stOpkHlHWy+FLhYSWnAXZ6/PfmYxEi7JzyQ7gSZykL204WFzw== X-Received: by 2002:a0d:df85:0:b0:5af:b0ca:6950 with SMTP id i127-20020a0ddf85000000b005afb0ca6950mr4441873ywe.42.1699516629909; Wed, 08 Nov 2023 23:57:09 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id r190-20020a0dcfc7000000b005a7aef2c1c3sm7837382ywd.132.2023.11.08.23.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 23:57:09 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5a84204e7aeso7438687b3.0; Wed, 08 Nov 2023 23:57:09 -0800 (PST) X-Received: by 2002:a81:84cc:0:b0:5a7:fa8b:3fa6 with SMTP id u195-20020a8184cc000000b005a7fa8b3fa6mr4343779ywf.9.1699516629341; Wed, 08 Nov 2023 23:57:09 -0800 (PST) MIME-Version: 1.0 References: <20231108171149.258656-1-biju.das.jz@bp.renesas.com> <20231108171149.258656-2-biju.das.jz@bp.renesas.com> In-Reply-To: <20231108171149.258656-2-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 9 Nov 2023 08:56:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 1/4] spi: spi-mem: Add set_iofv() callback To: Biju Das Cc: Mark Brown , linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, Prabhakar Mahadev Lad , Miquel Raynal , Michael Walle , Biju Das , linux-renesas-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On Wed, Nov 8, 2023 at 6:12 PM Biju Das wrote: > As per section 8.14 on the AT25QL128A hardware manual, > IO0..IO3 must be set to Hi-Z state for this flash for fast read quad IO. > Snippet from HW manual section 8.14: > The upper nibble of the Mode(M7-4) controls the length of the next FAST > Read Quad IO instruction through the inclusion or exclusion of the first > byte instruction code. The lower nibble bits of the Mode(M3-0) are don't > care. However, the IO pins must be high-impedance before the falling edge > of the first data out clock. > > Add set_iofv() callback for configuring IO fixed values to control the > pin state. > > Signed-off-by: Biju Das Thanks for your patch! > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -297,6 +297,26 @@ static void spi_mem_access_end(struct spi_mem *mem) > pm_runtime_put(ctlr->dev.parent); > } > > +/** > + * spi_mem_set_iofv() - Set IO fixed values to control the pin state > + * @mem: the SPI memory > + * @val: the IO fixed values Please document the meaning of this value (i.e. what does a set or cleared bit mean?). > + * > + * Set IO fixed values to control the pin state. > + * > + * Return: 0 in case of success, a negative error code otherwise. > + */ > +int spi_mem_set_iofv(struct spi_mem *mem, u32 val) > +{ > + struct spi_controller *ctlr = mem->spi->controller; > + > + if (ctlr->mem_ops && ctlr->mem_ops->set_iofv) > + return ctlr->mem_ops->set_iofv(mem, val); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(spi_mem_set_iofv); > + > /** > * spi_mem_exec_op() - Execute a memory operation > * @mem: the SPI memory Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B93C4332F for ; Thu, 9 Nov 2023 07:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2z4bVZwwhWUONNtAZmWCGqbZyYiB4wQPAM6Md+KwKhY=; b=LJZAcp1n926wgb fHUqWZqPci+v/JX6UmOznC5jQEwAYWe/PQHQr9n4Trn5Ew3UHZdUXM0X0Ayr3l/2NM9Tux2cBxB5Z 9CBzQOgE+CY2nVzNQoIZsM+sjDiiPu6Oj/O6YFo0OYjAemXh8Tc/z6JvrGZNe7+Oc+Sy1KPMChDbt UCXajnALl+d2vRl4jXQBzE6C99nOnKMKYfw/YwiqyhY4mH/OKyAg9MUylUWN8BEV/4KYELoNVXEyq DHhaDPt1MtV63gDumvN1SKC1ITI1Gy1ILN7H/iZ3V/sDPnXtmOxmdHyStSDqwy8fZhsPd1V1xvQUL yICFhHMqOH71d81OzNQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0zuj-005YMG-2u; Thu, 09 Nov 2023 07:57:21 +0000 Received: from mail-yw1-f174.google.com ([209.85.128.174]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0zuh-005YL8-28 for linux-mtd@lists.infradead.org; Thu, 09 Nov 2023 07:57:21 +0000 Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5ae143e08b1so7185957b3.1 for ; Wed, 08 Nov 2023 23:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699516630; x=1700121430; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b28VPbp8gB3rXtgafI6M110iwvDhv/DLhKESOoHQijM=; b=tWvNZaP+Z6hXFSlrXyt01F2ZG7Uwfcuym946aCcz+kiw0nQB8TqzbbDfbxNOhTpVos n6Yg7GILelFkIhDb5RDL3hnftiHlZxwYayf7lhsfsG+a46n4maT2xuPmWYrk+BKeL3hA e4o4Iv4T8zsciQ02D9zUuWpZ0UNkasW34FRpRIKQCaPVy4cyEYUnd7AAXQf6g4pi+3dr ATjM6e4yIJZGifNuvzHgRM/MjBd059Dy3631gCq6yLmUOGd+F+PcQNwHx7IbVi0o0nx3 YGxLiuD2/0Mq3ALggsmELtRa9IKctM33lYtr0NUxKplLViFAP1gyB44f12LNwF0bktlQ zLvw== X-Gm-Message-State: AOJu0YydvQ5nsQA8iI0mJSbguqOMz6+iUDrtSCRRD0b8rUQ8poqzhm3E GQ72J3j3E/CVA7sWy8fCXFZpUFeNH02KkQ== X-Google-Smtp-Source: AGHT+IEt2qBjHylsx/rNOwANJoYZclJdgH5Wx3bR0lUKNCh8nCWG8IQsPfdP8gSoccU67XOBe5Jxag== X-Received: by 2002:a0d:d952:0:b0:5a7:ba09:52c7 with SMTP id b79-20020a0dd952000000b005a7ba0952c7mr4297748ywe.11.1699516630037; Wed, 08 Nov 2023 23:57:10 -0800 (PST) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com. [209.85.128.176]) by smtp.gmail.com with ESMTPSA id b12-20020a0dd90c000000b005b59652bcdesm7734669ywe.60.2023.11.08.23.57.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 23:57:09 -0800 (PST) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-5bf58914bacso4143037b3.3 for ; Wed, 08 Nov 2023 23:57:09 -0800 (PST) X-Received: by 2002:a81:84cc:0:b0:5a7:fa8b:3fa6 with SMTP id u195-20020a8184cc000000b005a7fa8b3fa6mr4343779ywf.9.1699516629341; Wed, 08 Nov 2023 23:57:09 -0800 (PST) MIME-Version: 1.0 References: <20231108171149.258656-1-biju.das.jz@bp.renesas.com> <20231108171149.258656-2-biju.das.jz@bp.renesas.com> In-Reply-To: <20231108171149.258656-2-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 9 Nov 2023 08:56:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 1/4] spi: spi-mem: Add set_iofv() callback To: Biju Das Cc: Mark Brown , linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, Prabhakar Mahadev Lad , Miquel Raynal , Michael Walle , Biju Das , linux-renesas-soc@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_235719_700333_16BB2E5A X-CRM114-Status: GOOD ( 26.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQmlqdSwKCk9uIFdlZCwgTm92IDgsIDIwMjMgYXQgNjoxMuKAr1BNIEJpanUgRGFzIDxiaWp1 LmRhcy5qekBicC5yZW5lc2FzLmNvbT4gd3JvdGU6Cj4gQXMgcGVyIHNlY3Rpb24gOC4xNCBvbiB0 aGUgQVQyNVFMMTI4QSBoYXJkd2FyZSBtYW51YWwsCj4gSU8wLi5JTzMgbXVzdCBiZSBzZXQgdG8g SGktWiBzdGF0ZSBmb3IgdGhpcyBmbGFzaCBmb3IgZmFzdCByZWFkIHF1YWQgSU8uCj4gU25pcHBl dCBmcm9tIEhXIG1hbnVhbCBzZWN0aW9uIDguMTQ6Cj4gVGhlIHVwcGVyIG5pYmJsZSBvZiB0aGUg TW9kZShNNy00KSBjb250cm9scyB0aGUgbGVuZ3RoIG9mIHRoZSBuZXh0IEZBU1QKPiBSZWFkIFF1 YWQgSU8gaW5zdHJ1Y3Rpb24gdGhyb3VnaCB0aGUgaW5jbHVzaW9uIG9yIGV4Y2x1c2lvbiBvZiB0 aGUgZmlyc3QKPiBieXRlIGluc3RydWN0aW9uIGNvZGUuIFRoZSBsb3dlciBuaWJibGUgYml0cyBv ZiB0aGUgTW9kZShNMy0wKSBhcmUgZG9uJ3QKPiBjYXJlLiBIb3dldmVyLCB0aGUgSU8gcGlucyBt dXN0IGJlIGhpZ2gtaW1wZWRhbmNlIGJlZm9yZSB0aGUgZmFsbGluZyBlZGdlCj4gb2YgdGhlIGZp cnN0IGRhdGEgb3V0IGNsb2NrLgo+Cj4gQWRkIHNldF9pb2Z2KCkgY2FsbGJhY2sgZm9yIGNvbmZp Z3VyaW5nIElPIGZpeGVkIHZhbHVlcyB0byBjb250cm9sIHRoZQo+IHBpbiBzdGF0ZS4KPgo+IFNp Z25lZC1vZmYtYnk6IEJpanUgRGFzIDxiaWp1LmRhcy5qekBicC5yZW5lc2FzLmNvbT4KClRoYW5r cyBmb3IgeW91ciBwYXRjaCEKCj4gLS0tIGEvZHJpdmVycy9zcGkvc3BpLW1lbS5jCj4gKysrIGIv ZHJpdmVycy9zcGkvc3BpLW1lbS5jCj4gQEAgLTI5Nyw2ICsyOTcsMjYgQEAgc3RhdGljIHZvaWQg c3BpX21lbV9hY2Nlc3NfZW5kKHN0cnVjdCBzcGlfbWVtICptZW0pCj4gICAgICAgICAgICAgICAg IHBtX3J1bnRpbWVfcHV0KGN0bHItPmRldi5wYXJlbnQpOwo+ICB9Cj4KPiArLyoqCj4gKyAqIHNw aV9tZW1fc2V0X2lvZnYoKSAtIFNldCBJTyBmaXhlZCB2YWx1ZXMgdG8gY29udHJvbCB0aGUgcGlu IHN0YXRlCj4gKyAqIEBtZW06IHRoZSBTUEkgbWVtb3J5Cj4gKyAqIEB2YWw6IHRoZSBJTyBmaXhl ZCB2YWx1ZXMKClBsZWFzZSBkb2N1bWVudCB0aGUgbWVhbmluZyBvZiB0aGlzIHZhbHVlIChpLmUu IHdoYXQgZG9lcyBhCnNldCBvciBjbGVhcmVkIGJpdCBtZWFuPykuCgo+ICsgKgo+ICsgKiBTZXQg SU8gZml4ZWQgdmFsdWVzIHRvIGNvbnRyb2wgdGhlIHBpbiBzdGF0ZS4KPiArICoKPiArICogUmV0 dXJuOiAwIGluIGNhc2Ugb2Ygc3VjY2VzcywgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG90aGVyd2lz ZS4KPiArICovCj4gK2ludCBzcGlfbWVtX3NldF9pb2Z2KHN0cnVjdCBzcGlfbWVtICptZW0sIHUz MiB2YWwpCj4gK3sKPiArICAgICAgIHN0cnVjdCBzcGlfY29udHJvbGxlciAqY3RsciA9IG1lbS0+ c3BpLT5jb250cm9sbGVyOwo+ICsKPiArICAgICAgIGlmIChjdGxyLT5tZW1fb3BzICYmIGN0bHIt Pm1lbV9vcHMtPnNldF9pb2Z2KQo+ICsgICAgICAgICAgICAgICByZXR1cm4gY3Rsci0+bWVtX29w cy0+c2V0X2lvZnYobWVtLCB2YWwpOwo+ICsKPiArICAgICAgIHJldHVybiAwOwo+ICt9Cj4gK0VY UE9SVF9TWU1CT0xfR1BMKHNwaV9tZW1fc2V0X2lvZnYpOwo+ICsKPiAgLyoqCj4gICAqIHNwaV9t ZW1fZXhlY19vcCgpIC0gRXhlY3V0ZSBhIG1lbW9yeSBvcGVyYXRpb24KPiAgICogQG1lbTogdGhl IFNQSSBtZW1vcnkKCkdye29ldGplLGVldGluZ31zLAoKICAgICAgICAgICAgICAgICAgICAgICAg R2VlcnQKCi0tIApHZWVydCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4IGJl eW9uZCBpYTMyIC0tIGdlZXJ0QGxpbnV4LW02OGsub3JnCgpJbiBwZXJzb25hbCBjb252ZXJzYXRp b25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0Cndo ZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Ig c29tZXRoaW5nIGxpa2UgdGhhdC4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBM aW51cyBUb3J2YWxkcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K